Title: [251653] trunk/Tools
- Revision
- 251653
- Author
- aakash_j...@apple.com
- Date
- 2019-10-28 07:57:57 -0700 (Mon, 28 Oct 2019)
Log Message
[ews] Improve summary for CompileWebKit and CompileJSC build step
https://bugs.webkit.org/show_bug.cgi?id=203487
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(CompileWebKit.getResultSummary): Method to generate custom status message.
(CompileJSC.getResultSummary): Ditto.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (251652 => 251653)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-10-28 10:31:19 UTC (rev 251652)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-10-28 14:57:57 UTC (rev 251653)
@@ -828,7 +828,12 @@
return super(CompileWebKit, self).evaluateCommand(cmd)
+ def getResultSummary(self):
+ if self.results == FAILURE:
+ return {u'step': u'Failed to compile WebKit'}
+ return shell.Compile.getResultSummary(self)
+
class CompileWebKitToT(CompileWebKit):
name = 'compile-webkit-tot'
haltOnFailure = False
@@ -884,7 +889,12 @@
self.setProperty('group', 'jsc')
return CompileWebKit.start(self)
+ def getResultSummary(self):
+ if self.results == FAILURE:
+ return {u'step': u'Failed to compile JSC'}
+ return shell.Compile.getResultSummary(self)
+
class CompileJSCToT(CompileJSC):
name = 'compile-jsc-tot'
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (251652 => 251653)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-10-28 10:31:19 UTC (rev 251652)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-10-28 14:57:57 UTC (rev 251653)
@@ -831,7 +831,7 @@
+ ExpectShell.log('stdio', stdout='1 error generated.')
+ 2,
)
- self.expectOutcome(result=FAILURE, state_string='Compiled WebKit (failure)')
+ self.expectOutcome(result=FAILURE, state_string='Failed to compile WebKit')
return self.runStep()
@@ -871,7 +871,7 @@
+ ExpectShell.log('stdio', stdout='1 error generated.')
+ 2,
)
- self.expectOutcome(result=FAILURE, state_string='Compiled WebKit (failure)')
+ self.expectOutcome(result=FAILURE, state_string='Failed to compile WebKit')
return self.runStep()
def test_skip(self):
@@ -944,7 +944,7 @@
+ ExpectShell.log('stdio', stdout='1 error generated.')
+ 2,
)
- self.expectOutcome(result=FAILURE, state_string='Compiled JSC (failure)')
+ self.expectOutcome(result=FAILURE, state_string='Failed to compile JSC')
return self.runStep()
@@ -983,7 +983,7 @@
+ ExpectShell.log('stdio', stdout='1 error generated.')
+ 2,
)
- self.expectOutcome(result=FAILURE, state_string='Compiled JSC (failure)')
+ self.expectOutcome(result=FAILURE, state_string='Failed to compile JSC')
return self.runStep()
Modified: trunk/Tools/ChangeLog (251652 => 251653)
--- trunk/Tools/ChangeLog 2019-10-28 10:31:19 UTC (rev 251652)
+++ trunk/Tools/ChangeLog 2019-10-28 14:57:57 UTC (rev 251653)
@@ -1,3 +1,15 @@
+2019-10-28 Aakash Jain <aakash_j...@apple.com>
+
+ [ews] Improve summary for CompileWebKit and CompileJSC build step
+ https://bugs.webkit.org/show_bug.cgi?id=203487
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (CompileWebKit.getResultSummary): Method to generate custom status message.
+ (CompileJSC.getResultSummary): Ditto.
+ * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+
2019-10-21 Jiewen Tan <jiewen_...@apple.com>
[WebAuthn] Warn users when multiple NFC tags present
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
