Title: [251656] trunk
Revision
251656
Author
clo...@igalia.com
Date
2019-10-28 09:25:17 -0700 (Mon, 28 Oct 2019)

Log Message

[GTK][WPE] Enable CSS typed OM
https://bugs.webkit.org/show_bug.cgi?id=192875

Reviewed by Carlos Garcia Campos.

.:

This enables the feature when building with experimental features enabled.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Source/WebKit:

Enable the runtime feature by default on GTK/WPE when building with
experimental features enabled.

Covered by existing tests.

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:

LayoutTests:

Unskip the tests that now pass.

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

Diff

Modified: trunk/ChangeLog (251655 => 251656)


--- trunk/ChangeLog	2019-10-28 16:02:53 UTC (rev 251655)
+++ trunk/ChangeLog	2019-10-28 16:25:17 UTC (rev 251656)
@@ -1,3 +1,15 @@
+2019-10-28  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [GTK][WPE] Enable CSS typed OM
+        https://bugs.webkit.org/show_bug.cgi?id=192875
+
+        Reviewed by Carlos Garcia Campos.
+
+        This enables the feature when building with experimental features enabled.
+
+        * Source/cmake/OptionsGTK.cmake:
+        * Source/cmake/OptionsWPE.cmake:
+
 2019-10-26  Chris Lord  <cl...@igalia.com>
 
         Put OffscreenCanvas behind a build flag

Modified: trunk/LayoutTests/ChangeLog (251655 => 251656)


--- trunk/LayoutTests/ChangeLog	2019-10-28 16:02:53 UTC (rev 251655)
+++ trunk/LayoutTests/ChangeLog	2019-10-28 16:25:17 UTC (rev 251656)
@@ -1,3 +1,15 @@
+2019-10-28  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [GTK][WPE] Enable CSS typed OM
+        https://bugs.webkit.org/show_bug.cgi?id=192875
+
+        Reviewed by Carlos Garcia Campos.
+
+        Unskip the tests that now pass.
+
+        * platform/gtk/TestExpectations:
+        * platform/wpe/TestExpectations:
+
 2019-10-28  Simon Fraser  <simon.fra...@apple.com>
 
         Can't change @font-face descriptors from fontFaceRule.style.setProperty()

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (251655 => 251656)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2019-10-28 16:02:53 UTC (rev 251655)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2019-10-28 16:25:17 UTC (rev 251656)
@@ -720,9 +720,6 @@
 # ENABLE(CSS_SCROLL_SNAP) is disabled.
 css3/scroll-snap [ Skip ]
 
-# ENABLE(CSS_TYPED_OM) is disabled.
-webkit.org/b/192875 css-typedom [ Skip ]
-
 # ENABLE(CSS_PAINTING_API) is disabled.
 webkit.org/b/190710 fast/css-custom-paint [ Skip ]
 

Modified: trunk/LayoutTests/platform/wpe/TestExpectations (251655 => 251656)


--- trunk/LayoutTests/platform/wpe/TestExpectations	2019-10-28 16:02:53 UTC (rev 251655)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2019-10-28 16:25:17 UTC (rev 251656)
@@ -197,9 +197,6 @@
 # ENABLE_DARK_MODE_CSS is OFF in WPE.
 css-dark-mode [ Skip ]
 
-# ENABLE(CSS_TYPED_OM) is disabled.
-webkit.org/b/192875 css-typedom [ Skip ]
-
 # ENABLE(CSS_PAINTING_API) is disabled
 webkit.org/b/190710 fast/css-custom-paint [ Skip ]
 

Modified: trunk/Source/WebKit/ChangeLog (251655 => 251656)


--- trunk/Source/WebKit/ChangeLog	2019-10-28 16:02:53 UTC (rev 251655)
+++ trunk/Source/WebKit/ChangeLog	2019-10-28 16:25:17 UTC (rev 251656)
@@ -1,3 +1,18 @@
+2019-10-28  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [GTK][WPE] Enable CSS typed OM
+        https://bugs.webkit.org/show_bug.cgi?id=192875
+
+        Reviewed by Carlos Garcia Campos.
+
+        Enable the runtime feature by default on GTK/WPE when building with
+        experimental features enabled.
+
+        Covered by existing tests.
+
+        * Shared/WebPreferences.yaml:
+        * Shared/WebPreferencesDefaultValues.h:
+
 2019-10-28  Carlos Garcia Campos  <cgar...@igalia.com>
 
         [GTK] Simplify the Input Method implementation

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (251655 => 251656)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-10-28 16:02:53 UTC (rev 251655)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-10-28 16:25:17 UTC (rev 251656)
@@ -1388,7 +1388,7 @@
 
 CSSTypedOMEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: DEFAULT_CSS_TYPED_OM_ENABLED
   humanReadableName: "CSS Typed OM"
   humanReadableDescription: "Enable the CSS Typed OM"
   webcoreBinding: RuntimeEnabledFeatures

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (251655 => 251656)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2019-10-28 16:02:53 UTC (rev 251655)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2019-10-28 16:25:17 UTC (rev 251656)
@@ -282,6 +282,11 @@
 #define DEFAULT_ASYNC_OVERFLOW_SCROLLING_ENABLED false
 #endif
 
+#if ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK) || PLATFORM(WPE))
+#define DEFAULT_CSS_TYPED_OM_ENABLED true
+#else
+#define DEFAULT_CSS_TYPED_OM_ENABLED false
+#endif
 
 #if ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK) || PLATFORM(WPE))
 #define DEFAULT_SERVER_TIMING_ENABLED true

Modified: trunk/Source/cmake/OptionsGTK.cmake (251655 => 251656)


--- trunk/Source/cmake/OptionsGTK.cmake	2019-10-28 16:02:53 UTC (rev 251655)
+++ trunk/Source/cmake/OptionsGTK.cmake	2019-10-28 16:25:17 UTC (rev 251656)
@@ -163,6 +163,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHAREABLE_RESOURCE PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
 
 include(GStreamerDependencies)
 

Modified: trunk/Source/cmake/OptionsWPE.cmake (251655 => 251656)


--- trunk/Source/cmake/OptionsWPE.cmake	2019-10-28 16:02:53 UTC (rev 251655)
+++ trunk/Source/cmake/OptionsWPE.cmake	2019-10-28 16:25:17 UTC (rev 251656)
@@ -60,6 +60,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL2 PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
 
 # Public options specific to the WPE port. Do not add any options here unless
 # there is a strong reason we should support changing the value of the option,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to