Title: [253077] tags/Safari-609.1.11/Source/WebCore
Revision
253077
Author
alanc...@apple.com
Date
2019-12-03 18:10:29 -0800 (Tue, 03 Dec 2019)

Log Message

Cherry-pick r252881. rdar://problem/57487005

    Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad)
    https://bugs.webkit.org/show_bug.cgi?id=204593

    Reviewed by Antti Koivisto.

    After r252761, we no longer triggers a fragment scrolling as a part of style resolution.
    Consequently, there is no need for Document::needsStyleRecalc() to return true
    even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets.

    No new tests since there shouldn't really be any observable behavior difference.

    * dom/Document.cpp:
    (WebCore::Document::needsStyleRecalc const):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: tags/Safari-609.1.11/Source/WebCore/ChangeLog (253076 => 253077)


--- tags/Safari-609.1.11/Source/WebCore/ChangeLog	2019-12-04 02:04:01 UTC (rev 253076)
+++ tags/Safari-609.1.11/Source/WebCore/ChangeLog	2019-12-04 02:10:29 UTC (rev 253077)
@@ -1,3 +1,40 @@
+2019-12-03  Kocsen Chung  <kocsen_ch...@apple.com>
+
+        Cherry-pick r252881. rdar://problem/57487005
+
+    Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad)
+    https://bugs.webkit.org/show_bug.cgi?id=204593
+    
+    Reviewed by Antti Koivisto.
+    
+    After r252761, we no longer triggers a fragment scrolling as a part of style resolution.
+    Consequently, there is no need for Document::needsStyleRecalc() to return true
+    even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets.
+    
+    No new tests since there shouldn't really be any observable behavior difference.
+    
+    * dom/Document.cpp:
+    (WebCore::Document::needsStyleRecalc const):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-11-26  Ryosuke Niwa  <rn...@webkit.org>
+
+            Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad)
+            https://bugs.webkit.org/show_bug.cgi?id=204593
+
+            Reviewed by Antti Koivisto.
+
+            After r252761, we no longer triggers a fragment scrolling as a part of style resolution.
+            Consequently, there is no need for Document::needsStyleRecalc() to return true
+            even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets.
+
+            No new tests since there shouldn't really be any observable behavior difference.
+
+            * dom/Document.cpp:
+            (WebCore::Document::needsStyleRecalc const):
+
 2019-12-03  Alan Coon  <alanc...@apple.com>
 
         Cherry-pick r252956. rdar://problem/57438874

Modified: tags/Safari-609.1.11/Source/WebCore/dom/Document.cpp (253076 => 253077)


--- tags/Safari-609.1.11/Source/WebCore/dom/Document.cpp	2019-12-04 02:04:01 UTC (rev 253076)
+++ tags/Safari-609.1.11/Source/WebCore/dom/Document.cpp	2019-12-04 02:10:29 UTC (rev 253077)
@@ -2029,10 +2029,6 @@
     if (styleScope().hasPendingUpdate())
         return true;
 
-    // Ensure this happens eventually as it is currently in resolveStyle. This can be removed if the code moves.
-    if (m_gotoAnchorNeededAfterStylesheetsLoad && !styleScope().hasPendingSheets())
-        return true;
-
     return false;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to