Title: [253642] trunk/Source/WebKit
- Revision
- 253642
- Author
- commit-qu...@webkit.org
- Date
- 2019-12-17 13:22:56 -0800 (Tue, 17 Dec 2019)
Log Message
Drop support for NSURLCache callbacks in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=203344
Patch by Benjamin Nham <n...@apple.com> on 2019-12-17
Reviewed by Alex Christensen.
Remove the NSURLSession caching policy callback in NetworkProcess. It's no longer necessary since
we don't use NSURLCache in NetworkProcess (https://bugs.webkit.org/show_bug.cgi?id=185990).
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (253641 => 253642)
--- trunk/Source/WebKit/ChangeLog 2019-12-17 21:07:29 UTC (rev 253641)
+++ trunk/Source/WebKit/ChangeLog 2019-12-17 21:22:56 UTC (rev 253642)
@@ -1,3 +1,16 @@
+2019-12-17 Benjamin Nham <n...@apple.com>
+
+ Drop support for NSURLCache callbacks in NetworkProcess
+ https://bugs.webkit.org/show_bug.cgi?id=203344
+
+ Reviewed by Alex Christensen.
+
+ Remove the NSURLSession caching policy callback in NetworkProcess. It's no longer necessary since
+ we don't use NSURLCache in NetworkProcess (https://bugs.webkit.org/show_bug.cgi?id=185990).
+
+ * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+ (-[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:]): Deleted.
+
2019-12-17 David Kilzer <ddkil...@apple.com>
Remove SafeBrowsingResult
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (253641 => 253642)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2019-12-17 21:07:29 UTC (rev 253641)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2019-12-17 21:22:56 UTC (rev 253642)
@@ -594,16 +594,6 @@
}
}
-- (void)URLSession:(NSURLSession *)session dataTask:(NSURLSessionDataTask *)dataTask willCacheResponse:(NSCachedURLResponse *)proposedResponse completionHandler:(void (^)(NSCachedURLResponse *cachedResponse))completionHandler
-{
- // FIXME: remove if <rdar://problem/20001985> is ever resolved.
- if ([proposedResponse.response respondsToSelector:@selector(allHeaderFields)]
- && [[(id)proposedResponse.response allHeaderFields] objectForKey:@"Content-Range"])
- completionHandler(nil);
- else
- completionHandler(proposedResponse);
-}
-
#if HAVE(CFNETWORK_NSURLSESSION_STRICTRUSTEVALUATE)
static inline void processServerTrustEvaluation(NetworkSessionCocoa *session, SessionWrapper& sessionWrapper, NSURLAuthenticationChallenge *challenge, NetworkDataTaskCocoa::TaskIdentifier taskIdentifier, NetworkDataTaskCocoa* networkDataTask, CompletionHandler<void(NSURLSessionAuthChallengeDisposition disposition, NSURLCredential *credential)>&& completionHandler)
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
