Title: [254585] branches/safari-609-branch/Source/WebCore
Revision
254585
Author
alanc...@apple.com
Date
2020-01-15 11:14:34 -0800 (Wed, 15 Jan 2020)

Log Message

Cherry-pick r254067. rdar://problem/58552878

    REGRESSION(r247626): Introduced memory regression
    https://bugs.webkit.org/show_bug.cgi?id=205815

    Unreviewed rollout of https://trac.webkit.org/changeset/247626/webkit.

    * platform/graphics/cocoa/FontCacheCoreText.cpp:
    (WebCore::FontCache::prewarmGlobally):
    (WebCore::fontFamiliesForPrewarming): Deleted.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (254584 => 254585)


--- branches/safari-609-branch/Source/WebCore/ChangeLog	2020-01-15 19:14:31 UTC (rev 254584)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog	2020-01-15 19:14:34 UTC (rev 254585)
@@ -1,5 +1,33 @@
 2020-01-14  Alan Coon  <alanc...@apple.com>
 
+        Cherry-pick r254067. rdar://problem/58552878
+
+    REGRESSION(r247626): Introduced memory regression
+    https://bugs.webkit.org/show_bug.cgi?id=205815
+    
+    Unreviewed rollout of https://trac.webkit.org/changeset/247626/webkit.
+    
+    * platform/graphics/cocoa/FontCacheCoreText.cpp:
+    (WebCore::FontCache::prewarmGlobally):
+    (WebCore::fontFamiliesForPrewarming): Deleted.
+    
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-06  Per Arne Vollan  <pvol...@apple.com>
+
+            REGRESSION(r247626): Introduced memory regression
+            https://bugs.webkit.org/show_bug.cgi?id=205815
+
+            Unreviewed rollout of https://trac.webkit.org/changeset/247626/webkit.
+
+            * platform/graphics/cocoa/FontCacheCoreText.cpp:
+            (WebCore::FontCache::prewarmGlobally):
+            (WebCore::fontFamiliesForPrewarming): Deleted.
+
+2020-01-14  Alan Coon  <alanc...@apple.com>
+
         Cherry-pick r254054. rdar://problem/58549108
 
     REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019'

Modified: branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (254584 => 254585)


--- branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2020-01-15 19:14:31 UTC (rev 254584)
+++ branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2020-01-15 19:14:34 UTC (rev 254585)
@@ -1688,9 +1688,12 @@
     });
 }
 
-static Vector<String>& fontFamiliesForPrewarming()
+void FontCache::prewarmGlobally()
 {
-    static NeverDestroyed<Vector<String>> families = std::initializer_list<String> {
+    if (MemoryPressureHandler::singleton().isUnderMemoryPressure())
+        return;
+
+    Vector<String> families = std::initializer_list<String> {
         ".SF NS Text"_s,
         ".SF NS Display"_s,
         "Arial"_s,
@@ -1700,17 +1703,9 @@
         "Times"_s,
         "Times New Roman"_s,
     };
-    return families;
-}
 
-void FontCache::prewarmGlobally()
-{
-    if (MemoryPressureHandler::singleton().isUnderMemoryPressure())
-        return;
-
     FontCache::PrewarmInformation prewarmInfo;
-    prewarmInfo.seenFamilies = fontFamiliesForPrewarming();
-    prewarmInfo.fontNamesRequiringSystemFallback = fontFamiliesForPrewarming();
+    prewarmInfo.seenFamilies = WTFMove(families);
     FontCache::singleton().prewarm(prewarmInfo);
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to