Title: [255469] trunk/Source/WebCore
Revision
255469
Author
timothy_hor...@apple.com
Date
2020-01-30 16:30:14 -0800 (Thu, 30 Jan 2020)

Log Message

Add a quirk to opt Twitter out of the non-overlaid minimized input view
https://bugs.webkit.org/show_bug.cgi?id=207021
<rdar://problem/59016252>

Reviewed by Wenson Hsieh.

* page/Quirks.cpp:
(WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
Twitter has a content breakpoint that sits immediately between the size
of the Safari content area on a 11" iPad in landscape with the App Banner
visible and the same minus the height of the minimized input view that
we display when using a hardware keyboard. This breakpoint removes the
login field, causing the keyboard to dismiss, the input view to disappear,
and the page to resize to the larger size. This results in a loop,
so we must opt Twitter out of the content-avoiding input view mechanism.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (255468 => 255469)


--- trunk/Source/WebCore/ChangeLog	2020-01-31 00:23:55 UTC (rev 255468)
+++ trunk/Source/WebCore/ChangeLog	2020-01-31 00:30:14 UTC (rev 255469)
@@ -1,3 +1,21 @@
+2020-01-30  Tim Horton  <timothy_hor...@apple.com>
+
+        Add a quirk to opt Twitter out of the non-overlaid minimized input view
+        https://bugs.webkit.org/show_bug.cgi?id=207021
+        <rdar://problem/59016252>
+
+        Reviewed by Wenson Hsieh.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
+        Twitter has a content breakpoint that sits immediately between the size
+        of the Safari content area on a 11" iPad in landscape with the App Banner
+        visible and the same minus the height of the minimized input view that
+        we display when using a hardware keyboard. This breakpoint removes the
+        login field, causing the keyboard to dismiss, the input view to disappear,
+        and the page to resize to the larger size. This results in a loop,
+        so we must opt Twitter out of the content-avoiding input view mechanism.
+
 2020-01-30  Justin Fan  <justin_...@apple.com>
 
         [WebGL] Add logging statements to attempt to catch texture-upload-size.html timeout

Modified: trunk/Source/WebCore/page/Quirks.cpp (255468 => 255469)


--- trunk/Source/WebCore/page/Quirks.cpp	2020-01-31 00:23:55 UTC (rev 255468)
+++ trunk/Source/WebCore/page/Quirks.cpp	2020-01-31 00:30:14 UTC (rev 255469)
@@ -421,6 +421,9 @@
     if (equalLettersIgnoringASCIICase(host, "live.com") || host.endsWithIgnoringASCIICase(".live.com"))
         return true;
 
+    if (equalLettersIgnoringASCIICase(host, "twitter.com") || host.endsWithIgnoringASCIICase(".twitter.com"))
+        return true;
+
     if (host.endsWithIgnoringASCIICase(".sharepoint.com"))
         return true;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to