Title: [256302] trunk/Tools
- Revision
- 256302
- Author
- commit-qu...@webkit.org
- Date
- 2020-02-11 05:09:59 -0800 (Tue, 11 Feb 2020)
Log Message
[WPE][WebDriver] MiniBrowser should react to close session commands
https://bugs.webkit.org/show_bug.cgi?id=207529
Patch by Lauro Moura <lmo...@igalia.com> on 2020-02-11
Reviewed by Carlos Garcia Campos.
WebDriver delete session command asks to close the WebView associated to the
current automation session. We must react to it to avoid lots of
timeouts and errors.
* MiniBrowser/wpe/main.cpp:
(main): Listen to "close" signal on the main WebView.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (256301 => 256302)
--- trunk/Tools/ChangeLog 2020-02-11 13:03:46 UTC (rev 256301)
+++ trunk/Tools/ChangeLog 2020-02-11 13:09:59 UTC (rev 256302)
@@ -1,3 +1,17 @@
+2020-02-11 Lauro Moura <lmo...@igalia.com>
+
+ [WPE][WebDriver] MiniBrowser should react to close session commands
+ https://bugs.webkit.org/show_bug.cgi?id=207529
+
+ Reviewed by Carlos Garcia Campos.
+
+ WebDriver delete session command asks to close the WebView associated to the
+ current automation session. We must react to it to avoid lots of
+ timeouts and errors.
+
+ * MiniBrowser/wpe/main.cpp:
+ (main): Listen to "close" signal on the main WebView.
+
2020-02-11 Wenson Hsieh <wenson_hs...@apple.com>
[iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
Modified: trunk/Tools/MiniBrowser/wpe/main.cpp (256301 => 256302)
--- trunk/Tools/MiniBrowser/wpe/main.cpp 2020-02-11 13:03:46 UTC (rev 256301)
+++ trunk/Tools/MiniBrowser/wpe/main.cpp 2020-02-11 13:09:59 UTC (rev 256302)
@@ -300,6 +300,7 @@
g_signal_connect(webContext, "automation-started", G_CALLBACK(automationStartedCallback), webView);
g_signal_connect(webView, "permission-request", G_CALLBACK(decidePermissionRequest), nullptr);
g_signal_connect(webView, "create", G_CALLBACK(createWebView), nullptr);
+ g_signal_connect(webView, "close", G_CALLBACK(webViewClose), nullptr);
if (ignoreTLSErrors)
webkit_web_context_set_tls_errors_policy(webContext, WEBKIT_TLS_ERRORS_POLICY_IGNORE);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
