Title: [256336] branches/safari-609.1.17.0-branch
- Revision
- 256336
- Author
- repst...@apple.com
- Date
- 2020-02-11 12:48:40 -0800 (Tue, 11 Feb 2020)
Log Message
Cherry-pick r255552. rdar://problem/59349213
ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
https://bugs.webkit.org/show_bug.cgi?id=207071
<rdar://problem/59076249>
Patch by Antoine Quint <grao...@apple.com> on 2020-02-02
Reviewed by Dean Jackson.
Source/WebCore:
We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>, because it triggers an ASSERT, and also we shouldn't
because we wouldn't know how to animate that CSS property.
* animation/AnimationTimeline.cpp:
(WebCore::compileTransitionPropertiesInStyle):
LayoutTests:
The crash is fixed, we can start running the test as expected again.
* platform/ipad/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256335 => 256336)
--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog 2020-02-11 20:48:36 UTC (rev 256335)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog 2020-02-11 20:48:40 UTC (rev 256336)
@@ -1,5 +1,44 @@
2020-02-11 Russell Epstein <repst...@apple.com>
+ Cherry-pick r255552. rdar://problem/59349213
+
+ ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+ https://bugs.webkit.org/show_bug.cgi?id=207071
+ <rdar://problem/59076249>
+
+ Patch by Antoine Quint <grao...@apple.com> on 2020-02-02
+ Reviewed by Dean Jackson.
+
+ Source/WebCore:
+
+ We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>, because it triggers an ASSERT, and also we shouldn't
+ because we wouldn't know how to animate that CSS property.
+
+ * animation/AnimationTimeline.cpp:
+ (WebCore::compileTransitionPropertiesInStyle):
+
+ LayoutTests:
+
+ The crash is fixed, we can start running the test as expected again.
+
+ * platform/ipad/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-02-02 Antoine Quint <grao...@apple.com>
+
+ ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+ https://bugs.webkit.org/show_bug.cgi?id=207071
+ <rdar://problem/59076249>
+
+ Reviewed by Dean Jackson.
+
+ The crash is fixed, we can start running the test as expected again.
+
+ * platform/ipad/TestExpectations:
+
+2020-02-11 Russell Epstein <repst...@apple.com>
+
Cherry-pick r255525. rdar://problem/59349213
[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
Modified: branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations (256335 => 256336)
--- branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations 2020-02-11 20:48:36 UTC (rev 256335)
+++ branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations 2020-02-11 20:48:40 UTC (rev 256336)
@@ -69,5 +69,3 @@
webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-004.html [ Pass ]
media/picture-in-picture [ Pass ]
-
-webkit.org/b/207071 [ Debug ] animations/keyframe-autoclose-brace.html [ Pass Crash ]
\ No newline at end of file
Modified: branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog (256335 => 256336)
--- branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog 2020-02-11 20:48:36 UTC (rev 256335)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog 2020-02-11 20:48:40 UTC (rev 256336)
@@ -1,3 +1,44 @@
+2020-02-11 Russell Epstein <repst...@apple.com>
+
+ Cherry-pick r255552. rdar://problem/59349213
+
+ ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+ https://bugs.webkit.org/show_bug.cgi?id=207071
+ <rdar://problem/59076249>
+
+ Patch by Antoine Quint <grao...@apple.com> on 2020-02-02
+ Reviewed by Dean Jackson.
+
+ Source/WebCore:
+
+ We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>, because it triggers an ASSERT, and also we shouldn't
+ because we wouldn't know how to animate that CSS property.
+
+ * animation/AnimationTimeline.cpp:
+ (WebCore::compileTransitionPropertiesInStyle):
+
+ LayoutTests:
+
+ The crash is fixed, we can start running the test as expected again.
+
+ * platform/ipad/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-02-02 Antoine Quint <grao...@apple.com>
+
+ ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+ https://bugs.webkit.org/show_bug.cgi?id=207071
+ <rdar://problem/59076249>
+
+ Reviewed by Dean Jackson.
+
+ We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>, because it triggers an ASSERT, and also we shouldn't
+ because we wouldn't know how to animate that CSS property.
+
+ * animation/AnimationTimeline.cpp:
+ (WebCore::compileTransitionPropertiesInStyle):
+
2020-02-07 Russell Epstein <repst...@apple.com>
Cherry-pick r256017. rdar://problem/59261560
Modified: branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.cpp (256335 => 256336)
--- branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.cpp 2020-02-11 20:48:36 UTC (rev 256335)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.cpp 2020-02-11 20:48:40 UTC (rev 256336)
@@ -415,7 +415,7 @@
auto shorthand = shorthandForProperty(property);
for (size_t j = 0; j < shorthand.length(); ++j)
transitionProperties.add(shorthand.properties()[j]);
- } else
+ } else if (property != CSSPropertyInvalid)
transitionProperties.add(property);
} else if (mode == Animation::AnimateAll) {
transitionPropertiesContainAll = true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
