Diff
Modified: trunk/Source/WTF/ChangeLog (256419 => 256420)
--- trunk/Source/WTF/ChangeLog 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/ChangeLog 2020-02-12 01:59:28 UTC (rev 256420)
@@ -1,3 +1,27 @@
+2020-02-11 Fujii Hironori <hironori.fu...@sony.com>
+
+ Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)
+ https://bugs.webkit.org/show_bug.cgi?id=207453
+
+ Reviewed by Ross Kirsling.
+
+ Export macros are prone to be misused because thier definitions
+ are identical for POSIX ports. They can be used interchangeably on
+ such ports.
+
+ WTF should use WTF_EXPORT_PRIVATE instead of WTF_EXPORT.
+
+ * wtf/HexNumber.h:
+ * wtf/Language.h:
+ * wtf/Logger.h:
+ * wtf/ProcessPrivilege.h:
+ * wtf/cocoa/CrashReporter.h:
+ * wtf/cocoa/Entitlements.h:
+ * wtf/text/LineEnding.h:
+ * wtf/text/TextBreakIterator.h:
+ * wtf/text/icu/UTextProviderLatin1.h:
+ Replaced WTF_EXPORT with WTF_EXPORT_PRIVATE.
+
2020-02-11 Eric Carlson <eric.carl...@apple.com>
Support in-band VTT captions when loading media in the GPU Process
Modified: trunk/Source/WTF/wtf/HexNumber.h (256419 => 256420)
--- trunk/Source/WTF/wtf/HexNumber.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/wtf/HexNumber.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -37,7 +37,7 @@
return mode == Lowercase ? lowercaseHexDigits : uppercaseHexDigits;
}
-WTF_EXPORT std::pair<LChar*, unsigned> appendHex(LChar* buffer, unsigned bufferSize, std::uintmax_t number, unsigned minimumDigits, HexConversionMode);
+WTF_EXPORT_PRIVATE std::pair<LChar*, unsigned> appendHex(LChar* buffer, unsigned bufferSize, std::uintmax_t number, unsigned minimumDigits, HexConversionMode);
template<size_t arraySize, typename NumberType>
inline std::pair<LChar*, unsigned> appendHex(std::array<LChar, arraySize>& buffer, NumberType number, unsigned minimumDigits, HexConversionMode mode)
Modified: trunk/Source/WTF/wtf/Language.h (256419 => 256420)
--- trunk/Source/WTF/wtf/Language.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/wtf/Language.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -35,20 +35,20 @@
namespace WTF {
-WTF_EXPORT String defaultLanguage(); // Thread-safe.
-WTF_EXPORT Vector<String> userPreferredLanguages(); // Thread-safe, returns BCP 47 language tags.
-WTF_EXPORT Vector<String> userPreferredLanguagesOverride();
-WTF_EXPORT void overrideUserPreferredLanguages(const Vector<String>&);
-WTF_EXPORT size_t indexOfBestMatchingLanguageInList(const String& language, const Vector<String>& languageList, bool& exactMatch);
-WTF_EXPORT Vector<String> platformUserPreferredLanguages();
+WTF_EXPORT_PRIVATE String defaultLanguage(); // Thread-safe.
+WTF_EXPORT_PRIVATE Vector<String> userPreferredLanguages(); // Thread-safe, returns BCP 47 language tags.
+WTF_EXPORT_PRIVATE Vector<String> userPreferredLanguagesOverride();
+WTF_EXPORT_PRIVATE void overrideUserPreferredLanguages(const Vector<String>&);
+WTF_EXPORT_PRIVATE size_t indexOfBestMatchingLanguageInList(const String& language, const Vector<String>& languageList, bool& exactMatch);
+WTF_EXPORT_PRIVATE Vector<String> platformUserPreferredLanguages();
// Called from platform specific code when the user's preferred language(s) change.
void languageDidChange();
// The observer function will be called when system language changes.
typedef void (*LanguageChangeObserverFunction)(void* context);
-WTF_EXPORT void addLanguageChangeObserver(void* context, LanguageChangeObserverFunction);
-WTF_EXPORT void removeLanguageChangeObserver(void* context);
-WTF_EXPORT String displayNameForLanguageLocale(const String&);
+WTF_EXPORT_PRIVATE void addLanguageChangeObserver(void* context, LanguageChangeObserverFunction);
+WTF_EXPORT_PRIVATE void removeLanguageChangeObserver(void* context);
+WTF_EXPORT_PRIVATE String displayNameForLanguageLocale(const String&);
#if PLATFORM(COCOA)
bool canMinimizeLanguages();
Modified: trunk/Source/WTF/wtf/Logger.h (256419 => 256420)
--- trunk/Source/WTF/wtf/Logger.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/wtf/Logger.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -210,7 +210,7 @@
{
}
- WTF_EXPORT String toString() const;
+ WTF_EXPORT_PRIVATE String toString() const;
const char* className { nullptr };
const char* methodName { nullptr };
@@ -281,7 +281,7 @@
static String toString(const Logger::LogSiteIdentifier& value) { return value.toString(); }
};
template<> struct LogArgument<const void*> {
- WTF_EXPORT static String toString(const void*);
+ WTF_EXPORT_PRIVATE static String toString(const void*);
};
} // namespace WTF
Modified: trunk/Source/WTF/wtf/ProcessPrivilege.h (256419 => 256420)
--- trunk/Source/WTF/wtf/ProcessPrivilege.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/wtf/ProcessPrivilege.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -35,11 +35,11 @@
CanCommunicateWithWindowServer = 1 << 2,
};
-WTF_EXPORT void setProcessPrivileges(OptionSet<ProcessPrivilege>);
-WTF_EXPORT void addProcessPrivilege(ProcessPrivilege);
-WTF_EXPORT void removeProcessPrivilege(ProcessPrivilege);
-WTF_EXPORT bool hasProcessPrivilege(ProcessPrivilege);
-WTF_EXPORT OptionSet<ProcessPrivilege> allPrivileges();
+WTF_EXPORT_PRIVATE void setProcessPrivileges(OptionSet<ProcessPrivilege>);
+WTF_EXPORT_PRIVATE void addProcessPrivilege(ProcessPrivilege);
+WTF_EXPORT_PRIVATE void removeProcessPrivilege(ProcessPrivilege);
+WTF_EXPORT_PRIVATE bool hasProcessPrivilege(ProcessPrivilege);
+WTF_EXPORT_PRIVATE OptionSet<ProcessPrivilege> allPrivileges();
} // namespace WTF
Modified: trunk/Source/WTF/wtf/cocoa/CrashReporter.h (256419 => 256420)
--- trunk/Source/WTF/wtf/cocoa/CrashReporter.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/wtf/cocoa/CrashReporter.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -27,6 +27,6 @@
namespace WTF {
-WTF_EXPORT void setCrashLogMessage(const char*);
+WTF_EXPORT_PRIVATE void setCrashLogMessage(const char*);
} // namespace WTF
Modified: trunk/Source/WTF/wtf/cocoa/Entitlements.h (256419 => 256420)
--- trunk/Source/WTF/wtf/cocoa/Entitlements.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/wtf/cocoa/Entitlements.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -31,9 +31,9 @@
namespace WTF {
-WTF_EXPORT bool hasEntitlement(audit_token_t, const char* entitlement);
-WTF_EXPORT bool hasEntitlement(xpc_connection_t, const char* entitlement);
-WTF_EXPORT bool processHasEntitlement(const char* entitlement);
+WTF_EXPORT_PRIVATE bool hasEntitlement(audit_token_t, const char* entitlement);
+WTF_EXPORT_PRIVATE bool hasEntitlement(xpc_connection_t, const char* entitlement);
+WTF_EXPORT_PRIVATE bool processHasEntitlement(const char* entitlement);
} // namespace WTF
Modified: trunk/Source/WTF/wtf/text/LineEnding.h (256419 => 256420)
--- trunk/Source/WTF/wtf/text/LineEnding.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/wtf/text/LineEnding.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -36,11 +36,11 @@
namespace WTF {
// Normalize all line-endings in the given string.
-WTF_EXPORT Vector<uint8_t> normalizeLineEndingsToLF(Vector<uint8_t>&&);
-WTF_EXPORT Vector<uint8_t> normalizeLineEndingsToCRLF(Vector<uint8_t>&&);
+WTF_EXPORT_PRIVATE Vector<uint8_t> normalizeLineEndingsToLF(Vector<uint8_t>&&);
+WTF_EXPORT_PRIVATE Vector<uint8_t> normalizeLineEndingsToCRLF(Vector<uint8_t>&&);
// Normalize all line-endings to CRLF on Windows, to LF on all other platforms.
-WTF_EXPORT Vector<uint8_t> normalizeLineEndingsToNative(Vector<uint8_t>&&);
+WTF_EXPORT_PRIVATE Vector<uint8_t> normalizeLineEndingsToNative(Vector<uint8_t>&&);
} // namespace WTF
Modified: trunk/Source/WTF/wtf/text/TextBreakIterator.h (256419 => 256420)
--- trunk/Source/WTF/wtf/text/TextBreakIterator.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/wtf/text/TextBreakIterator.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -82,7 +82,7 @@
friend class TextBreakIteratorCache;
// Use CachedTextBreakIterator instead of constructing one of these directly.
- WTF_EXPORT TextBreakIterator(StringView, Mode, const AtomString& locale);
+ WTF_EXPORT_PRIVATE TextBreakIterator(StringView, Mode, const AtomString& locale);
void setText(StringView string)
{
Modified: trunk/Source/WTF/wtf/text/icu/UTextProviderLatin1.h (256419 => 256420)
--- trunk/Source/WTF/wtf/text/icu/UTextProviderLatin1.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WTF/wtf/text/icu/UTextProviderLatin1.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -38,7 +38,7 @@
UChar buffer[UTextWithBufferInlineCapacity];
};
-WTF_EXPORT UText* openLatin1UTextProvider(UTextWithBuffer* utWithBuffer, const LChar* string, unsigned length, UErrorCode* status);
+WTF_EXPORT_PRIVATE UText* openLatin1UTextProvider(UTextWithBuffer* utWithBuffer, const LChar* string, unsigned length, UErrorCode* status);
UText* openLatin1ContextAwareUTextProvider(UTextWithBuffer* utWithBuffer, const LChar* string, unsigned length, const UChar* priorContext, int priorContextLength, UErrorCode* status);
} // namespace WTF
Modified: trunk/Source/WebCore/ChangeLog (256419 => 256420)
--- trunk/Source/WebCore/ChangeLog 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebCore/ChangeLog 2020-02-12 01:59:28 UTC (rev 256420)
@@ -1,3 +1,16 @@
+2020-02-11 Fujii Hironori <hironori.fu...@sony.com>
+
+ Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)
+ https://bugs.webkit.org/show_bug.cgi?id=207453
+
+ Reviewed by Ross Kirsling.
+
+ No new tests because there is no behavior change.
+
+ * rendering/RenderTheme.h:
+ * testing/MockContentFilterSettings.h:
+ * testing/MockGamepadProvider.h:
+
2020-02-11 Brent Fulgham <bfulg...@apple.com>
REGRESSION (r236025): Correct flaky WebGL2 test failures
Modified: trunk/Source/WebCore/rendering/RenderTheme.h (256419 => 256420)
--- trunk/Source/WebCore/rendering/RenderTheme.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebCore/rendering/RenderTheme.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -160,7 +160,7 @@
virtual Color disabledTextColor(const Color& textColor, const Color& backgroundColor) const;
- WTF_EXPORT Color focusRingColor(OptionSet<StyleColor::Options>) const;
+ WEBCORE_EXPORT Color focusRingColor(OptionSet<StyleColor::Options>) const;
virtual Color platformFocusRingColor(OptionSet<StyleColor::Options>) const { return Color(0, 0, 0); }
static void setCustomFocusRingColor(const Color&);
static float platformFocusRingWidth() { return 3; }
Modified: trunk/Source/WebCore/testing/MockContentFilterSettings.h (256419 => 256420)
--- trunk/Source/WebCore/testing/MockContentFilterSettings.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebCore/testing/MockContentFilterSettings.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -46,7 +46,7 @@
Block
};
- WTF_EXPORT_PRIVATE static MockContentFilterSettings& singleton();
+ WEBCORE_TESTSUPPORT_EXPORT static MockContentFilterSettings& singleton();
static void reset();
static const char* unblockURLHost() { return "mock-unblock"; }
@@ -55,7 +55,7 @@
void deref() { }
bool enabled() const { return m_enabled; }
- WTF_EXPORT_PRIVATE void setEnabled(bool);
+ WEBCORE_TESTSUPPORT_EXPORT void setEnabled(bool);
const String& blockedString() const { return m_blockedString; }
void setBlockedString(const String& blockedString) { m_blockedString = blockedString; }
Modified: trunk/Source/WebCore/testing/MockGamepadProvider.h (256419 => 256420)
--- trunk/Source/WebCore/testing/MockGamepadProvider.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebCore/testing/MockGamepadProvider.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -37,10 +37,10 @@
WTF_MAKE_NONCOPYABLE(MockGamepadProvider);
friend class NeverDestroyed<MockGamepadProvider>;
public:
- WEBCORE_EXPORT static MockGamepadProvider& singleton();
+ WEBCORE_TESTSUPPORT_EXPORT static MockGamepadProvider& singleton();
- WEBCORE_EXPORT void startMonitoringGamepads(GamepadProviderClient&) final;
- WEBCORE_EXPORT void stopMonitoringGamepads(GamepadProviderClient&) final;
+ WEBCORE_TESTSUPPORT_EXPORT void startMonitoringGamepads(GamepadProviderClient&) final;
+ WEBCORE_TESTSUPPORT_EXPORT void stopMonitoringGamepads(GamepadProviderClient&) final;
const Vector<PlatformGamepad*>& platformGamepads() final { return m_connectedGamepadVector; }
bool isMockGamepadProvider() const final { return true; }
Modified: trunk/Source/WebKit/ChangeLog (256419 => 256420)
--- trunk/Source/WebKit/ChangeLog 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebKit/ChangeLog 2020-02-12 01:59:28 UTC (rev 256420)
@@ -1,3 +1,13 @@
+2020-02-11 Fujii Hironori <hironori.fu...@sony.com>
+
+ Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)
+ https://bugs.webkit.org/show_bug.cgi?id=207453
+
+ Reviewed by Ross Kirsling.
+
+ * UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h:
+ * UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.h:
+
2020-02-11 Wenson Hsieh <wenson_hs...@apple.com>
WebPage::getFocusedElementInformation should be robust when the focused element changes during layout
Modified: trunk/Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h (256419 => 256420)
--- trunk/Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -35,7 +35,7 @@
class ScrollingTreeFrameScrollingNodeRemoteMac : public WebCore::ScrollingTreeFrameScrollingNodeMac {
public:
- WEBCORE_EXPORT static Ref<ScrollingTreeFrameScrollingNodeRemoteMac> create(WebCore::ScrollingTree&, WebCore::ScrollingNodeType, WebCore::ScrollingNodeID);
+ static Ref<ScrollingTreeFrameScrollingNodeRemoteMac> create(WebCore::ScrollingTree&, WebCore::ScrollingNodeType, WebCore::ScrollingNodeID);
virtual ~ScrollingTreeFrameScrollingNodeRemoteMac();
bool handleMouseEvent(const WebCore::PlatformMouseEvent&);
Modified: trunk/Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.h (256419 => 256420)
--- trunk/Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -35,7 +35,7 @@
class ScrollingTreeOverflowScrollingNodeRemoteMac : public WebCore::ScrollingTreeOverflowScrollingNodeMac {
public:
- WEBCORE_EXPORT static Ref<ScrollingTreeOverflowScrollingNodeRemoteMac> create(WebCore::ScrollingTree&, WebCore::ScrollingNodeID);
+ static Ref<ScrollingTreeOverflowScrollingNodeRemoteMac> create(WebCore::ScrollingTree&, WebCore::ScrollingNodeID);
virtual ~ScrollingTreeOverflowScrollingNodeRemoteMac();
bool handleMouseEvent(const WebCore::PlatformMouseEvent&);
Modified: trunk/Source/WebKitLegacy/ChangeLog (256419 => 256420)
--- trunk/Source/WebKitLegacy/ChangeLog 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebKitLegacy/ChangeLog 2020-02-12 01:59:28 UTC (rev 256420)
@@ -1,5 +1,14 @@
2020-02-11 Fujii Hironori <hironori.fu...@sony.com>
+ Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)
+ https://bugs.webkit.org/show_bug.cgi?id=207453
+
+ Reviewed by Ross Kirsling.
+
+ * Storage/InProcessIDBServer.h:
+
+2020-02-11 Fujii Hironori <hironori.fu...@sony.com>
+
[Win][CMake][WK1] WebKitLegacyGUID doesn't get recompiled by updating IDL files
https://bugs.webkit.org/show_bug.cgi?id=207456
Modified: trunk/Source/WebKitLegacy/Storage/InProcessIDBServer.h (256419 => 256420)
--- trunk/Source/WebKitLegacy/Storage/InProcessIDBServer.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebKitLegacy/Storage/InProcessIDBServer.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -55,10 +55,10 @@
class InProcessIDBServer final : public WebCore::IDBClient::IDBConnectionToServerDelegate, public WebCore::IDBServer::IDBConnectionToClientDelegate, public ThreadSafeRefCounted<InProcessIDBServer> {
public:
- WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID);
- WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID, const String& databaseDirectoryPath);
+ static Ref<InProcessIDBServer> create(PAL::SessionID);
+ static Ref<InProcessIDBServer> create(PAL::SessionID, const String& databaseDirectoryPath);
- WEBCORE_EXPORT virtual ~InProcessIDBServer();
+ virtual ~InProcessIDBServer();
WebCore::IDBClient::IDBConnectionToServer& connectionToServer() const;
WebCore::IDBServer::IDBConnectionToClient& connectionToClient() const;
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (256419 => 256420)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2020-02-12 01:59:28 UTC (rev 256420)
@@ -1,3 +1,12 @@
+2020-02-11 Fujii Hironori <hironori.fu...@sony.com>
+
+ Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)
+ https://bugs.webkit.org/show_bug.cgi?id=207453
+
+ Reviewed by Ross Kirsling.
+
+ * Plugins/PluginMainThreadScheduler.h:
+
2020-02-07 Chris Dumez <cdu...@apple.com>
[Hardening] Validate Geolocation access permission on UIProcess side
Modified: trunk/Source/WebKitLegacy/win/Plugins/PluginMainThreadScheduler.h (256419 => 256420)
--- trunk/Source/WebKitLegacy/win/Plugins/PluginMainThreadScheduler.h 2020-02-12 01:50:19 UTC (rev 256419)
+++ trunk/Source/WebKitLegacy/win/Plugins/PluginMainThreadScheduler.h 2020-02-12 01:59:28 UTC (rev 256420)
@@ -41,12 +41,12 @@
public:
typedef void MainThreadFunction(void*);
- WEBCORE_EXPORT static PluginMainThreadScheduler& scheduler();
+ static PluginMainThreadScheduler& scheduler();
- WEBCORE_EXPORT void scheduleCall(NPP, MainThreadFunction*, void* userData);
+ void scheduleCall(NPP, MainThreadFunction*, void* userData);
- WEBCORE_EXPORT void registerPlugin(NPP);
- WEBCORE_EXPORT void unregisterPlugin(NPP);
+ void registerPlugin(NPP);
+ void unregisterPlugin(NPP);
private:
friend NeverDestroyed<PluginMainThreadScheduler>;
