Diff
Modified: trunk/LayoutTests/ChangeLog (256462 => 256463)
--- trunk/LayoutTests/ChangeLog 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/LayoutTests/ChangeLog 2020-02-12 19:31:11 UTC (rev 256463)
@@ -1,3 +1,20 @@
+2020-02-12 Said Abou-Hallawa <s...@apple.com>
+
+ REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+
+ Reviewed by Simon Fraser.
+
+ Remove the setting 'RenderingUpdateThrottling'.
+
+ * fast/animation/css-animation-throttling-lowPowerMode.html:
+ * fast/animation/request-animation-frame-throttle-subframe.html:
+ * fast/animation/request-animation-frame-throttling-detached-iframe.html:
+ * fast/animation/request-animation-frame-throttling-lowPowerMode.html:
+ * fast/animation/request-animation-frame-throttling-outside-viewport.html:
+ * http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html:
+ * platform/mac-wk2/TestExpectations:
+
2020-02-12 Jacob Uphoff <jacob_uph...@apple.com>
[ iOS ] imported/w3c/IndexedDB-private-browsing/idbcursor_delete_objectstore3.html is flaky timing out
Modified: trunk/LayoutTests/fast/animation/css-animation-throttling-lowPowerMode.html (256462 => 256463)
--- trunk/LayoutTests/fast/animation/css-animation-throttling-lowPowerMode.html 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/LayoutTests/fast/animation/css-animation-throttling-lowPowerMode.html 2020-02-12 19:31:11 UTC (rev 256463)
@@ -25,9 +25,6 @@
description("Tests that CSS animations are throttled in low power mode.");
jsTestIsAsync = true;
-if (window.internals)
- internals.settings.setRenderingUpdateThrottlingEnabled(true);
-
const element = document.getElementById("testElement");
element._onanimationstart_ = function() {
element._onanimationstart_ = null;
Modified: trunk/LayoutTests/fast/animation/request-animation-frame-throttle-subframe.html (256462 => 256463)
--- trunk/LayoutTests/fast/animation/request-animation-frame-throttle-subframe.html 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-throttle-subframe.html 2020-02-12 19:31:11 UTC (rev 256463)
@@ -6,9 +6,6 @@
description("Tests that requestAnimationFrame is throttled in subframes that are outside the viewport");
window.jsTestIsAsync = true;
-if (window.internals)
- internals.settings.setRenderingUpdateThrottlingEnabled(true);
-
function checkSubframesThrottled()
{
shouldBeTrue("testFrame.contentWindow.internals.isRequestAnimationFrameThrottled()");
Modified: trunk/LayoutTests/fast/animation/request-animation-frame-throttling-detached-iframe.html (256462 => 256463)
--- trunk/LayoutTests/fast/animation/request-animation-frame-throttling-detached-iframe.html 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-throttling-detached-iframe.html 2020-02-12 19:31:11 UTC (rev 256463)
@@ -6,9 +6,6 @@
description("Test that requestAnimationFrame gets the right throttling in an iframe when inserted into a document.");
jsTestIsAsync = true;
-if (window.internals)
- internals.settings.setRenderingUpdateThrottlingEnabled(true);
-
let i = 0;
function doWork()
{
Modified: trunk/LayoutTests/fast/animation/request-animation-frame-throttling-lowPowerMode.html (256462 => 256463)
--- trunk/LayoutTests/fast/animation/request-animation-frame-throttling-lowPowerMode.html 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-throttling-lowPowerMode.html 2020-02-12 19:31:11 UTC (rev 256463)
@@ -6,10 +6,8 @@
description("Test that requestAnimationFrame gets throttled in low power mode.");
window.jsTestIsAsync = true;
- if (window.internals) {
- internals.settings.setRenderingUpdateThrottlingEnabled(true);
+ if (window.internals)
internals.setLowPowerModeEnabled(true);
- }
var start = null;
var farmesPerSecond = 0;
Modified: trunk/LayoutTests/fast/animation/request-animation-frame-throttling-outside-viewport.html (256462 => 256463)
--- trunk/LayoutTests/fast/animation/request-animation-frame-throttling-outside-viewport.html 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-throttling-outside-viewport.html 2020-02-12 19:31:11 UTC (rev 256463)
@@ -7,9 +7,6 @@
description("Test that requestAnimationFrame gets the right throttling in an iframe when when it's outside the viewport.");
jsTestIsAsync = true;
- if (window.internals)
- internals.settings.setRenderingUpdateThrottlingEnabled(true);
-
var framesPerSecond = 0;
var iframeFramesPerSecond = 0;
Modified: trunk/LayoutTests/http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html (256462 => 256463)
--- trunk/LayoutTests/http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/LayoutTests/http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html 2020-02-12 19:31:11 UTC (rev 256463)
@@ -14,9 +14,6 @@
description("Tests that requestAnimationFrame is throttled in subframes that are cross-origin, and not in same-origin frames");
window.jsTestIsAsync = true;
- if (window.internals)
- internals.settings.setRenderingUpdateThrottlingEnabled(true);
-
var crossOriginFrame;
var sameOriginFrame
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256462 => 256463)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-12 19:31:11 UTC (rev 256463)
@@ -940,8 +940,6 @@
webkit.org/b/206961 [ Mojave ] media/media-fragments/TC0035.html [ Pass Failure ]
-webkit.org/b/206839 http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html [ Pass Failure ]
-
webkit.org/b/207003 tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html [ Pass Failure ]
webkit.org/b/207060 imported/w3c/web-platform-tests/html/webappapis/timers/type-long-setinterval.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (256462 => 256463)
--- trunk/Source/WebCore/ChangeLog 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebCore/ChangeLog 2020-02-12 19:31:11 UTC (rev 256463)
@@ -1,3 +1,25 @@
+2020-02-12 Said Abou-Hallawa <s...@apple.com>
+
+ REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+
+ Reviewed by Simon Fraser.
+
+ Remove the setting 'RenderingUpdateThrottling'. We will disable the
+ RenderingUpdateThrottling till the first layout happens. Then it will be
+ enabled for the rest of the page's life. This ensures VisuallyIdle won't
+ throttle the RenderingUpdate steps before the first paint.
+
+ * page/Page.cpp:
+ (WebCore::Page::renderingUpdateThrottlingEnabled const):
+ (WebCore::Page::addLayoutMilestones):
+ (WebCore::Page::renderingUpdateThrottlingEnabledChanged): Deleted.
+ * page/Page.h:
+ * page/Settings.yaml:
+ * page/SettingsBase.cpp:
+ (WebCore::SettingsBase::renderingUpdateThrottlingEnabledChanged): Deleted.
+ * page/SettingsBase.h:
+
2020-02-12 Youenn Fablet <you...@apple.com>
Refactor DocumentLoader::commitData to use a Document& internally
Modified: trunk/Source/WebCore/page/Page.cpp (256462 => 256463)
--- trunk/Source/WebCore/page/Page.cpp 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebCore/page/Page.cpp 2020-02-12 19:31:11 UTC (rev 256463)
@@ -1384,14 +1384,9 @@
bool Page::renderingUpdateThrottlingEnabled() const
{
- return m_settings->renderingUpdateThrottlingEnabled();
+ return !requestedLayoutMilestones().isEmpty();
}
-void Page::renderingUpdateThrottlingEnabledChanged()
-{
- renderingUpdateScheduler().adjustRenderingUpdateFrequency();
-}
-
bool Page::isRenderingUpdateThrottled() const
{
return renderingUpdateThrottlingEnabled() && !m_throttlingReasons.isEmpty();
@@ -2144,8 +2139,11 @@
void Page::addLayoutMilestones(OptionSet<LayoutMilestone> milestones)
{
+ bool oldRenderingUpdateThrottlingEnabled = renderingUpdateThrottlingEnabled();
// In the future, we may want a function that replaces m_layoutMilestones instead of just adding to it.
m_requestedLayoutMilestones.add(milestones);
+ if (!oldRenderingUpdateThrottlingEnabled && renderingUpdateThrottlingEnabled())
+ renderingUpdateScheduler().adjustRenderingUpdateFrequency();
}
void Page::removeLayoutMilestones(OptionSet<LayoutMilestone> milestones)
Modified: trunk/Source/WebCore/page/Page.h (256462 => 256463)
--- trunk/Source/WebCore/page/Page.h 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebCore/page/Page.h 2020-02-12 19:31:11 UTC (rev 256463)
@@ -702,7 +702,6 @@
WEBCORE_EXPORT void setLowPowerModeEnabledOverrideForTesting(Optional<bool>);
bool renderingUpdateThrottlingEnabled() const;
- void renderingUpdateThrottlingEnabledChanged();
bool isRenderingUpdateThrottled() const;
Seconds preferredRenderingUpdateInterval() const;
bool canUpdateThrottlingReason(ThrottlingReason reason) const { return !m_throttlingReasonsOverridenForTesting.contains(reason); }
Modified: trunk/Source/WebCore/page/Settings.yaml (256462 => 256463)
--- trunk/Source/WebCore/page/Settings.yaml 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebCore/page/Settings.yaml 2020-02-12 19:31:11 UTC (rev 256463)
@@ -769,10 +769,6 @@
initial: false
onChange: hiddenPageCSSAnimationSuspensionEnabledChanged
-renderingUpdateThrottlingEnabled:
- initial: true
- onChange: renderingUpdateThrottlingEnabledChanged
-
storageBlockingPolicy:
type: SecurityOrigin::StorageBlockingPolicy
initial: SecurityOrigin::AllowAllStorage
Modified: trunk/Source/WebCore/page/SettingsBase.cpp (256462 => 256463)
--- trunk/Source/WebCore/page/SettingsBase.cpp 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebCore/page/SettingsBase.cpp 2020-02-12 19:31:11 UTC (rev 256463)
@@ -407,12 +407,6 @@
m_page->hiddenPageCSSAnimationSuspensionStateChanged();
}
-void SettingsBase::renderingUpdateThrottlingEnabledChanged()
-{
- if (m_page)
- m_page->renderingUpdateThrottlingEnabledChanged();
-}
-
void SettingsBase::resourceUsageOverlayVisibleChanged()
{
#if ENABLE(RESOURCE_USAGE)
Modified: trunk/Source/WebCore/page/SettingsBase.h (256462 => 256463)
--- trunk/Source/WebCore/page/SettingsBase.h 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebCore/page/SettingsBase.h 2020-02-12 19:31:11 UTC (rev 256463)
@@ -194,7 +194,6 @@
void scrollingPerformanceLoggingEnabledChanged();
void hiddenPageDOMTimerThrottlingStateChanged();
void hiddenPageCSSAnimationSuspensionEnabledChanged();
- void renderingUpdateThrottlingEnabledChanged();
void resourceUsageOverlayVisibleChanged();
void iceCandidateFilteringEnabledChanged();
#if ENABLE(TEXT_AUTOSIZING)
Modified: trunk/Source/WebKit/ChangeLog (256462 => 256463)
--- trunk/Source/WebKit/ChangeLog 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKit/ChangeLog 2020-02-12 19:31:11 UTC (rev 256463)
@@ -1,3 +1,18 @@
+2020-02-12 Said Abou-Hallawa <s...@apple.com>
+
+ REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+
+ Reviewed by Simon Fraser.
+
+ Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
+
+ * Shared/WebPreferences.yaml:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetRenderingUpdateThrottlingEnabled): Deleted.
+ (WKPreferencesGetRenderingUpdateThrottlingEnabled): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+
2020-02-12 Simon Fraser <simon.fra...@apple.com>
Pages that trigger a redirect will sometimes be left blank
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (256462 => 256463)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-02-12 19:31:11 UTC (rev 256463)
@@ -496,10 +496,6 @@
type: bool
defaultValue: DEFAULT_HIDDEN_PAGE_CSS_ANIMATION_SUSPENSION_ENABLED
-RenderingUpdateThrottlingEnabled:
- type: bool
- defaultValue: true
-
LowPowerVideoAudioBufferSizeEnabled:
type: bool
defaultValue: true
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (256462 => 256463)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2020-02-12 19:31:11 UTC (rev 256463)
@@ -1319,16 +1319,6 @@
return toImpl(preferencesRef)->hiddenPageCSSAnimationSuspensionEnabled();
}
-void WKPreferencesSetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferencesRef, bool enabled)
-{
- toImpl(preferencesRef)->setRenderingUpdateThrottlingEnabled(enabled);
-}
-
-bool WKPreferencesGetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferencesRef)
-{
- return toImpl(preferencesRef)->renderingUpdateThrottlingEnabled();
-}
-
void WKPreferencesSetIncrementalRenderingSuppressionTimeout(WKPreferencesRef preferencesRef, double timeout)
{
toImpl(preferencesRef)->setIncrementalRenderingSuppressionTimeout(timeout);
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h (256462 => 256463)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h 2020-02-12 19:31:11 UTC (rev 256463)
@@ -306,10 +306,6 @@
WK_EXPORT void WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled(WKPreferencesRef preferences, bool enabled);
WK_EXPORT bool WKPreferencesGetHiddenPageCSSAnimationSuspensionEnabled(WKPreferencesRef preferences);
-// Defaults to true.
-WK_EXPORT void WKPreferencesSetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferences, bool enabled);
-WK_EXPORT bool WKPreferencesGetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferences);
-
// Defaults to false
WK_EXPORT void WKPreferencesSetSnapshotAllPlugIns(WKPreferencesRef preferencesRef, bool enabled);
WK_EXPORT bool WKPreferencesGetSnapshotAllPlugIns(WKPreferencesRef preferencesRef);
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (256462 => 256463)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-02-12 19:31:11 UTC (rev 256463)
@@ -1,3 +1,21 @@
+2020-02-12 Said Abou-Hallawa <s...@apple.com>
+
+ REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+
+ Reviewed by Simon Fraser.
+
+ Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences renderingUpdateThrottlingEnabled]): Deleted.
+ (-[WebPreferences setRenderingUpdateThrottlingEnabled:]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2020-02-10 Daniel Bates <daba...@apple.com>
Disallow setting base URL to a data or _javascript_ URL
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (256462 => 256463)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-02-12 19:31:11 UTC (rev 256463)
@@ -166,7 +166,6 @@
#define WebKitPlugInSnapshottingEnabledPreferenceKey @"WebKitPlugInSnapshottingEnabled"
#define WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey @"WebKitHiddenPageDOMTimerThrottlingEnabled"
#define WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey @"WebKitHiddenPageCSSAnimationSuspensionEnabled"
-#define WebKitRenderingUpdateThrottlingEnabledPreferenceKey @"WebKitRenderingUpdateThrottlingEnabled"
#define WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey @"WebKitLowPowerVideoAudioBufferSizeEnabled"
#define WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey @"WebKitUseLegacyTextAlignPositionedElementBehavior"
#define WebKitMediaSourceEnabledPreferenceKey @"WebKitMediaSourceEnabled"
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (256462 => 256463)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-02-12 19:31:11 UTC (rev 256463)
@@ -594,7 +594,6 @@
[NSNumber numberWithLongLong:ApplicationCacheStorage::noQuota()], WebKitApplicationCacheDefaultOriginQuota,
@NO, WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey,
@YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey,
- @YES, WebKitRenderingUpdateThrottlingEnabledPreferenceKey,
@NO, WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey,
@NO, WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey,
@@ -2797,16 +2796,6 @@
[self _setBoolValue:enabled forKey:WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey];
}
-- (BOOL)renderingUpdateThrottlingEnabled
-{
- return [self _boolValueForKey:WebKitRenderingUpdateThrottlingEnabledPreferenceKey];
-}
-
-- (void)setRenderingUpdateThrottlingEnabled:(BOOL)enabled
-{
- [self _setBoolValue:enabled forKey:WebKitRenderingUpdateThrottlingEnabledPreferenceKey];
-}
-
- (BOOL)lowPowerVideoAudioBufferSizeEnabled
{
return [self _boolValueForKey:WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey];
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (256462 => 256463)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-02-12 19:31:11 UTC (rev 256463)
@@ -492,9 +492,6 @@
- (BOOL)hiddenPageCSSAnimationSuspensionEnabled;
- (void)setHiddenPageCSSAnimationSuspensionEnabled:(BOOL)flag;
-- (BOOL)renderingUpdateThrottlingEnabled;
-- (void)setRenderingUpdateThrottlingEnabled:(BOOL)flag;
-
- (BOOL)lowPowerVideoAudioBufferSizeEnabled;
- (void)setLowPowerVideoAudioBufferSizeEnabled:(BOOL)enabled;
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (256462 => 256463)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-02-12 19:31:11 UTC (rev 256463)
@@ -3129,7 +3129,6 @@
settings.setHiddenPageDOMTimerThrottlingEnabled([preferences hiddenPageDOMTimerThrottlingEnabled]);
settings.setHiddenPageCSSAnimationSuspensionEnabled([preferences hiddenPageCSSAnimationSuspensionEnabled]);
- settings.setRenderingUpdateThrottlingEnabled([preferences renderingUpdateThrottlingEnabled]);
WebCore::DeprecatedGlobalSettings::setResourceLoadStatisticsEnabled([preferences resourceLoadStatisticsEnabled]);
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (256462 => 256463)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2020-02-12 19:31:11 UTC (rev 256463)
@@ -1,3 +1,22 @@
+2020-02-12 Said Abou-Hallawa <s...@apple.com>
+
+ REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+
+ Reviewed by Simon Fraser.
+
+ Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
+
+ * Interfaces/IWebPreferencesPrivate.idl:
+ * WebPreferenceKeysPrivate.h:
+ * WebPreferences.cpp:
+ (WebPreferences::initializeDefaultSettings):
+ (WebPreferences::renderingUpdateThrottlingEnabled): Deleted.
+ (WebPreferences::setRenderingUpdateThrottlingEnabled): Deleted.
+ * WebPreferences.h:
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
2020-02-11 Fujii Hironori <hironori.fu...@sony.com>
Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)
Modified: trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl (256462 => 256463)
--- trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl 2020-02-12 19:31:11 UTC (rev 256463)
@@ -258,8 +258,6 @@
HRESULT setAspectRatioOfImgFromWidthAndHeightEnabled([in] BOOL enabled);
HRESULT setWebSQLEnabled([in] BOOL enabled);
HRESULT webSQLEnabled([out, retval] BOOL* enabled);
- HRESULT setRenderingUpdateThrottlingEnabled([in] BOOL enabled);
- HRESULT renderingUpdateThrottlingEnabled([out, retval] BOOL* enabled);
}
[uuid(04D4AAE1-5D01-4CCD-B46E-C022F10A6826)]
Modified: trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h (256462 => 256463)
--- trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h 2020-02-12 19:31:11 UTC (rev 256463)
@@ -227,7 +227,3 @@
#define WebKitAspectRatioOfImgFromWidthAndHeightEnabledPreferenceKey "WebKitAspectRatioOfImgFromWidthAndHeightEnabled"
#define WebKitWebSQLEnabledPreferenceKey "WebKitWebSQLEnabled"
-
-#define WebKitRenderingUpdateThrottlingEnabledPreferenceKey "WebKitRenderingUpdateThrottlingEnabled"
-
-#define WebKitRenderingUpdateThrottlingEnabledPreferenceKey "WebKitRenderingUpdateThrottlingEnabled"
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (256462 => 256463)
--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2020-02-12 19:31:11 UTC (rev 256463)
@@ -354,8 +354,6 @@
CFDictionaryAddValue(defaults, CFSTR(WebKitWebSQLEnabledPreferenceKey), kCFBooleanFalse);
- CFDictionaryAddValue(defaults, CFSTR(WebKitRenderingUpdateThrottlingEnabledPreferenceKey), kCFBooleanTrue);
-
defaultSettings = defaults;
#endif
}
@@ -2472,20 +2470,6 @@
return S_OK;
}
-HRESULT WebPreferences::renderingUpdateThrottlingEnabled(_Out_ BOOL* enabled)
-{
- if (!enabled)
- return E_POINTER;
- *enabled = boolValueForKey(WebKitRenderingUpdateThrottlingEnabledPreferenceKey);
- return S_OK;
-}
-
-HRESULT WebPreferences::setRenderingUpdateThrottlingEnabled(BOOL enabled)
-{
- setBoolValue(WebKitRenderingUpdateThrottlingEnabledPreferenceKey, enabled);
- return S_OK;
-}
-
HRESULT WebPreferences::allowTopNavigationToDataURLs(_Out_ BOOL* allowAccess)
{
if (!allowAccess)
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.h (256462 => 256463)
--- trunk/Source/WebKitLegacy/win/WebPreferences.h 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.h 2020-02-12 19:31:11 UTC (rev 256463)
@@ -303,8 +303,6 @@
virtual HRESULT STDMETHODCALLTYPE setAspectRatioOfImgFromWidthAndHeightEnabled(BOOL);
virtual HRESULT STDMETHODCALLTYPE webSQLEnabled(_Out_ BOOL*);
virtual HRESULT STDMETHODCALLTYPE setWebSQLEnabled(BOOL);
- virtual HRESULT STDMETHODCALLTYPE renderingUpdateThrottlingEnabled(_Out_ BOOL*);
- virtual HRESULT STDMETHODCALLTYPE setRenderingUpdateThrottlingEnabled(BOOL);
// IWebPreferencesPrivate8
virtual HRESULT STDMETHODCALLTYPE allowTopNavigationToDataURLs(_Out_ BOOL*);
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (256462 => 256463)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2020-02-12 19:31:11 UTC (rev 256463)
@@ -5615,11 +5615,6 @@
return hr;
settings.setRequestAnimationFrameEnabled(enabled);
- hr = prefsPrivate->renderingUpdateThrottlingEnabled(&enabled);
- if (FAILED(hr))
- return hr;
- settings.setRenderingUpdateThrottlingEnabled(enabled);
-
hr = prefsPrivate->mockScrollbarsEnabled(&enabled);
if (FAILED(hr))
return hr;
Modified: trunk/Tools/ChangeLog (256462 => 256463)
--- trunk/Tools/ChangeLog 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Tools/ChangeLog 2020-02-12 19:31:11 UTC (rev 256463)
@@ -1,3 +1,19 @@
+2020-02-12 Said Abou-Hallawa <s...@apple.com>
+
+ REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+
+ Reviewed by Simon Fraser.
+
+ Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (enableExperimentalFeatures):
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+
2020-02-12 Jonathan Bedard <jbed...@apple.com>
results.webkit.org: Cache archive content
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (256462 => 256463)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2020-02-12 19:31:11 UTC (rev 256463)
@@ -995,7 +995,6 @@
[preferences setHiddenPageDOMTimerThrottlingEnabled:NO];
[preferences setHiddenPageCSSAnimationSuspensionEnabled:NO];
- [preferences setRenderingUpdateThrottlingEnabled:NO];
[preferences setRemotePlaybackEnabled:YES];
[preferences setMediaDevicesEnabled:YES];
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (256462 => 256463)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2020-02-12 19:31:11 UTC (rev 256463)
@@ -801,7 +801,6 @@
prefsPrivate->setWebAnimationsMutableTimelinesEnabled(TRUE);
prefsPrivate->setServerTimingEnabled(TRUE);
prefsPrivate->setAspectRatioOfImgFromWidthAndHeightEnabled(TRUE);
- prefsPrivate->setRenderingUpdateThrottlingEnabled(FALSE);
// FIXME: WebGL2
// FIXME: WebRTC
}
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (256462 => 256463)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-02-12 19:27:04 UTC (rev 256462)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-02-12 19:31:11 UTC (rev 256463)
@@ -908,7 +908,6 @@
WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled(preferences, false);
WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled(preferences, false);
- WKPreferencesSetRenderingUpdateThrottlingEnabled(preferences, false);
WKPreferencesSetAcceleratedDrawingEnabled(preferences, m_shouldUseAcceleratedDrawing || options.useAcceleratedDrawing);
// FIXME: We should be testing the default.
