Title: [258958] trunk/Source/WebKit
- Revision
- 258958
- Author
- katherine_che...@apple.com
- Date
- 2020-03-24 16:51:04 -0700 (Tue, 24 Mar 2020)
Log Message
Ignore in-app browser privacy checks for apps with com.apple.private.applemediaservices entitlement
https://bugs.webkit.org/show_bug.cgi?id=209509
<rdar://problem/60750956>
Reviewed by Brent Fulgham.
* UIProcess/WebPageProxy.cpp:
(WebKit::m_ignoresAppBoundDomains):
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):
* UIProcess/WebPageProxy.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258957 => 258958)
--- trunk/Source/WebKit/ChangeLog 2020-03-24 23:33:58 UTC (rev 258957)
+++ trunk/Source/WebKit/ChangeLog 2020-03-24 23:51:04 UTC (rev 258958)
@@ -1,3 +1,16 @@
+2020-03-24 Kate Cheney <katherine_che...@apple.com>
+
+ Ignore in-app browser privacy checks for apps with com.apple.private.applemediaservices entitlement
+ https://bugs.webkit.org/show_bug.cgi?id=209509
+ <rdar://problem/60750956>
+
+ Reviewed by Brent Fulgham.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::m_ignoresAppBoundDomains):
+ (WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):
+ * UIProcess/WebPageProxy.h:
+
2020-03-24 Per Arne Vollan <pvol...@apple.com>
[Cocoa] Fix launch time regression with CF prefs direct mode enabled
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (258957 => 258958)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-03-24 23:33:58 UTC (rev 258957)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-03-24 23:51:04 UTC (rev 258958)
@@ -210,6 +210,7 @@
#include <WebCore/RunLoopObserver.h>
#include <WebCore/TextIndicatorWindow.h>
#include <wtf/MachSendRight.h>
+#include <wtf/cocoa/Entitlements.h>
#endif
#if HAVE(TOUCH_BAR)
@@ -479,6 +480,9 @@
#endif
, m_resetRecentCrashCountTimer(RunLoop::main(), this, &WebPageProxy::resetRecentCrashCount)
, m_tryCloseTimeoutTimer(RunLoop::main(), this, &WebPageProxy::tryCloseTimedOut)
+#if PLATFORM(COCOA)
+ , m_ignoresAppBoundDomains(m_configuration->ignoresAppBoundDomains() || WTF::processHasEntitlement("com.apple.private.applemediaservices"))
+#endif
{
RELEASE_LOG_IF_ALLOWED(Loading, "constructor:");
@@ -3103,7 +3107,7 @@
void WebPageProxy::setIsNavigatingToAppBoundDomain(bool isMainFrame, const URL& requestURL, NavigatingToAppBoundDomain isNavigatingToAppBoundDomain)
{
if (isMainFrame && (m_preferences->isInAppBrowserPrivacyEnabled() || WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN_2)) {
- if (m_configuration->ignoresAppBoundDomains())
+ if (m_ignoresAppBoundDomains)
return;
WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN
if (isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::No && shouldBeTreatedAsAppBound(requestURL))
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (258957 => 258958)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2020-03-24 23:33:58 UTC (rev 258957)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2020-03-24 23:51:04 UTC (rev 258958)
@@ -2753,6 +2753,7 @@
NavigatingToAppBoundDomain m_isNavigatingToAppBoundDomain { NavigatingToAppBoundDomain::No };
NavigatedAwayFromAppBoundDomain m_hasNavigatedAwayFromAppBoundDomain { NavigatedAwayFromAppBoundDomain::No };
+ bool m_ignoresAppBoundDomains { false };
};
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
