Title: [259348] trunk/Source/WebCore
Revision
259348
Author
shihchieh_...@apple.com
Date
2020-04-01 09:13:01 -0700 (Wed, 01 Apr 2020)

Log Message

Notify accessibility when a node is removed from its ancestor.
https://bugs.webkit.org/show_bug.cgi?id=209819

Reviewed by Chris Fleizach.

Covered by existing tests in LayoutTests/accessibility.

* dom/Node.cpp:
(WebCore::Node::removedFromAncestor):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (259347 => 259348)


--- trunk/Source/WebCore/ChangeLog	2020-04-01 16:04:07 UTC (rev 259347)
+++ trunk/Source/WebCore/ChangeLog	2020-04-01 16:13:01 UTC (rev 259348)
@@ -1,3 +1,15 @@
+2020-04-01  Jack Lee  <shihchieh_...@apple.com>
+
+        Notify accessibility when a node is removed from its ancestor.
+        https://bugs.webkit.org/show_bug.cgi?id=209819
+
+        Reviewed by Chris Fleizach.
+
+        Covered by existing tests in LayoutTests/accessibility.
+
+        * dom/Node.cpp:
+        (WebCore::Node::removedFromAncestor):
+
 2020-04-01  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, reverting r259282.

Modified: trunk/Source/WebCore/dom/Node.cpp (259347 => 259348)


--- trunk/Source/WebCore/dom/Node.cpp	2020-04-01 16:04:07 UTC (rev 259347)
+++ trunk/Source/WebCore/dom/Node.cpp	2020-04-01 16:13:01 UTC (rev 259348)
@@ -1297,12 +1297,18 @@
     return InsertedIntoAncestorResult::Done;
 }
 
-void Node::removedFromAncestor(RemovalType removalType, ContainerNode&)
+void Node::removedFromAncestor(RemovalType removalType, ContainerNode& oldParentOfRemovedTree)
 {
     if (removalType.disconnectedFromDocument)
         clearFlag(IsConnectedFlag);
     if (isInShadowTree() && !treeScope().rootNode().isShadowRoot())
         clearFlag(IsInShadowTreeFlag);
+    if (removalType.disconnectedFromDocument) {
+        if (auto* document = &oldParentOfRemovedTree.treeScope().documentScope()) {
+            if (auto* cache = document->existingAXObjectCache())
+                cache->remove(*this);
+        }
+    }
 }
 
 bool Node::isRootEditableElement() const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to