Title: [260587] trunk/Tools
- Revision
- 260587
- Author
- ryanhad...@apple.com
- Date
- 2020-04-23 12:42:06 -0700 (Thu, 23 Apr 2020)
Log Message
Unreviewed, reverting r260552.
Broke internal builds.
Reverted changeset:
"DumpRenderTree should have the JIT entitlement on Mac"
https://bugs.webkit.org/show_bug.cgi?id=210887
https://trac.webkit.org/changeset/260552
Modified Paths
Removed Paths
Diff
Modified: trunk/Tools/ChangeLog (260586 => 260587)
--- trunk/Tools/ChangeLog 2020-04-23 19:29:22 UTC (rev 260586)
+++ trunk/Tools/ChangeLog 2020-04-23 19:42:06 UTC (rev 260587)
@@ -1,3 +1,15 @@
+2020-04-23 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, reverting r260552.
+
+ Broke internal builds.
+
+ Reverted changeset:
+
+ "DumpRenderTree should have the JIT entitlement on Mac"
+ https://bugs.webkit.org/show_bug.cgi?id=210887
+ https://trac.webkit.org/changeset/260552
+
2020-04-23 Wenson Hsieh <wenson_hs...@apple.com>
Add a heuristic for text manipulation to treat some list items as paragraph boundaries
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (260586 => 260587)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2020-04-23 19:29:22 UTC (rev 260586)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2020-04-23 19:42:06 UTC (rev 260587)
@@ -323,7 +323,6 @@
5185F69F10714A57007AA393 /* HistoryDelegate.mm */ = {isa = PBXFileReference; explicitFileType = sourcecode.cpp.objcpp; fileEncoding = 4; name = HistoryDelegate.mm; path = mac/HistoryDelegate.mm; sourceTree = "<group>"; };
51CACBD715D96FD000EB53A2 /* EvaluateJSWithinNPP_New.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = EvaluateJSWithinNPP_New.cpp; path = TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp; sourceTree = SOURCE_ROOT; };
520206CE1A0ADA5900AD5154 /* SetMuted.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SetMuted.cpp; sourceTree = "<group>"; };
- 520D64B12451023700D6391F /* DumpRenderTree.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; name = DumpRenderTree.entitlements; path = mac/Configurations/DumpRenderTree.entitlements; sourceTree = "<group>"; };
53CBB830134E42F3001CE6A4 /* CyclicRedundancyCheck.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CyclicRedundancyCheck.cpp; sourceTree = "<group>"; };
53CBB831134E42F3001CE6A4 /* CyclicRedundancyCheck.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CyclicRedundancyCheck.h; sourceTree = "<group>"; };
5DE8AE4313A2C15800D6A37D /* libWebCoreTestSupport.dylib */ = {isa = PBXFileReference; lastKnownFileType = "compiled.mach-o.dylib"; path = libWebCoreTestSupport.dylib; sourceTree = BUILT_PRODUCTS_DIR; };
@@ -830,7 +829,6 @@
BCB281EE0CFA713D007E533E /* Base.xcconfig */,
A16CD20D18907A7D0092363E /* BaseTarget.xcconfig */,
BCB282F40CFA7450007E533E /* DebugRelease.xcconfig */,
- 520D64B12451023700D6391F /* DumpRenderTree.entitlements */,
BCB281F00CFA713D007E533E /* DumpRenderTree.xcconfig */,
A19317FD18928738001C52B1 /* DumpRenderTreeApp.xcconfig */,
A134E5391890671C00901D06 /* DumpRenderTreeLibrary.xcconfig */,
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/BaseTarget.xcconfig (260586 => 260587)
--- trunk/Tools/DumpRenderTree/mac/Configurations/BaseTarget.xcconfig 2020-04-23 19:29:22 UTC (rev 260586)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/BaseTarget.xcconfig 2020-04-23 19:42:06 UTC (rev 260587)
@@ -21,15 +21,6 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-#include? "../../../../../Internal/Configurations/HaveInternalSDK.xcconfig"
-
-USE_INTERNAL_SDK = $(USE_INTERNAL_SDK_$(CONFIGURATION));
-USE_INTERNAL_SDK_Production = YES;
-USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK);
-USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
-
-WK_USE_RESTRICTED_ENTITLEMENTS = $(USE_INTERNAL_SDK);
-
OTHER_CFLAGS = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Frameworks;
OTHER_CPLUSPLUSFLAGS = $(OTHER_CFLAGS);
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
Deleted: trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.entitlements (260586 => 260587)
--- trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.entitlements 2020-04-23 19:29:22 UTC (rev 260586)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.entitlements 2020-04-23 19:42:06 UTC (rev 260587)
@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
- <key>com.apple.security.cs.allow-jit</key>
- <true/>
-</dict>
-</plist>
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig (260586 => 260587)
--- trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig 2020-04-23 19:29:22 UTC (rev 260586)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig 2020-04-23 19:42:06 UTC (rev 260587)
@@ -39,10 +39,3 @@
INSTALL_PATH_Debug = $(INSTALL_PATH);
INSTALL_PATH_Production = $(SYSTEM_LIBRARY_DIR)/Frameworks/$(WEBKIT_FRAMEWORK_RESOURCES_PATH);
INSTALL_PATH_engineering = $(INSTALL_PATH);
-
-CODE_SIGN_IDENTITY[sdk=macosx*] = $(CODE_SIGN_IDENTITY_$(WK_USE_RESTRICTED_ENTITLEMENTS))
-CODE_SIGN_IDENTITY_ = $(CODE_SIGN_IDENTITY_NO);
-CODE_SIGN_IDENTITY_NO = -;
-CODE_SIGN_IDENTITY_YES = $(WK_ENGINEERING_CODE_SIGN_IDENTITY);
-
-CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = mac/Configurations/DumpRenderTree.entitlements;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
