Title: [261225] trunk/LayoutTests
- Revision
- 261225
- Author
- you...@apple.com
- Date
- 2020-05-06 07:15:11 -0700 (Wed, 06 May 2020)
Log Message
REGRESSION (r261163): [ Mac WK2 ] webrtc/libwebrtc/descriptionGetters.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=211455
<rdar://problem/62895451>
Reviewed by Eric Carlson.
* webrtc/libwebrtc/descriptionGetters.html:
Sanitize SDP before comparison as port information and candidates are no longer blocked by main thread.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (261224 => 261225)
--- trunk/LayoutTests/ChangeLog 2020-05-06 14:04:38 UTC (rev 261224)
+++ trunk/LayoutTests/ChangeLog 2020-05-06 14:15:11 UTC (rev 261225)
@@ -1,3 +1,14 @@
+2020-05-06 Youenn Fablet <you...@apple.com>
+
+ REGRESSION (r261163): [ Mac WK2 ] webrtc/libwebrtc/descriptionGetters.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=211455
+ <rdar://problem/62895451>
+
+ Reviewed by Eric Carlson.
+
+ * webrtc/libwebrtc/descriptionGetters.html:
+ Sanitize SDP before comparison as port information and candidates are no longer blocked by main thread.
+
2020-05-06 Diego Pino Garcia <dp...@igalia.com>
[GTK] Gardening, expected to fail but passed
Modified: trunk/LayoutTests/webrtc/libwebrtc/descriptionGetters.html (261224 => 261225)
--- trunk/LayoutTests/webrtc/libwebrtc/descriptionGetters.html 2020-05-06 14:04:38 UTC (rev 261224)
+++ trunk/LayoutTests/webrtc/libwebrtc/descriptionGetters.html 2020-05-06 14:15:11 UTC (rev 261225)
@@ -11,6 +11,15 @@
if (window.testRunner)
testRunner.setUserMediaPermission(true);
+
+function sdpWithoutCandidate(sdp)
+{
+ return sdp.split('\r\n').filter(line => {
+ return line.indexOf('a=candidate') !== 0 && line.indexOf('c=IN IP4') !== 0 && line.indexOf('m=video') !== 0 && line.indexOf('m=audio') !== 0;
+ }).join('\r\n');
+}
+
+
promise_test((test) => {
var localConnection = new RTCPeerConnection();
var remoteConnection = new RTCPeerConnection();
@@ -34,8 +43,8 @@
remoteDescriptionPromise = remoteConnection.setRemoteDescription(desc);
assert_equals(localConnection.currentLocalDescription, null, "test 1");
- assert_equals(localConnection.pendingLocalDescription.sdp, currentSDP, "test 2");
- assert_equals(localConnection.localDescription.sdp, currentSDP, "test 3");
+ assert_equals(sdpWithoutCandidate(localConnection.pendingLocalDescription.sdp), sdpWithoutCandidate(currentSDP), "test 2");
+ assert_equals(sdpWithoutCandidate(localConnection.localDescription.sdp), sdpWithoutCandidate(currentSDP), "test 3");
assert_equals(remoteConnection.currentRemoteDescription, null);
assert_equals(remoteConnection.pendingRemoteDescription.sdp, currentSDP, "test 4");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
