Title: [261695] trunk/Source
- Revision
- 261695
- Author
- cdu...@apple.com
- Date
- 2020-05-14 09:11:26 -0700 (Thu, 14 May 2020)
Log Message
Regression(r254856) Family Health iOS app is broken due to lack for WebSQL support
https://bugs.webkit.org/show_bug.cgi?id=211896
<rdar://problem/63025045>
Reviewed by Maciej Stachowiak.
Source/WebCore:
Add RuntimeApplicationChecks function to identify Family Health app on iOS.
* platform/RuntimeApplicationChecks.h:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isFamilyHealthApp):
Source/WebKitLegacy/mac:
Re-enable WebSQL support for Family Health iOS app with a linked-on-after check.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Source/WTF:
* wtf/spi/darwin/dyldSPI.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (261694 => 261695)
--- trunk/Source/WTF/ChangeLog 2020-05-14 15:35:45 UTC (rev 261694)
+++ trunk/Source/WTF/ChangeLog 2020-05-14 16:11:26 UTC (rev 261695)
@@ -1,3 +1,13 @@
+2020-05-14 Chris Dumez <cdu...@apple.com>
+
+ Regression(r254856) Family Health iOS app is broken due to lack for WebSQL support
+ https://bugs.webkit.org/show_bug.cgi?id=211896
+ <rdar://problem/63025045>
+
+ Reviewed by Maciej Stachowiak.
+
+ * wtf/spi/darwin/dyldSPI.h:
+
2020-05-13 Ross Kirsling <ross.kirsl...@sony.com>
[IWYU] Try removing redundant includes in WTF implementation files
Modified: trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h (261694 => 261695)
--- trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h 2020-05-14 15:35:45 UTC (rev 261694)
+++ trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h 2020-05-14 16:11:26 UTC (rev 261695)
@@ -53,6 +53,10 @@
#define DYLD_IOS_VERSION_13_4 0x000D0400
#endif
+#ifndef DYLD_IOS_VERSION_14_0
+#define DYLD_IOS_VERSION_14_0 0x000e0000
+#endif
+
#ifndef DYLD_MACOSX_VERSION_10_13
#define DYLD_MACOSX_VERSION_10_13 0x000A0D00
#endif
@@ -89,6 +93,7 @@
#define DYLD_IOS_VERSION_13_0 0x000D0000
#define DYLD_IOS_VERSION_13_2 0x000D0200
#define DYLD_IOS_VERSION_13_4 0x000D0400
+#define DYLD_IOS_VERSION_14_0 0x000e0000
#define DYLD_MACOSX_VERSION_10_11 0x000A0B00
#define DYLD_MACOSX_VERSION_10_12 0x000A0C00
Modified: trunk/Source/WebCore/ChangeLog (261694 => 261695)
--- trunk/Source/WebCore/ChangeLog 2020-05-14 15:35:45 UTC (rev 261694)
+++ trunk/Source/WebCore/ChangeLog 2020-05-14 16:11:26 UTC (rev 261695)
@@ -1,3 +1,17 @@
+2020-05-14 Chris Dumez <cdu...@apple.com>
+
+ Regression(r254856) Family Health iOS app is broken due to lack for WebSQL support
+ https://bugs.webkit.org/show_bug.cgi?id=211896
+ <rdar://problem/63025045>
+
+ Reviewed by Maciej Stachowiak.
+
+ Add RuntimeApplicationChecks function to identify Family Health app on iOS.
+
+ * platform/RuntimeApplicationChecks.h:
+ * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+ (WebCore::IOSApplication::isFamilyHealthApp):
+
2020-05-14 Andres Gonzalez <andresg...@apple.com>
AXIsolatedTree::updateChildren needs to apply pending changes before updating the given node.
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (261694 => 261695)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2020-05-14 15:35:45 UTC (rev 261694)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2020-05-14 16:11:26 UTC (rev 261695)
@@ -87,6 +87,7 @@
WEBCORE_EXPORT bool isMiniBrowser();
bool isMobileStore();
WEBCORE_EXPORT bool isJesusCalling();
+WEBCORE_EXPORT bool isFamilyHealthApp();
bool isSpringBoard();
WEBCORE_EXPORT bool isWebProcess();
WEBCORE_EXPORT bool isIBooks();
Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (261694 => 261695)
--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-05-14 15:35:45 UTC (rev 261694)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-05-14 16:11:26 UTC (rev 261695)
@@ -255,6 +255,12 @@
return isJesusCalling;
}
+bool IOSApplication::isFamilyHealthApp()
+{
+ static bool isFamilyHealthApp = applicationBundleStartsWith("com.wildflowerhealth.Grow"_s) || applicationBundleStartsWith("com.wildflowerhealth.UGROW");
+ return isFamilyHealthApp;
+}
+
bool IOSApplication::isMobileStore()
{
static bool isMobileStore = applicationBundleIsEqualTo("com.apple.MobileStore"_s);
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (261694 => 261695)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-05-14 15:35:45 UTC (rev 261694)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-05-14 16:11:26 UTC (rev 261695)
@@ -1,3 +1,16 @@
+2020-05-14 Chris Dumez <cdu...@apple.com>
+
+ Regression(r254856) Family Health iOS app is broken due to lack for WebSQL support
+ https://bugs.webkit.org/show_bug.cgi?id=211896
+ <rdar://problem/63025045>
+
+ Reviewed by Maciej Stachowiak.
+
+ Re-enable WebSQL support for Family Health iOS app with a linked-on-after check.
+
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+
2020-05-12 Chris Dumez <cdu...@apple.com>
[WK2] Neuter WKFrameIsFrameSet() / WKPageGetFrameSetLargestFrame() C API
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (261694 => 261695)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-05-14 15:35:45 UTC (rev 261694)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-05-14 16:11:26 UTC (rev 261695)
@@ -396,7 +396,7 @@
bool allowsInlineMediaPlaybackAfterFullscreen = WebCore::deviceClass() != MGDeviceClassiPad;
bool requiresPlaysInlineAttribute = !allowsInlineMediaPlayback;
bool attachmentElementEnabled = IOSApplication::isMobileMail();
- bool webSQLEnabled = IOSApplication::isJesusCalling() && applicationSDKVersion() <= DYLD_IOS_VERSION_12_2;
+ bool webSQLEnabled = (IOSApplication::isFamilyHealthApp() || IOSApplication::isJesusCalling()) && applicationSDKVersion() < DYLD_IOS_VERSION_14_0;
#endif
NSDictionary *dict = [NSDictionary dictionaryWithObjectsAndKeys:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
