Title: [261847] trunk/Source/WebKitLegacy/mac
- Revision
- 261847
- Author
- peng.l...@apple.com
- Date
- 2020-05-18 21:24:52 -0700 (Mon, 18 May 2020)
Log Message
ASSERTION FAILED: media/modern-media-controls/media-controller/media-controller-resize.html crashes under stress tests
https://bugs.webkit.org/show_bug.cgi?id=212052
Reviewed by Jer Noble.
Not able to reproduce the crash locally. But it does happen under stress tests
on bots.
* WebView/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController windowDidExitFullScreen:]):
Only call HTMLMediaElement::exitFullscreen() when the element is in fullscreen.
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (261846 => 261847)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-05-19 02:41:11 UTC (rev 261846)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-05-19 04:24:52 UTC (rev 261847)
@@ -1,3 +1,17 @@
+2020-05-18 Peng Liu <peng.l...@apple.com>
+
+ ASSERTION FAILED: media/modern-media-controls/media-controller/media-controller-resize.html crashes under stress tests
+ https://bugs.webkit.org/show_bug.cgi?id=212052
+
+ Reviewed by Jer Noble.
+
+ Not able to reproduce the crash locally. But it does happen under stress tests
+ on bots.
+
+ * WebView/WebVideoFullscreenController.mm:
+ (-[WebVideoFullscreenController windowDidExitFullScreen:]):
+ Only call HTMLMediaElement::exitFullscreen() when the element is in fullscreen.
+
2020-05-18 Andy Estes <aes...@apple.com>
http/tests/ssl/applepay/ApplePayInstallmentConfiguration.https.html fails in public SDK builds
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm (261846 => 261847)
--- trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm 2020-05-19 02:41:11 UTC (rev 261846)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm 2020-05-19 04:24:52 UTC (rev 261847)
@@ -337,7 +337,9 @@
[self.fullscreenWindow close];
[NSAnimationContext endGrouping];
});
- _videoElement->exitFullscreen();
+
+ if (_videoElement->isFullscreen())
+ _videoElement->exitFullscreen();
}
@end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
