Title: [262055] trunk/Source/WebKit
- Revision
- 262055
- Author
- timothy_hor...@apple.com
- Date
- 2020-05-22 06:56:36 -0700 (Fri, 22 May 2020)
Log Message
REGRESSION (r261978): Cannot click on links with trackpad on iPad
https://bugs.webkit.org/show_bug.cgi?id=212262
Reviewed by Andy Estes.
No new tests; our current WKMouseGestureRecognizer testing strategy
unfortunately bypasses this particular problem.
* UIProcess/ios/WKMouseGestureRecognizer.mm:
(-[WKMouseGestureRecognizer _hoverEntered:withEvent:]):
(-[WKMouseGestureRecognizer _hoverMoved:withEvent:]):
(-[WKMouseGestureRecognizer _hoverExited:withEvent:]):
(-[WKMouseGestureRecognizer _hoverCancelled:withEvent:]):
Don't call super in any of the hover callbacks now that we derive from
UIHoverGestureRecognizer. We want to wholly own the state of the gesture,
including differences from UIHoverGestureRecognizer behavior such as
remaining in the recognizing state while the trackpad button is pressed.
We don't need any of the code in the default implementation, so just
override it entirely. This returns behavior to what it was like before r261978.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (262054 => 262055)
--- trunk/Source/WebKit/ChangeLog 2020-05-22 12:50:28 UTC (rev 262054)
+++ trunk/Source/WebKit/ChangeLog 2020-05-22 13:56:36 UTC (rev 262055)
@@ -1,3 +1,25 @@
+2020-05-22 Tim Horton <timothy_hor...@apple.com>
+
+ REGRESSION (r261978): Cannot click on links with trackpad on iPad
+ https://bugs.webkit.org/show_bug.cgi?id=212262
+
+ Reviewed by Andy Estes.
+
+ No new tests; our current WKMouseGestureRecognizer testing strategy
+ unfortunately bypasses this particular problem.
+
+ * UIProcess/ios/WKMouseGestureRecognizer.mm:
+ (-[WKMouseGestureRecognizer _hoverEntered:withEvent:]):
+ (-[WKMouseGestureRecognizer _hoverMoved:withEvent:]):
+ (-[WKMouseGestureRecognizer _hoverExited:withEvent:]):
+ (-[WKMouseGestureRecognizer _hoverCancelled:withEvent:]):
+ Don't call super in any of the hover callbacks now that we derive from
+ UIHoverGestureRecognizer. We want to wholly own the state of the gesture,
+ including differences from UIHoverGestureRecognizer behavior such as
+ remaining in the recognizing state while the trackpad button is pressed.
+ We don't need any of the code in the default implementation, so just
+ override it entirely. This returns behavior to what it was like before r261978.
+
2020-05-21 Sam Weinig <wei...@apple.com>
Extended Color Cleanup: Move Color coder definitions to Color to allow for future encaspulation improvements
Modified: trunk/Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm (262054 => 262055)
--- trunk/Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm 2020-05-22 12:50:28 UTC (rev 262054)
+++ trunk/Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm 2020-05-22 13:56:36 UTC (rev 262055)
@@ -192,8 +192,6 @@
_lastLocation = [self locationInView:self.view];
self.state = UIGestureRecognizerStateBegan;
}
-
- [super _hoverEntered:touches withEvent:event];
}
- (void)_hoverMoved:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event
@@ -208,8 +206,6 @@
if (_currentHoverEvent == event && [touches containsObject:_currentTouch.get()])
self.state = UIGestureRecognizerStateChanged;
-
- [super _hoverMoved:touches withEvent:event];
}
- (void)_hoverExited:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event
@@ -222,14 +218,11 @@
_currentTouch = nil;
self.state = UIGestureRecognizerStateEnded;
}
-
- [super _hoverExited:touches withEvent:event];
}
- (void)_hoverCancelled:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event
{
[self _hoverExited:touches withEvent:event];
- [super _hoverCancelled:touches withEvent:event];
}
- (CGPoint)locationInView:(UIView *)view
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
