Title: [262139] trunk/LayoutTests
Revision
262139
Author
clo...@igalia.com
Date
2020-05-26 01:46:45 -0700 (Tue, 26 May 2020)

Log Message

[css-flexbox] WPT Test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails
https://bugs.webkit.org/show_bug.cgi?id=212054

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Update the test to use the Ahem font, and rely on different font colors (instead of different glyps)
to check that each box of the test is placed correctly.

* web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html:
* web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html:

LayoutTests:

Remove expectations for passing test.

* TestExpectations:
* platform/glib/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (262138 => 262139)


--- trunk/LayoutTests/ChangeLog	2020-05-26 08:01:14 UTC (rev 262138)
+++ trunk/LayoutTests/ChangeLog	2020-05-26 08:46:45 UTC (rev 262139)
@@ -1,3 +1,15 @@
+2020-05-25  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [css-flexbox] WPT Test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=212054
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Remove expectations for passing test.
+
+        * TestExpectations:
+        * platform/glib/TestExpectations:
+
 2020-05-25  Diego Pino Garcia  <dp...@igalia.com>
 
         [WPE] Gardening, update baselines after r262127

Modified: trunk/LayoutTests/TestExpectations (262138 => 262139)


--- trunk/LayoutTests/TestExpectations	2020-05-26 08:01:14 UTC (rev 262138)
+++ trunk/LayoutTests/TestExpectations	2020-05-26 08:46:45 UTC (rev 262139)
@@ -4258,7 +4258,6 @@
 webkit.org/b/212046 imported/w3c/web-platform-tests/css/css-flexbox/scrollbars.html [ ImageOnlyFailure ]
 webkit.org/b/212046 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-fixed-min-width.html [ ImageOnlyFailure ]
 webkit.org/b/212046 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-narrow-content.html [ ImageOnlyFailure ]
-webkit.org/b/212054 imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html [ ImageOnlyFailure ]
 
 # CSS Masonry Layout not supported.
 imported/w3c/web-platform-tests/css/css-grid/masonry.tentative [ Skip ]

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (262138 => 262139)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-05-26 08:01:14 UTC (rev 262138)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-05-26 08:46:45 UTC (rev 262139)
@@ -1,3 +1,16 @@
+2020-05-25  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [css-flexbox] WPT Test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=212054
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Update the test to use the Ahem font, and rely on different font colors (instead of different glyps)
+        to check that each box of the test is placed correctly.
+
+        * web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html:
+        * web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html:
+
 2020-05-25  Oriol Brufau  <obru...@igalia.com>
 
         [css-grid] Prevent grid-template-rows from serializing adjacent <line-names>

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html (262138 => 262139)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html	2020-05-26 08:01:14 UTC (rev 262138)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html	2020-05-26 08:46:45 UTC (rev 262139)
@@ -4,8 +4,9 @@
   <title>CSS Test Reference: flex container multiline wrapping-reverse in column-reverse direction</title>
   <link rel="author" title="tmtysk" href=""
   <link rel="reviewer" title="Tab Atkins" href=""
+  <link rel="stylesheet" type="text/css" href="" />
   <style>
-    * { margin:0; padding:0; font-size:100%; line-height:1; }
+    * { margin:0; padding:0; font-size:100%; line-height:1; font-family: Ahem; }
 
     .test {
       width: 300px;
@@ -21,26 +22,32 @@
 
     #row1-col1 {
         height: 90px;
+        color: orange;
     }
 
     #row1-col2 {
         height: 90px;
+        color: green;
     }
 
     #row1-col3 {
         height: 90px;
+        color: blue;
     }
 
     #row2-col1 {
         height: 140px;
+        color: yellow;
     }
 
     #row2-col2 {
         height: 140px;
+        color: magenta;
     }
 
     #row3-col1 {
         height: 290px;
+        color: cyan;
     }
 
     .clear {

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html (262138 => 262139)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html	2020-05-26 08:01:14 UTC (rev 262138)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html	2020-05-26 08:46:45 UTC (rev 262139)
@@ -7,9 +7,10 @@
   <link rel="help" href=""
   <link rel="help" href=""
   <link rel="match" href=""
+  <link rel="stylesheet" type="text/css" href="" />
   <meta name="assert" content="This test check that a flex container reverse-wraps blocks multiline in column-reverse direction.">
   <style>
-    * { margin:0; padding:0; font-size:100%; line-height:1; }
+    * { margin:0; padding:0; font-size:100%; line-height:1; font-family: Ahem; }
 
     #test {
       display: flex;
@@ -26,26 +27,32 @@
 
     #col1-row1 {
         height: 90px;
+        color: orange;
     }
 
     #col1-row2 {
         height: 90px;
+        color: green;
     }
 
     #col1-row3 {
         height: 90px;
+        color: blue;
     }
 
     #col2-row1 {
         height: 140px;
+        color: yellow;
     }
 
     #col2-row2 {
         height: 140px;
+        color: magenta;
     }
 
     #col3-row1 {
         height: 290px;
+        color: cyan;
     }
 
   </style>

Modified: trunk/LayoutTests/platform/glib/TestExpectations (262138 => 262139)


--- trunk/LayoutTests/platform/glib/TestExpectations	2020-05-26 08:01:14 UTC (rev 262138)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2020-05-26 08:46:45 UTC (rev 262139)
@@ -169,8 +169,6 @@
 # 10. TESTS PASSING
 #////////////////////////////////////////////////////////////////////////////////////////
 
-webkit.org/b/212054 imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html [ Pass ]
-
 fast/text/emoji-gender-2-3.html [ Pass ]
 fast/text/emoji-gender-2-4.html [ Pass ]
 fast/text/emoji-gender-2-5.html [ Pass ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to