Title: [262243] trunk/Source/_javascript_Core
Revision
262243
Author
commit-qu...@webkit.org
Date
2020-05-28 08:31:04 -0700 (Thu, 28 May 2020)

Log Message

Web Inspector: generate_cpp_protocol_types_header.py:294: SyntaxWarning: "is" with a literal. Did you mean "=="?
https://bugs.webkit.org/show_bug.cgi?id=212468

Patch by Michael Catanzaro <mcatanz...@gnome.org> on 2020-05-28
Reviewed by Timothy Hatcher.

Use "==" instead of "is" to compare against 0.

* inspector/scripts/codegen/generate_cpp_protocol_types_header.py:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (262242 => 262243)


--- trunk/Source/_javascript_Core/ChangeLog	2020-05-28 15:28:26 UTC (rev 262242)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-05-28 15:31:04 UTC (rev 262243)
@@ -1,3 +1,14 @@
+2020-05-28  Michael Catanzaro  <mcatanz...@gnome.org>
+
+        Web Inspector: generate_cpp_protocol_types_header.py:294: SyntaxWarning: "is" with a literal. Did you mean "=="?
+        https://bugs.webkit.org/show_bug.cgi?id=212468
+
+        Reviewed by Timothy Hatcher.
+
+        Use "==" instead of "is" to compare against 0.
+
+        * inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
+
 2020-05-28  Mark Lam  <mark....@apple.com>
 
         Gardening: Add an assertNoException() to placate the exception checker and green the bots.

Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_cpp_protocol_types_header.py (262242 => 262243)


--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_cpp_protocol_types_header.py	2020-05-28 15:28:26 UTC (rev 262242)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_cpp_protocol_types_header.py	2020-05-28 15:31:04 UTC (rev 262243)
@@ -291,7 +291,7 @@
 
     def _generate_struct_for_anonymous_enum_member(self, enum_member):
         def apply_indentation(line):
-            if line.startswith(('#', '/*', '*/', '//')) or len(line) is 0:
+            if line.startswith(('#', '/*', '*/', '//')) or len(line) == 0:
                 return line
             else:
                 return '    ' + line
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to