Title: [262383] trunk/JSTests
- Revision
- 262383
- Author
- ticaiol...@gmail.com
- Date
- 2020-06-01 10:58:03 -0700 (Mon, 01 Jun 2020)
Log Message
JSTests/exceptionFuzz/earley-boyer.js fails with early exception thrown.
https://bugs.webkit.org/show_bug.cgi?id=212569
Reviewed by Mark Lam.
This is a temporary fix to avoid flawky results when running
`exceptionFuzz` tests. Right now, exception handler starts after
function declarations, since they are hoisted. Since function
declarations emit `new_func` bytecode, those bytecodes can
throw an exception outside expected exception handler.
Embedding them in a function avoid such hoisting to happen.
* exceptionFuzz/3d-cube.js:
* exceptionFuzz/date-format-xparb.js:
* exceptionFuzz/earley-boyer.js:
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (262382 => 262383)
--- trunk/JSTests/ChangeLog 2020-06-01 17:03:00 UTC (rev 262382)
+++ trunk/JSTests/ChangeLog 2020-06-01 17:58:03 UTC (rev 262383)
@@ -1,3 +1,21 @@
+2020-06-01 Caio Lima <ticaiol...@gmail.com>
+
+ JSTests/exceptionFuzz/earley-boyer.js fails with early exception thrown.
+ https://bugs.webkit.org/show_bug.cgi?id=212569
+
+ Reviewed by Mark Lam.
+
+ This is a temporary fix to avoid flawky results when running
+ `exceptionFuzz` tests. Right now, exception handler starts after
+ function declarations, since they are hoisted. Since function
+ declarations emit `new_func` bytecode, those bytecodes can
+ throw an exception outside expected exception handler.
+ Embedding them in a function avoid such hoisting to happen.
+
+ * exceptionFuzz/3d-cube.js:
+ * exceptionFuzz/date-format-xparb.js:
+ * exceptionFuzz/earley-boyer.js:
+
2020-05-30 Yusuke Suzuki <ysuz...@apple.com>
[JSC] for-in should allocate new temporary register for base
Modified: trunk/JSTests/exceptionFuzz/3d-cube.js (262382 => 262383)
--- trunk/JSTests/exceptionFuzz/3d-cube.js 2020-06-01 17:03:00 UTC (rev 262382)
+++ trunk/JSTests/exceptionFuzz/3d-cube.js 2020-06-01 17:58:03 UTC (rev 262383)
@@ -1,4 +1,5 @@
try {
+(function() {
// 3D Cube Rotation
// http://www.speich.net/computer/moztesting/3d.htm
@@ -355,6 +356,7 @@
LoopTime = null;
DisplArea = null;
+})();
} catch (e) {
print("JSC EXCEPTION FUZZ: Caught exception: " + e);
}
Modified: trunk/JSTests/exceptionFuzz/date-format-xparb.js (262382 => 262383)
--- trunk/JSTests/exceptionFuzz/date-format-xparb.js 2020-06-01 17:03:00 UTC (rev 262382)
+++ trunk/JSTests/exceptionFuzz/date-format-xparb.js 2020-06-01 17:58:03 UTC (rev 262383)
@@ -1,4 +1,5 @@
try {
+(function() {
/*
* Copyright (C) 2004 Baron Schwartz <baron at sequent dot org>
@@ -421,6 +422,7 @@
// FIXME: Find a way to validate this test.
// https://bugs.webkit.org/show_bug.cgi?id=114849
+})();
} catch (e) {
print("JSC EXCEPTION FUZZ: Caught exception: " + e);
}
Modified: trunk/JSTests/exceptionFuzz/earley-boyer.js (262382 => 262383)
--- trunk/JSTests/exceptionFuzz/earley-boyer.js 2020-06-01 17:03:00 UTC (rev 262382)
+++ trunk/JSTests/exceptionFuzz/earley-boyer.js 2020-06-01 17:58:03 UTC (rev 262383)
@@ -1,4 +1,5 @@
try {
+(function() {
// This file is automatically generated by scheme2js, except for the
// benchmark harness code at the beginning and end of the file.
@@ -4681,7 +4682,7 @@
BgL_earleyzd2benchmarkzd2();
BgL_nboyerzd2benchmarkzd2();
}
-
+})();
} catch (e) {
print("JSC EXCEPTION FUZZ: Caught exception: " + e);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
