Diff
Modified: trunk/LayoutTests/ChangeLog (263300 => 263301)
--- trunk/LayoutTests/ChangeLog 2020-06-20 00:07:47 UTC (rev 263300)
+++ trunk/LayoutTests/ChangeLog 2020-06-20 00:11:31 UTC (rev 263301)
@@ -1,3 +1,17 @@
+2020-06-19 Truitt Savell <tsav...@apple.com>
+
+ Unreviewed, reverting r263121.
+
+ Broke media/video-fullscreen-only-playback.html on Catalina
+ Debug
+
+ Reverted changeset:
+
+ "Don't claim to support fullscreen mode unless
+ fullScreenEnabled setting is enabled"
+ https://bugs.webkit.org/show_bug.cgi?id=213142
+ https://trac.webkit.org/changeset/263121
+
2020-06-19 Said Abou-Hallawa <sabouhall...@apple.com>
[CG] REGRESSION (r256892): Luminance SVG mask is not applied when accelerated drawing is enabled
Modified: trunk/LayoutTests/TestExpectations (263300 => 263301)
--- trunk/LayoutTests/TestExpectations 2020-06-20 00:07:47 UTC (rev 263300)
+++ trunk/LayoutTests/TestExpectations 2020-06-20 00:11:31 UTC (rev 263301)
@@ -880,9 +880,6 @@
webkit.org/b/203146 http/wpt/offscreen-canvas [ Skip ]
webkit.org/b/203146 imported/w3c/web-platform-tests/html/canvas/offscreen [ Skip ]
-# Tests a setting behind the ENABLE_FULLSCREEN_API flag, which is WK2-only
-media/video-supports-fullscreen.html [ Skip ]
-
#//////////////////////////////////////////////////////////////////////////////////////////
# End platform-specific tests.
#//////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/LayoutTests/media/video-fullscreen-only-playback.html (263300 => 263301)
--- trunk/LayoutTests/media/video-fullscreen-only-playback.html 2020-06-20 00:07:47 UTC (rev 263300)
+++ trunk/LayoutTests/media/video-fullscreen-only-playback.html 2020-06-20 00:11:31 UTC (rev 263301)
@@ -18,7 +18,8 @@
video.loop = true;
internals.settings.setAllowsInlineMediaPlayback(false);
-
+ // Disable the Fullscreen API (element fullscreen) support
+ internals.settings.setFullScreenEnabled(false);
internals.setMockVideoPresentationModeEnabled(true);
consoleWrite("");
Deleted: trunk/LayoutTests/media/video-supports-fullscreen-expected.txt (263300 => 263301)
--- trunk/LayoutTests/media/video-supports-fullscreen-expected.txt 2020-06-20 00:07:47 UTC (rev 263300)
+++ trunk/LayoutTests/media/video-supports-fullscreen-expected.txt 2020-06-20 00:11:31 UTC (rev 263301)
@@ -1,10 +0,0 @@
-
-Test that video.webkitSupportsFullscreen returns false unless the setting is enbled.
-
-EVENT(loadedmetadata)
-RUN(internals.settings.setFullScreenEnabled(false))
-EXPECTED (video.webkitSupportsFullscreen == 'false') OK
-RUN(internals.settings.setFullScreenEnabled(true))
-EXPECTED (video.webkitSupportsFullscreen == 'true') OK
-END OF TEST
-
Deleted: trunk/LayoutTests/media/video-supports-fullscreen.html (263300 => 263301)
--- trunk/LayoutTests/media/video-supports-fullscreen.html 2020-06-20 00:07:47 UTC (rev 263300)
+++ trunk/LayoutTests/media/video-supports-fullscreen.html 2020-06-20 00:11:31 UTC (rev 263301)
@@ -1,37 +0,0 @@
-<!doctype html>
-<html>
-<head>
- <script src=""
- <script src=""
- <script>
- window.addEventListener('load', async evt => {
-
- if (!window.internals) {
- failTest("This test requires internals.")
- return;
- }
-
-let hack = internals.nowPlayingState;
-
- findMediaElement();
-
- video.src = "" "content/test");
-
- await waitFor(video, 'loadedmetadata');
-
- run("internals.settings.setFullScreenEnabled(false)");
- testExpected("video.webkitSupportsFullscreen", false);
-
- run("internals.settings.setFullScreenEnabled(true)");
- testExpected("video.webkitSupportsFullscreen", true);
-
- endTest();
- }, { once: true });
-
- </script>
-</head>
-<body>
- <video controls playsinline></video>
- <p>Test that video.webkitSupportsFullscreen returns false unless the setting is enbled.</p>
-</body>
-</html>
Modified: trunk/LayoutTests/platform/ios/TestExpectations (263300 => 263301)
--- trunk/LayoutTests/platform/ios/TestExpectations 2020-06-20 00:07:47 UTC (rev 263300)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2020-06-20 00:11:31 UTC (rev 263301)
@@ -50,8 +50,6 @@
compositing/no-compositing-when-fulll-screen-is-present.html
webkit.org/b/200308 fast/events/touch/ios/content-observation/non-visible-content-change-in-fullscreen-mode.html [ Skip ]
-media/video-supports-fullscreen.html [ Skip ]
-
inspector/canvas/create-context-webgpu.html [ Skip ]
inspector/canvas/requestClientNodes-webgpu.html [ Skip ]
inspector/canvas/requestShaderSource-webgpu.html [ Skip ]
Modified: trunk/LayoutTests/platform/wk2/TestExpectations (263300 => 263301)
--- trunk/LayoutTests/platform/wk2/TestExpectations 2020-06-20 00:07:47 UTC (rev 263300)
+++ trunk/LayoutTests/platform/wk2/TestExpectations 2020-06-20 00:11:31 UTC (rev 263301)
@@ -775,9 +775,6 @@
# Highlighting marked text ranges from layout tests is only supported in WebKit2.
editing/input/composition-highlights.html [ Pass ]
-# Tests a setting behind the ENABLE_FULLSCREEN_API flag, which is WK2-only
-media/video-supports-fullscreen.html [ Pass ]
-
### END OF (5) Progressions, expected successes that are expected failures in WebKit1.
########################################
Modified: trunk/Source/WebCore/ChangeLog (263300 => 263301)
--- trunk/Source/WebCore/ChangeLog 2020-06-20 00:07:47 UTC (rev 263300)
+++ trunk/Source/WebCore/ChangeLog 2020-06-20 00:11:31 UTC (rev 263301)
@@ -1,3 +1,17 @@
+2020-06-19 Truitt Savell <tsav...@apple.com>
+
+ Unreviewed, reverting r263121.
+
+ Broke media/video-fullscreen-only-playback.html on Catalina
+ Debug
+
+ Reverted changeset:
+
+ "Don't claim to support fullscreen mode unless
+ fullScreenEnabled setting is enabled"
+ https://bugs.webkit.org/show_bug.cgi?id=213142
+ https://trac.webkit.org/changeset/263121
+
2020-06-19 Said Abou-Hallawa <sabouhall...@apple.com>
[CG] REGRESSION (r256892): Luminance SVG mask is not applied when accelerated drawing is enabled
Modified: trunk/Source/WebCore/html/HTMLVideoElement.cpp (263300 => 263301)
--- trunk/Source/WebCore/html/HTMLVideoElement.cpp 2020-06-20 00:07:47 UTC (rev 263300)
+++ trunk/Source/WebCore/html/HTMLVideoElement.cpp 2020-06-20 00:11:31 UTC (rev 263301)
@@ -190,11 +190,7 @@
// Fullscreen implemented by player.
return true;
#else
-
#if ENABLE(FULLSCREEN_API)
- if (videoFullscreenMode == HTMLMediaElementEnums::VideoFullscreenModeStandard && !document().settings().fullScreenEnabled())
- return false;
-
// If the full screen API is enabled and is supported for the current element
// do not require that the player has a video track to enter full screen.
if (videoFullscreenMode == HTMLMediaElementEnums::VideoFullscreenModeStandard && page->chrome().client().supportsFullScreenForElement(*this, false))
