Title: [263491] trunk/Source/_javascript_Core
- Revision
- 263491
- Author
- ca...@igalia.com
- Date
- 2020-06-24 19:05:51 -0700 (Wed, 24 Jun 2020)
Log Message
[JSC] handle Put/DefinePrivateField in resetPutByID
https://bugs.webkit.org/show_bug.cgi?id=213583
Reviewed by Yusuke Suzuki.
r262613 extends and uses PutByValDirect to support updating and defining private fields, in order to reuse
the IC machinery. The necessary resetPutByID change was erroneously omitted, and is presented here.
* jit/Repatch.cpp:
(JSC::resetPutByID):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (263490 => 263491)
--- trunk/Source/_javascript_Core/ChangeLog 2020-06-25 01:43:05 UTC (rev 263490)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-06-25 02:05:51 UTC (rev 263491)
@@ -1,3 +1,16 @@
+2020-06-24 Caitlin Potter <ca...@igalia.com>
+
+ [JSC] handle Put/DefinePrivateField in resetPutByID
+ https://bugs.webkit.org/show_bug.cgi?id=213583
+
+ Reviewed by Yusuke Suzuki.
+
+ r262613 extends and uses PutByValDirect to support updating and defining private fields, in order to reuse
+ the IC machinery. The necessary resetPutByID change was erroneously omitted, and is presented here.
+
+ * jit/Repatch.cpp:
+ (JSC::resetPutByID):
+
2020-06-24 Yusuke Suzuki <ysuz...@apple.com>
[JSC] llintTrue / jitTrue can encounter native functions
Modified: trunk/Source/_javascript_Core/jit/Repatch.cpp (263490 => 263491)
--- trunk/Source/_javascript_Core/jit/Repatch.cpp 2020-06-25 01:43:05 UTC (rev 263490)
+++ trunk/Source/_javascript_Core/jit/Repatch.cpp 2020-06-25 02:05:51 UTC (rev 263491)
@@ -1483,6 +1483,10 @@
optimizedFunction = operationPutByIdNonStrictOptimize;
else if (unoptimizedFunction == operationPutByIdDirectStrict || unoptimizedFunction == operationPutByIdDirectStrictOptimize)
optimizedFunction = operationPutByIdDirectStrictOptimize;
+ else if (unoptimizedFunction == operationPutByIdPutPrivateFieldStrict || unoptimizedFunction == operationPutByIdPutPrivateFieldStrictOptimize)
+ optimizedFunction = operationPutByIdPutPrivateFieldStrictOptimize;
+ else if (unoptimizedFunction == operationPutByIdDefinePrivateFieldStrict || unoptimizedFunction == operationPutByIdDefinePrivateFieldStrictOptimize)
+ optimizedFunction = operationPutByIdDefinePrivateFieldStrictOptimize;
else {
ASSERT(unoptimizedFunction == operationPutByIdDirectNonStrict || unoptimizedFunction == operationPutByIdDirectNonStrictOptimize);
optimizedFunction = operationPutByIdDirectNonStrictOptimize;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
