[webkit-changes] [264339] trunk/LayoutTests

Tue, 14 Jul 2020 08:34:41 -0700

Title: [264339] trunk/LayoutTests
Revision
264339
Author
clo...@igalia.com
Date
2020-07-14 08:32:51 -0700 (Tue, 14 Jul 2020)

Log Message

WPT test css/css-grid/grid-definition/grid-auto-fit-columns-001.html broken after r264335
https://bugs.webkit.org/show_bug.cgi?id=214301

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Import commit 4b5101fabe from WPT.

* web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt:
* web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html:

LayoutTests:

Remove platform-specific expectations not longer needed.

* platform/gtk/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.

Modified Paths

Removed Paths

  • trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-grid/
  • trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-grid/
  • trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-grid/

Diff

Modified: trunk/LayoutTests/ChangeLog (264338 => 264339)


--- trunk/LayoutTests/ChangeLog	2020-07-14 14:06:17 UTC (rev 264338)
+++ trunk/LayoutTests/ChangeLog	2020-07-14 15:32:51 UTC (rev 264339)
@@ -1,5 +1,18 @@
 2020-07-14  Carlos Alberto Lopez Perez  <clo...@igalia.com>
 
+        WPT test css/css-grid/grid-definition/grid-auto-fit-columns-001.html broken after r264335
+        https://bugs.webkit.org/show_bug.cgi?id=214301
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Remove platform-specific expectations not longer needed.
+
+        * platform/gtk/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
+        * platform/ios-wk2/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
+        * platform/wpe/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
+
+2020-07-14  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
         Update WPT tests for css-text
         https://bugs.webkit.org/show_bug.cgi?id=214275

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (264338 => 264339)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-07-14 14:06:17 UTC (rev 264338)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-07-14 15:32:51 UTC (rev 264339)
@@ -1,5 +1,17 @@
 2020-07-14  Carlos Alberto Lopez Perez  <clo...@igalia.com>
 
+        WPT test css/css-grid/grid-definition/grid-auto-fit-columns-001.html broken after r264335
+        https://bugs.webkit.org/show_bug.cgi?id=214301
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Import commit 4b5101fabe from WPT.
+
+        * web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt:
+        * web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html:
+
+2020-07-14  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
         Update WPT tests for css-text
         https://bugs.webkit.org/show_bug.cgi?id=214275

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt (264338 => 264339)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt	2020-07-14 14:06:17 UTC (rev 264338)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt	2020-07-14 15:32:51 UTC (rev 264339)
@@ -1,118 +1,47 @@
-Blocked access to external URL https://wpt.live/css/support/grid.css
-Blocked access to external URL https://wpt.live/resources/testharness.js
-Blocked access to external URL https://wpt.live/resources/testharnessreport.js
-Blocked access to external URL https://wpt.live/resources/check-layout-th.js
-CONSOLE MESSAGE: ReferenceError: Can't find variable: checkLayout
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x194
-  RenderBlock {HTML} at (0,0) size 800x194
-    RenderBody {BODY} at (8,16) size 784x170
-      RenderBlock {DIV} at (0,0) size 784x0
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 410x18
-          text run at (0,0) width 410: "This test checks that repeat(auto-fit, ) syntax works as expected."
-layer at (8,50) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,34) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,54) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,38) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,58) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,42) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,62) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,46) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,66) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,50) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,70) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,54) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,74) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,58) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,78) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,62) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,82) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,66) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,86) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,70) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,90) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,74) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,94) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,78) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,98) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,82) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,102) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,86) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,106) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,90) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,110) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,94) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,114) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,98) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,118) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,102) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,122) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,106) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,126) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,110) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,130) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,114) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,134) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,118) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,138) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,122) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,142) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,126) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,146) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,130) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,150) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,134) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,154) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,138) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,158) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,142) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,162) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,146) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,166) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,150) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,170) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,154) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#008000]
-layer at (8,174) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,158) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,178) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,162) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-layer at (8,182) size 204x4
-  RenderBlock (relative positioned) {DIV} at (0,166) size 204x4 [border: (2px solid #FF00FF)]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#00FFFF]
-    RenderBlock {DIV} at (2,2) size 200x0 [bgcolor=#008000]
+
+PASS .grid 1 
+PASS .grid 2 
+PASS .grid 3 
+FAIL .grid 4 assert_equals: 
+<div class="grid gridMaxMinAutoRepeat">
+    <div class="item" style="grid-column: 1 / -1" data-offset-x="0" data-offset-y="0" data-expected-width="180" data-expected-height="25"></div>
+</div>
+width expected 180 but got 450
+FAIL .grid 5 assert_equals: 
+<div class="grid gridMaxMinPercentAutoRepeat">
+    <div class="item" style="grid-column: 1 / -1" data-offset-x="0" data-offset-y="0" data-expected-width="180" data-expected-height="25"></div>
+</div>
+width expected 180 but got 450
+PASS .grid 6 
+PASS .grid 7 
+PASS .grid 8 
+PASS .grid 9 
+PASS .grid 10 
+PASS .grid 11 
+PASS .grid 12 
+PASS .grid 13 
+PASS .grid 14 
+PASS .grid 15 
+PASS .grid 16 
+PASS .grid 17 
+PASS .grid 18 
+PASS .grid 19 
+PASS .grid 20 
+PASS .grid 21 
+PASS .grid 22 
+PASS .grid 23 
+PASS .grid 24 
+PASS .grid 25 
+PASS .grid 26 
+PASS .grid 27 
+PASS .grid 28 
+PASS .grid 29 
+PASS .grid 30 
+PASS .grid 31 
+PASS .grid 32 
+PASS .grid 33 
+PASS .grid 34 
+PASS .grid 35 
+This test checks that repeat(auto-fit, ) syntax works as expected.
+
+

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html (264338 => 264339)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html	2020-07-14 14:06:17 UTC (rev 264338)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html	2020-07-14 15:32:51 UTC (rev 264339)
@@ -1,6 +1,5 @@
 <!DOCTYPE html>
 <title>CSS Grid: auto-fit columns</title>
-<base href=""
 
 <link rel="author" title="Sergio Villar" href="" svil...@igalia.com">
 <link rel="help" href=""
@@ -26,6 +25,7 @@
 }
 
 .gridOnlyAutoRepeat { grid-template-columns: repeat(auto-fit, 30px [autobar]); }
+.gridPercentAutoRepeat { grid-template-columns: repeat(auto-fit, 30% [autobar]); padding: 0 13px; }
 .gridMinMaxAutoRepeat { grid-template-columns: repeat(auto-fill, minmax(13px, 30px)); }
 .gridMaxMinAutoRepeat { grid-template-columns: repeat(auto-fill, minmax(30px, 13px)); }
 .gridMaxMinPercentAutoRepeat { grid-template-columns: repeat(auto-fill, minmax(30px, 6.5%)); }
@@ -56,6 +56,10 @@
     <div class="item" style="grid-column: 1 / -1" data-offset-x="0" data-offset-y="0" data-expected-width="180" data-expected-height="25"></div>
 </div>
 
+<div class="grid gridPercentAutoRepeat">
+    <div class="item" style="grid-column: 1 / -1" data-offset-x="13" data-offset-y="0" data-expected-width="180" data-expected-height="25"></div>
+</div>
+
 <div class="grid gridMinMaxAutoRepeat">
     <div class="item" style="grid-column: 1 / -1" data-offset-x="0" data-offset-y="0" data-expected-width="180" data-expected-height="25"></div>
 </div>

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to