Title: [264398] trunk/Tools
- Revision
- 264398
- Author
- aakash_j...@apple.com
- Date
- 2020-07-15 07:51:35 -0700 (Wed, 15 Jul 2020)
Log Message
Make ews django app robust against network issues
https://bugs.webkit.org/show_bug.cgi?id=214351
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/common/buildbot.py:
(Buildbot.fetch_pending_and_inprogress_builds): Re-fetch builder_name_to_id_mapping if required.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py (264397 => 264398)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py 2020-07-15 14:47:44 UTC (rev 264397)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py 2020-07-15 14:51:35 UTC (rev 264398)
@@ -117,8 +117,12 @@
@classmethod
def fetch_pending_and_inprogress_builds(cls, builder_full_name):
builderid = Buildbot.builder_name_to_id_mapping.get(builder_full_name)
+ if not Buildbot.builder_name_to_id_mapping:
+ _log.warn('Missing builder_name_to_id_mapping, refetching it from {}'.format(config.BUILDBOT_SERVER_HOST))
+ cls.update_builder_name_to_id_mapping()
+
if not builderid:
- _log.error('Invalid builder: {}'.format(builder_full_name))
+ _log.error('Invalid builder: {}. Number of builders: {}'.format(builder_full_name, len(cls.builder_name_to_id_mapping)))
return {}
url = ''.format(config.BUILDBOT_SERVER_HOST, builderid)
builders_data = util.fetch_data_from_url(url)
Modified: trunk/Tools/ChangeLog (264397 => 264398)
--- trunk/Tools/ChangeLog 2020-07-15 14:47:44 UTC (rev 264397)
+++ trunk/Tools/ChangeLog 2020-07-15 14:51:35 UTC (rev 264398)
@@ -1,3 +1,13 @@
+2020-07-15 Aakash Jain <aakash_j...@apple.com>
+
+ Make ews django app robust against network issues
+ https://bugs.webkit.org/show_bug.cgi?id=214351
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
+ (Buildbot.fetch_pending_and_inprogress_builds): Re-fetch builder_name_to_id_mapping if required.
+
2020-07-15 Jonathan Bedard <jbed...@apple.com>
[webkitpy] Support Rosetta testing
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
