Title: [264683] trunk/LayoutTests
Revision
264683
Author
bb...@apple.com
Date
2020-07-21 17:09:59 -0700 (Tue, 21 Jul 2020)

Log Message

Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=214619

Reviewed by Devin Rousso.

* inspector/canvas/memory-expected.txt:
* inspector/canvas/memory.html:
Canvas memory costs are not the same as on Intel macOS. Change the test to
simply check that the memory cost increases from zero-ish to not-zero.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (264682 => 264683)


--- trunk/LayoutTests/ChangeLog	2020-07-21 23:45:54 UTC (rev 264682)
+++ trunk/LayoutTests/ChangeLog	2020-07-22 00:09:59 UTC (rev 264683)
@@ -1,3 +1,15 @@
+2020-07-21  Brian Burg  <bb...@apple.com>
+
+        Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon
+        https://bugs.webkit.org/show_bug.cgi?id=214619
+
+        Reviewed by Devin Rousso.
+
+        * inspector/canvas/memory-expected.txt:
+        * inspector/canvas/memory.html:
+        Canvas memory costs are not the same as on Intel macOS. Change the test to
+        simply check that the memory cost increases from zero-ish to not-zero.
+
 2020-07-21  Yusuke Suzuki  <ysuz...@apple.com>
 
         Use CatchScope in microtask execution

Modified: trunk/LayoutTests/inspector/canvas/memory-expected.txt (264682 => 264683)


--- trunk/LayoutTests/inspector/canvas/memory-expected.txt	2020-07-21 23:45:54 UTC (rev 264682)
+++ trunk/LayoutTests/inspector/canvas/memory-expected.txt	2020-07-22 00:09:59 UTC (rev 264683)
@@ -7,5 +7,5 @@
 
 -- Running test case: Canvas.memory.canvasMemoryChanged
 Change size of canvas to 200x200.
-Memory cost of canvas updated to 166400.
+PASS: Memory cost should increase upon initially resizing canvas.
 

Modified: trunk/LayoutTests/inspector/canvas/memory.html (264682 => 264683)


--- trunk/LayoutTests/inspector/canvas/memory.html	2020-07-21 23:45:54 UTC (rev 264682)
+++ trunk/LayoutTests/inspector/canvas/memory.html	2020-07-22 00:09:59 UTC (rev 264683)
@@ -53,9 +53,10 @@
 
             InspectorTest.assert(canvases.length === 1, "There should only be one canvas-2d.");
 
+            let initialMemoryCost = canvases[0].memoryCost;
             canvases[0].awaitEvent(WI.Canvas.Event.MemoryChanged)
             .then((event) => {
-                InspectorTest.log(`Memory cost of canvas updated to ${event.target.memoryCost}.`);
+                InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas.");
             })
             .then(resolve, reject);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to