Title: [264870] trunk/Source/WebKit
- Revision
- 264870
- Author
- ryanhad...@apple.com
- Date
- 2020-07-24 16:42:52 -0700 (Fri, 24 Jul 2020)
Log Message
Unreviewed, reverting r264858.
Caused spurious CRASHING TEST logging during layout test runs
Reverted changeset:
"WebKit::setCrashReportApplicationSpecificInformation() should
also log to WTFLogAlways()"
https://bugs.webkit.org/show_bug.cgi?id=214756
https://trac.webkit.org/changeset/264858
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264869 => 264870)
--- trunk/Source/WebKit/ChangeLog 2020-07-24 23:40:41 UTC (rev 264869)
+++ trunk/Source/WebKit/ChangeLog 2020-07-24 23:42:52 UTC (rev 264870)
@@ -1,3 +1,16 @@
+2020-07-24 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, reverting r264858.
+
+ Caused spurious CRASHING TEST logging during layout test runs
+
+ Reverted changeset:
+
+ "WebKit::setCrashReportApplicationSpecificInformation() should
+ also log to WTFLogAlways()"
+ https://bugs.webkit.org/show_bug.cgi?id=214756
+ https://trac.webkit.org/changeset/264858
+
2020-07-24 Tadeu Zagallo <tzaga...@apple.com>
WKStringGetMaximumUTF8CStringSize should cast before arithmetic
Modified: trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm (264869 => 264870)
--- trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm 2020-07-24 23:40:41 UTC (rev 264869)
+++ trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm 2020-07-24 23:42:52 UTC (rev 264870)
@@ -33,9 +33,7 @@
void setCrashReportApplicationSpecificInformation(CFStringRef infoString)
{
- auto* cInfoString = [(__bridge NSString *)infoString UTF8String];
- WTFLogAlways("%s", cInfoString);
- WTF::setCrashLogMessage(cInfoString);
+ WTF::setCrashLogMessage([(__bridge NSString *)infoString UTF8String]);
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
