Title: [266267] trunk/Tools
Revision
266267
Author
clo...@igalia.com
Date
2020-08-27 19:00:34 -0700 (Thu, 27 Aug 2020)

Log Message

[webkitpy] repository svn version is incorrect when working on a branch
https://bugs.webkit.org/show_bug.cgi?id=215863

Reviewed by Jonathan Bedard.

When working on a SVN branch, the information pointed in the Revision field
doesn't reflect the last change on the branch, but the last change on trunk.
Instead of picking that changeset, pick the "Last Changed Rev" one that should
reflect the last change done in the current checkout (working directory).

* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.svn_revision):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (266266 => 266267)


--- trunk/Tools/ChangeLog	2020-08-28 01:24:15 UTC (rev 266266)
+++ trunk/Tools/ChangeLog	2020-08-28 02:00:34 UTC (rev 266267)
@@ -1,3 +1,18 @@
+2020-08-27  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [webkitpy] repository svn version is incorrect when working on a branch
+        https://bugs.webkit.org/show_bug.cgi?id=215863
+
+        Reviewed by Jonathan Bedard.
+
+        When working on a SVN branch, the information pointed in the Revision field
+        doesn't reflect the last change on the branch, but the last change on trunk.
+        Instead of picking that changeset, pick the "Last Changed Rev" one that should
+        reflect the last change done in the current checkout (working directory).
+
+        * Scripts/webkitpy/common/checkout/scm/svn.py:
+        (SVN.svn_revision):
+
 2020-08-27  Devin Rousso  <drou...@apple.com>
 
         [iOS] provide a way to get previously inserted alternatives for the selected text

Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py (266266 => 266267)


--- trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py	2020-08-28 01:24:15 UTC (rev 266266)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py	2020-08-28 02:00:34 UTC (rev 266267)
@@ -274,7 +274,7 @@
         return "svn"
 
     def svn_revision(self, path):
-        return self.value_from_svn_info(path, 'Revision')
+        return self.value_from_svn_info(path, 'Last Changed Rev')
 
     def svn_branch(self, path):
         relative_url = self.value_from_svn_info(path, 'Relative URL')[2:]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to