Title: [267577] trunk/Source/WebInspectorUI
- Revision
- 267577
- Author
- nvasil...@apple.com
- Date
- 2020-09-25 10:42:26 -0700 (Fri, 25 Sep 2020)
Log Message
Uncaught Exception: TypeError: null is not an object (evaluating 'this.listItemElement.classList')
https://bugs.webkit.org/show_bug.cgi?id=216307
<rdar://problem/68565824>
Reviewed by Brian Burg.
* UserInterface/Views/DOMTreeUpdater.js:
(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
Don't update the element if it hasn't been attached yet. It will use the latest data when attached.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (267576 => 267577)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-09-25 17:19:48 UTC (rev 267576)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-09-25 17:42:26 UTC (rev 267577)
@@ -1,3 +1,15 @@
+2020-09-25 Nikita Vasilyev <nvasil...@apple.com>
+
+ Uncaught Exception: TypeError: null is not an object (evaluating 'this.listItemElement.classList')
+ https://bugs.webkit.org/show_bug.cgi?id=216307
+ <rdar://problem/68565824>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/DOMTreeUpdater.js:
+ (WI.DOMTreeUpdater.prototype._updateModifiedNodes):
+ Don't update the element if it hasn't been attached yet. It will use the latest data when attached.
+
2020-09-24 Nikita Vasilyev <nvasil...@apple.com>
REGRESSION(r267379): Web Inspector: Sources navigation sidebar is empty every other time it's selected
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js (267576 => 267577)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js 2020-09-25 17:19:48 UTC (rev 267576)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js 2020-09-25 17:42:26 UTC (rev 267577)
@@ -124,7 +124,7 @@
this._recentlyDeletedNodes.forEach(markNodeParentForUpdate);
for (let parentTreeElement of parentElementsToUpdate) {
- if (parentTreeElement.treeOutline) {
+ if (parentTreeElement.treeOutline && parentTreeElement.listItemElement) {
parentTreeElement.updateTitle();
parentTreeElement.updateChildren();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
