Title: [268982] trunk/Source/WebInspectorUI
- Revision
- 268982
- Author
- commit-qu...@webkit.org
- Date
- 2020-10-26 10:27:47 -0700 (Mon, 26 Oct 2020)
Log Message
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._boxModelDiagramRow.minimumWidth')
https://bugs.webkit.org/show_bug.cgi?id=218135
Patch by Patrick Angle <pan...@apple.com> on 2020-10-26
Reviewed by Brian Burg.
minimumWidth may be retrieved before the ComputedStylesDetailsPanel has done its initial layout, which means the
_boxModelDiagramRow will not have been initialized. In this case, we want to return 0 causing the absolute
minimum width of a sidebar to be used for calculations instead.
* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.get minimumWidth):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (268981 => 268982)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-10-26 17:25:23 UTC (rev 268981)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-10-26 17:27:47 UTC (rev 268982)
@@ -1,5 +1,19 @@
2020-10-26 Patrick Angle <pan...@apple.com>
+ Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._boxModelDiagramRow.minimumWidth')
+ https://bugs.webkit.org/show_bug.cgi?id=218135
+
+ Reviewed by Brian Burg.
+
+ minimumWidth may be retrieved before the ComputedStylesDetailsPanel has done its initial layout, which means the
+ _boxModelDiagramRow will not have been initialized. In this case, we want to return 0 causing the absolute
+ minimum width of a sidebar to be used for calculations instead.
+
+ * UserInterface/Views/ComputedStyleDetailsPanel.js:
+ (WI.ComputedStyleDetailsPanel.prototype.get minimumWidth):
+
+2020-10-26 Patrick Angle <pan...@apple.com>
+
Web Inspector: Change minimum width of #tab-browser to a more reasonable value
https://bugs.webkit.org/show_bug.cgi?id=217998
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js (268981 => 268982)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2020-10-26 17:25:23 UTC (rev 268981)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2020-10-26 17:27:47 UTC (rev 268982)
@@ -39,7 +39,7 @@
get minimumWidth()
{
- return this._boxModelDiagramRow.minimumWidth;
+ return this._boxModelDiagramRow?.minimumWidth ?? 0;
}
refresh(significantChange)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
