Title: [271736] trunk/LayoutTests
- Revision
- 271736
- Author
- timothy_hor...@apple.com
- Date
- 2021-01-21 22:08:18 -0800 (Thu, 21 Jan 2021)
Log Message
REGRESSION (r271472): [ Mac WK2 ] intersection-observer/target-deleted.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=220637
<rdar://problem/73220571>
Reviewed by Simon Fraser.
* intersection-observer/target-deleted.html:
For some reason, on some configurations, this test recently stopped seeing its
intersection observer get garbage collected when it expects. The regression
point is likely irrelevant, though multiple bots agree.
Doing a full rendering update by using rAF instead of just a setInterval
seems to be enough to get the object to actually be collected promptly.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (271735 => 271736)
--- trunk/LayoutTests/ChangeLog 2021-01-22 03:50:35 UTC (rev 271735)
+++ trunk/LayoutTests/ChangeLog 2021-01-22 06:08:18 UTC (rev 271736)
@@ -1,3 +1,19 @@
+2021-01-21 Tim Horton <timothy_hor...@apple.com>
+
+ REGRESSION (r271472): [ Mac WK2 ] intersection-observer/target-deleted.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=220637
+ <rdar://problem/73220571>
+
+ Reviewed by Simon Fraser.
+
+ * intersection-observer/target-deleted.html:
+ For some reason, on some configurations, this test recently stopped seeing its
+ intersection observer get garbage collected when it expects. The regression
+ point is likely irrelevant, though multiple bots agree.
+
+ Doing a full rendering update by using rAF instead of just a setInterval
+ seems to be enough to get the object to actually be collected promptly.
+
2021-01-21 Devin Rousso <drou...@apple.com>
[Apple Pay] use the first item in `shippingOptions` even when it's not `selected`
Modified: trunk/LayoutTests/intersection-observer/target-deleted.html (271735 => 271736)
--- trunk/LayoutTests/intersection-observer/target-deleted.html 2021-01-22 03:50:35 UTC (rev 271735)
+++ trunk/LayoutTests/intersection-observer/target-deleted.html 2021-01-22 06:08:18 UTC (rev 271736)
@@ -11,13 +11,15 @@
function observerShouldBeRemoved()
{
return new Promise(function(resolve) {
- handle = setInterval(function() {
+ function testIfRemoved() {
gc();
- if (internals && internals.numberOfIntersectionObservers(document) == 0) {
- clearInterval(handle);
+ if (internals && internals.numberOfIntersectionObservers(document) == 0)
resolve();
- }
- }, 10);
+ else
+ requestAnimationFrame(testIfRemoved);
+ }
+
+ testIfRemoved();
});
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
