Modified: trunk/Source/WebKit/ChangeLog (271752 => 271753)
--- trunk/Source/WebKit/ChangeLog 2021-01-22 19:11:55 UTC (rev 271752)
+++ trunk/Source/WebKit/ChangeLog 2021-01-22 19:53:55 UTC (rev 271753)
@@ -1,3 +1,16 @@
+2021-01-22 Jiewen Tan <jiewen_...@apple.com>
+
+ [WebAuthn] Should only check default browsers for the Modern WebAuthn
+ https://bugs.webkit.org/show_bug.cgi?id=220840
+ <rdar://problem/73375937>
+
+ Reviewed by Brent Fulgham.
+
+ * WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:
+ (WebKit::WebAuthenticatorCoordinator::makeCredential):
+ (WebKit::WebAuthenticatorCoordinator::getAssertion):
+ (WebKit::WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable):
+
2021-01-21 Peng Liu <peng.l...@apple.com>
PiP video subtitles stop updating when Safari is backgrounded
Modified: trunk/Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp (271752 => 271753)
--- trunk/Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp 2021-01-22 19:11:55 UTC (rev 271752)
+++ trunk/Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp 2021-01-22 19:53:55 UTC (rev 271753)
@@ -72,13 +72,12 @@
m_webPage.addConsoleMessage(webFrame->frameID(), MessageSource::Other, MessageLevel::Warning, "User gesture is not detected. To use the platform authenticator, call 'navigator.credentials.create' within user activated events."_s);
if (!RuntimeEnabledFeatures::sharedFeatures().webAuthenticationModernEnabled()) {
- if (!isWebBrowser())
- return;
-
m_webPage.sendWithAsyncReply(Messages::WebAuthenticatorCoordinatorProxy::MakeCredential(webFrame->frameID(), webFrame->info(), hash, options, processingUserGesture), WTFMove(handler));
return;
}
+ if (!isWebBrowser())
+ return;
WebProcess::singleton().ensureWebAuthnProcessConnection().connection().sendWithAsyncReply(Messages::WebAuthnConnectionToWebProcess::MakeCredential(hash, options, processingUserGesture), WTFMove(handler));
}
@@ -93,13 +92,12 @@
m_webPage.addConsoleMessage(webFrame->frameID(), MessageSource::Other, MessageLevel::Warning, "User gesture is not detected. To use the platform authenticator, call 'navigator.credentials.get' within user activated events."_s);
if (!RuntimeEnabledFeatures::sharedFeatures().webAuthenticationModernEnabled()) {
- if (!isWebBrowser())
- return;
-
m_webPage.sendWithAsyncReply(Messages::WebAuthenticatorCoordinatorProxy::GetAssertion(webFrame->frameID(), webFrame->info(), hash, options, processingUserGesture), WTFMove(handler));
return;
}
+ if (!isWebBrowser())
+ return;
WebProcess::singleton().ensureWebAuthnProcessConnection().connection().sendWithAsyncReply(Messages::WebAuthnConnectionToWebProcess::GetAssertion(hash, options, processingUserGesture), WTFMove(handler));
}
@@ -106,13 +104,12 @@
void WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable(QueryCompletionHandler&& handler)
{
if (!RuntimeEnabledFeatures::sharedFeatures().webAuthenticationModernEnabled()) {
- if (!isWebBrowser())
- return;
-
m_webPage.sendWithAsyncReply(Messages::WebAuthenticatorCoordinatorProxy::IsUserVerifyingPlatformAuthenticatorAvailable(), WTFMove(handler));
return;
}
+ if (!isWebBrowser())
+ return;
WebProcess::singleton().ensureWebAuthnProcessConnection().connection().sendWithAsyncReply(Messages::WebAuthnConnectionToWebProcess::IsUserVerifyingPlatformAuthenticatorAvailable(), WTFMove(handler));
}
