Title: [276926] trunk/Source/WebCore
- Revision
- 276926
- Author
- akeer...@apple.com
- Date
- 2021-05-03 14:37:10 -0700 (Mon, 03 May 2021)
Log Message
[iOS][FCR] Missing fill color on slider ticks
https://bugs.webkit.org/show_bug.cgi?id=225318
<rdar://problem/77100313>
Reviewed by Wenson Hsieh.
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintSliderTicks):
Slider ticks should fill in blue as the knob passes them.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (276925 => 276926)
--- trunk/Source/WebCore/ChangeLog 2021-05-03 21:24:44 UTC (rev 276925)
+++ trunk/Source/WebCore/ChangeLog 2021-05-03 21:37:10 UTC (rev 276926)
@@ -1,3 +1,16 @@
+2021-05-03 Aditya Keerthi <akeer...@apple.com>
+
+ [iOS][FCR] Missing fill color on slider ticks
+ https://bugs.webkit.org/show_bug.cgi?id=225318
+ <rdar://problem/77100313>
+
+ Reviewed by Wenson Hsieh.
+
+ * rendering/RenderThemeIOS.mm:
+ (WebCore::RenderThemeIOS::paintSliderTicks):
+
+ Slider ticks should fill in blue as the knob passes them.
+
2021-05-03 Sihui Liu <sihui_...@apple.com>
Unreviewed, reverting r276913.
Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (276925 => 276926)
--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2021-05-03 21:24:44 UTC (rev 276925)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2021-05-03 21:37:10 UTC (rev 276926)
@@ -2339,11 +2339,11 @@
tickRect.setX(rect.center().x() - tickRect.width() / 2.0f);
}
- auto deviceScaleFactor = box.document().deviceScaleFactor();
-
auto& context = paintInfo.context();
GraphicsContextStateSaver stateSaver(context);
+ auto value = input.valueAsNumber();
+ auto deviceScaleFactor = box.document().deviceScaleFactor();
auto styleColorOptions = box.styleColorOptions();
for (auto& optionElement : dataList->suggestions()) {
@@ -2356,7 +2356,7 @@
tickRect.setY(rect.y() + tickRatio * (rect.height() - tickRect.height()));
FloatRoundedRect roundedTickRect(snapRectToDevicePixels(LayoutRect(tickRect), deviceScaleFactor), tickCornerRadii);
- context.fillRoundedRect(roundedTickRect, systemColor(CSSValueAppleSystemOpaqueSeparator, styleColorOptions));
+ context.fillRoundedRect(roundedTickRect, systemColor((value >= *optionValue) ? CSSValueAppleSystemBlue : CSSValueAppleSystemOpaqueSeparator, styleColorOptions));
}
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
