Title: [277464] trunk/Source
- Revision
- 277464
- Author
- timothy_hor...@apple.com
- Date
- 2021-05-13 16:27:20 -0700 (Thu, 13 May 2021)
Log Message
Work around WebCore failing to build due to NDEBUG getting undefined in release
https://bugs.webkit.org/show_bug.cgi?id=225782
<rdar://problem/77982432>
Reviewed by Simon Fraser.
Source/WebCore/PAL:
* pal/spi/cg/CoreGraphicsSPI.h:
* pal/spi/ios/GraphicsServicesSPI.h:
Apply a temporary workaround to preserve NDEBUG through these includes.
There are a few ways to get to CoreGraphicsPrivate.h, so we fix all of them.
Source/WebKit:
* Platform/spi/ios/UIKitSPI.h:
Apply a temporary workaround to preserve NDEBUG through these includes.
There are a few ways to get to CoreGraphicsPrivate.h, so we fix all of them.
Modified Paths
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (277463 => 277464)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-05-13 23:20:07 UTC (rev 277463)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-05-13 23:27:20 UTC (rev 277464)
@@ -1,3 +1,16 @@
+2021-05-13 Tim Horton <timothy_hor...@apple.com>
+
+ Work around WebCore failing to build due to NDEBUG getting undefined in release
+ https://bugs.webkit.org/show_bug.cgi?id=225782
+ <rdar://problem/77982432>
+
+ Reviewed by Simon Fraser.
+
+ * pal/spi/cg/CoreGraphicsSPI.h:
+ * pal/spi/ios/GraphicsServicesSPI.h:
+ Apply a temporary workaround to preserve NDEBUG through these includes.
+ There are a few ways to get to CoreGraphicsPrivate.h, so we fix all of them.
+
2021-05-13 Aditya Keerthi <akeer...@apple.com>
REGRESSION (r276945): [iOS] Focus rings are too large
Modified: trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h (277463 => 277464)
--- trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h 2021-05-13 23:20:07 UTC (rev 277463)
+++ trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h 2021-05-13 23:27:20 UTC (rev 277464)
@@ -38,6 +38,11 @@
#if USE(APPLE_INTERNAL_SDK)
+// FIXME (77983361): Remove this workaround when <rdar://problem/77977216> is fixed.
+#if defined(NDEBUG) && NDEBUG
+#define WK_NDEBUG 1
+#endif
+
#include <CoreGraphics/CGContextDelegatePrivate.h>
#include <CoreGraphics/CGFontCache.h>
#include <CoreGraphics/CGPathPrivate.h>
@@ -44,6 +49,11 @@
#include <CoreGraphics/CoreGraphicsPrivate.h>
#include <CoreGraphics/CGStylePrivate.h>
+#if defined(WK_NDEBUG) && !defined(NDEBUG)
+#define NDEBUG 1
+#undef WK_NDEBUG
+#endif
+
#if PLATFORM(MAC)
#include <ColorSync/ColorSyncPriv.h>
#include <CoreGraphics/CGAccessibility.h>
Modified: trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h (277463 => 277464)
--- trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h 2021-05-13 23:20:07 UTC (rev 277463)
+++ trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h 2021-05-13 23:27:20 UTC (rev 277464)
@@ -31,10 +31,20 @@
#if USE(APPLE_INTERNAL_SDK)
+// FIXME (77983361): Remove this workaround when <rdar://problem/77977216> is fixed.
+#if defined(NDEBUG) && NDEBUG
+#define WK_NDEBUG 1
+#endif
+
#import <GraphicsServices/GraphicsServices.h>
+#if defined(WK_NDEBUG) && !defined(NDEBUG)
+#define NDEBUG 1
+#undef WK_NDEBUG
#endif
+#endif
+
WTF_EXTERN_C_BEGIN
void GSInitialize(void);
Modified: trunk/Source/WebKit/ChangeLog (277463 => 277464)
--- trunk/Source/WebKit/ChangeLog 2021-05-13 23:20:07 UTC (rev 277463)
+++ trunk/Source/WebKit/ChangeLog 2021-05-13 23:27:20 UTC (rev 277464)
@@ -1,3 +1,15 @@
+2021-05-13 Tim Horton <timothy_hor...@apple.com>
+
+ Work around WebCore failing to build due to NDEBUG getting undefined in release
+ https://bugs.webkit.org/show_bug.cgi?id=225782
+ <rdar://problem/77982432>
+
+ Reviewed by Simon Fraser.
+
+ * Platform/spi/ios/UIKitSPI.h:
+ Apply a temporary workaround to preserve NDEBUG through these includes.
+ There are a few ways to get to CoreGraphicsPrivate.h, so we fix all of them.
+
2021-05-13 Megan Gardner <megan_gard...@apple.com>
Add textIndicator bounce for AppHighlights on scroll.
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (277463 => 277464)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2021-05-13 23:20:07 UTC (rev 277463)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2021-05-13 23:27:20 UTC (rev 277464)
@@ -27,6 +27,11 @@
#if USE(APPLE_INTERNAL_SDK)
+// FIXME (77983361): Remove this workaround when <rdar://problem/77977216> is fixed.
+#if defined(NDEBUG) && NDEBUG
+#define WK_NDEBUG 1
+#endif
+
#import <UIKit/NSTextAlternatives.h>
#import <UIKit/UIAlertController_Private.h>
#import <UIKit/UIApplication_Private.h>
@@ -135,6 +140,11 @@
#import <UIKit/UIPointerStyle_Private.h>
#endif
+#if defined(WK_NDEBUG) && !defined(NDEBUG)
+#define NDEBUG 1
+#undef WK_NDEBUG
+#endif
+
#else // USE(APPLE_INTERNAL_SDK)
#if ENABLE(DRAG_SUPPORT)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
