Title: [277710] trunk/Source/WebKit
- Revision
- 277710
- Author
- timothy_hor...@apple.com
- Date
- 2021-05-18 18:57:25 -0700 (Tue, 18 May 2021)
Log Message
REGRESSION (r277683): WebContent process crashing in unit tests
https://bugs.webkit.org/show_bug.cgi?id=225955
rdar://78184041
Unreviewed partial revert.
* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
Revert the CRASH() part of r277683 because it is causing mysterious unit testing failures.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (277709 => 277710)
--- trunk/Source/WebKit/ChangeLog 2021-05-19 01:51:47 UTC (rev 277709)
+++ trunk/Source/WebKit/ChangeLog 2021-05-19 01:57:25 UTC (rev 277710)
@@ -1,3 +1,15 @@
+2021-05-18 Tim Horton <timothy_hor...@apple.com>
+
+ REGRESSION (r277683): WebContent process crashing in unit tests
+ https://bugs.webkit.org/show_bug.cgi?id=225955
+ rdar://78184041
+
+ Unreviewed partial revert.
+
+ * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
+ (WebKit::XPCServiceInitializer):
+ Revert the CRASH() part of r277683 because it is causing mysterious unit testing failures.
+
2021-05-18 Aditya Keerthi <akeer...@apple.com>
[macOS] Titlebar separator doesn't show when WKWebView is scrolled
Modified: trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h (277709 => 277710)
--- trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h 2021-05-19 01:51:47 UTC (rev 277709)
+++ trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h 2021-05-19 01:57:25 UTC (rev 277710)
@@ -106,7 +106,7 @@
InitializeWebKit2();
if (!delegate.checkEntitlements())
- CRASH();
+ exit(EXIT_FAILURE);
AuxiliaryProcessInitializationParameters parameters;
if (priorityBoostMessage)
@@ -113,27 +113,27 @@
parameters.priorityBoostMessage = priorityBoostMessage;
if (!delegate.getConnectionIdentifier(parameters.connectionIdentifier))
- CRASH();
+ exit(EXIT_FAILURE);
if (!delegate.getClientIdentifier(parameters.clientIdentifier))
- CRASH();
+ exit(EXIT_FAILURE);
// The host process may not have a bundle identifier (e.g. a command line app), so don't require one.
delegate.getClientBundleIdentifier(parameters.clientBundleIdentifier);
if (!delegate.getClientSDKVersion(parameters.clientSDKVersion))
- CRASH();
+ exit(EXIT_FAILURE);
WebCore::ProcessIdentifier processIdentifier;
if (!delegate.getProcessIdentifier(processIdentifier))
- CRASH();
+ exit(EXIT_FAILURE);
parameters.processIdentifier = processIdentifier;
if (!delegate.getClientProcessName(parameters.uiProcessName))
- CRASH();
+ exit(EXIT_FAILURE);
if (!delegate.getExtraInitializationData(parameters.extraInitializationData))
- CRASH();
+ exit(EXIT_FAILURE);
// Set the task default voucher to the current value (as propagated by XPC).
voucher_replace_default_voucher();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
