Title: [280610] trunk/LayoutTests
Revision
280610
Author
timothy_hor...@apple.com
Date
2021-08-03 13:29:28 -0700 (Tue, 03 Aug 2021)

Log Message

fast/dom/navigator-iOS-userAgent.html fails on iPad because the platform is not "iPhone" or "iPad"
https://bugs.webkit.org/show_bug.cgi?id=228750

Reviewed by Dean Jackson.

* fast/dom/navigator-iOS-userAgent.html:
* platform/ipad/fast/dom/navigator-iOS-userAgent-expected.txt: Removed.
This test fails on iPad in the default configuration because navigator.platform is MacIntel
due to desktop-class browsing. To maintain previous behavior of the test, revert to mobile mode.
This lets us delete the iPad-specific results.
Also, fix a typo in the variable names.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (280609 => 280610)


--- trunk/LayoutTests/ChangeLog	2021-08-03 20:26:54 UTC (rev 280609)
+++ trunk/LayoutTests/ChangeLog	2021-08-03 20:29:28 UTC (rev 280610)
@@ -1,5 +1,19 @@
 2021-08-03  Tim Horton  <timothy_hor...@apple.com>
 
+        fast/dom/navigator-iOS-userAgent.html fails on iPad because the platform is not "iPhone" or "iPad"
+        https://bugs.webkit.org/show_bug.cgi?id=228750
+
+        Reviewed by Dean Jackson.
+
+        * fast/dom/navigator-iOS-userAgent.html:
+        * platform/ipad/fast/dom/navigator-iOS-userAgent-expected.txt: Removed.
+        This test fails on iPad in the default configuration because navigator.platform is MacIntel
+        due to desktop-class browsing. To maintain previous behavior of the test, revert to mobile mode.
+        This lets us delete the iPad-specific results.
+        Also, fix a typo in the variable names.
+
+2021-08-03  Tim Horton  <timothy_hor...@apple.com>
+
         [ iPad ] fast/dom/collection-iterators.html fails
         https://bugs.webkit.org/show_bug.cgi?id=228657
 

Modified: trunk/LayoutTests/fast/dom/navigator-iOS-userAgent.html (280609 => 280610)


--- trunk/LayoutTests/fast/dom/navigator-iOS-userAgent.html	2021-08-03 20:26:54 UTC (rev 280609)
+++ trunk/LayoutTests/fast/dom/navigator-iOS-userAgent.html	2021-08-03 20:29:28 UTC (rev 280610)
@@ -1,4 +1,4 @@
-<html>
+<html><!-- webkit-test-runner [ contentMode=mobile ] -->
 <head>
 <script src=""
 </head>
@@ -9,8 +9,8 @@
 description("Verify the user-agent string does not have the 'Simulator' device name.");
 
 var userAgent = navigator.userAgent;
-var isIPadUserAgent = userAgent.indexOf("Mozilla/5.0 (iPhone;") == 0;
-var isIPhoneUserAgent = userAgent.indexOf("Mozilla/5.0 (iPad;") == 0;
+var isIPadUserAgent = userAgent.indexOf("Mozilla/5.0 (iPad;") == 0;
+var isIPhoneUserAgent = userAgent.indexOf("Mozilla/5.0 (iPhone;") == 0;
 
 function test(str, condition) {
     var func = condition ? testPassed : testFailed;

Deleted: trunk/LayoutTests/platform/ipad/fast/dom/navigator-iOS-userAgent-expected.txt (280609 => 280610)


--- trunk/LayoutTests/platform/ipad/fast/dom/navigator-iOS-userAgent-expected.txt	2021-08-03 20:26:54 UTC (rev 280609)
+++ trunk/LayoutTests/platform/ipad/fast/dom/navigator-iOS-userAgent-expected.txt	2021-08-03 20:29:28 UTC (rev 280610)
@@ -1,11 +0,0 @@
-Verify the user-agent string does not have the 'Simulator' device name.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-FAIL User agent platform should be "iPhone" or "iPad".
-PASS User agent does not contain "Simulator".
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to