Title: [285154] trunk/Source/_javascript_Core
- Revision
- 285154
- Author
- mark....@apple.com
- Date
- 2021-11-01 23:56:01 -0700 (Mon, 01 Nov 2021)
Log Message
Remove some unused Heap fields.
https://bugs.webkit.org/show_bug.cgi?id=232604
Reviewed by Yusuke Suzuki.
* heap/Heap.cpp:
(JSC::Heap::notifyThreadStopping):
* heap/Heap.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (285153 => 285154)
--- trunk/Source/_javascript_Core/ChangeLog 2021-11-02 04:55:23 UTC (rev 285153)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-11-02 06:56:01 UTC (rev 285154)
@@ -1,3 +1,14 @@
+2021-11-01 Mark Lam <mark....@apple.com>
+
+ Remove some unused Heap fields.
+ https://bugs.webkit.org/show_bug.cgi?id=232604
+
+ Reviewed by Yusuke Suzuki.
+
+ * heap/Heap.cpp:
+ (JSC::Heap::notifyThreadStopping):
+ * heap/Heap.h:
+
2021-11-01 Ross Kirsling <ross.kirsl...@sony.com>
[JSC][LLInt] Non-commutative binops are hard to reason about when operands are labelled in reverse
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (285153 => 285154)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2021-11-02 04:55:23 UTC (rev 285153)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2021-11-02 06:56:01 UTC (rev 285154)
@@ -2042,7 +2042,6 @@
void Heap::notifyThreadStopping(const AbstractLocker&)
{
- m_threadIsStopping = true;
clearMutatorWaiting();
ParkingLot::unparkAll(&m_worldState);
}
Modified: trunk/Source/_javascript_Core/heap/Heap.h (285153 => 285154)
--- trunk/Source/_javascript_Core/heap/Heap.h 2021-11-02 04:55:23 UTC (rev 285153)
+++ trunk/Source/_javascript_Core/heap/Heap.h 2021-11-02 06:56:01 UTC (rev 285154)
@@ -709,7 +709,6 @@
static constexpr unsigned mutatorWaitingBit = 1u << 4u; // Allows the mutator to use this as a condition variable.
Atomic<unsigned> m_worldState;
bool m_worldIsStopped { false };
- Lock m_visitRaceLock;
Lock m_markingMutex;
Condition m_markingConditionVariable;
@@ -727,7 +726,6 @@
CollectorPhase m_nextPhase { CollectorPhase::NotRunning };
bool m_collectorThreadIsRunning { false };
bool m_threadShouldStop { false };
- bool m_threadIsStopping { false };
bool m_mutatorDidRun { true };
bool m_didDeferGCWork { false };
bool m_shouldStopCollectingContinuously { false };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
