Title: [285164] trunk/Source
- Revision
- 285164
- Author
- pan...@apple.com
- Date
- 2021-11-02 10:01:52 -0700 (Tue, 02 Nov 2021)
Log Message
WebDriver: [Cocoa] support `acceptInsecureCerts` capability
https://bugs.webkit.org/show_bug.cgi?id=231789
Reviewed by BJ Burg.
Add necessary plumbing to support the `acceptInsecureCerts` WebDriver capability.
Source/_javascript_Core:
* inspector/remote/RemoteInspectorConstants.h:
* inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::receivedAutomationSessionRequestMessage):
Source/WebKit:
* UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h:
* UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.mm:
(-[_WKAutomationSessionConfiguration init]):
(-[_WKAutomationSessionConfiguration copyWithZone:]):
* UIProcess/Cocoa/AutomationClient.mm:
(WebKit::AutomationClient::requestAutomationSession):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (285163 => 285164)
--- trunk/Source/_javascript_Core/ChangeLog 2021-11-02 16:37:09 UTC (rev 285163)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-11-02 17:01:52 UTC (rev 285164)
@@ -1,3 +1,16 @@
+2021-11-02 Patrick Angle <pan...@apple.com>
+
+ WebDriver: [Cocoa] support `acceptInsecureCerts` capability
+ https://bugs.webkit.org/show_bug.cgi?id=231789
+
+ Reviewed by BJ Burg.
+
+ Add necessary plumbing to support the `acceptInsecureCerts` WebDriver capability.
+
+ * inspector/remote/RemoteInspectorConstants.h:
+ * inspector/remote/cocoa/RemoteInspectorCocoa.mm:
+ (Inspector::RemoteInspector::receivedAutomationSessionRequestMessage):
+
2021-11-01 Mark Lam <mark....@apple.com>
Remove some unused Heap fields.
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspectorConstants.h (285163 => 285164)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspectorConstants.h 2021-11-02 16:37:09 UTC (rev 285163)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspectorConstants.h 2021-11-02 17:01:52 UTC (rev 285164)
@@ -103,6 +103,7 @@
// The value for WIRSessionCapabilitiesKey is a dictionary that holds these capability key-value pairs.
+#define WIRAcceptInsecureCertificatesKey @"org.webkit.webdriver.accept-insecure-certificates"
#define WIRAllowInsecureMediaCaptureCapabilityKey @"org.webkit.webdriver.webrtc.allow-insecure-media-capture"
#define WIRSuppressICECandidateFilteringCapabilityKey @"org.webkit.webdriver.webrtc.suppress-ice-candidate-filtering"
Modified: trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm (285163 => 285164)
--- trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm 2021-11-02 16:37:09 UTC (rev 285163)
+++ trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm 2021-11-02 17:01:52 UTC (rev 285164)
@@ -729,6 +729,11 @@
BAIL_IF_UNEXPECTED_TYPE_ALLOWING_NIL(forwardedCapabilities, [NSDictionary class]);
Client::SessionCapabilities sessionCapabilities;
+ if (NSNumber *value = forwardedCapabilities[WIRAcceptInsecureCertificatesKey]) {
+ if ([value isKindOfClass:[NSNumber class]])
+ sessionCapabilities.acceptInsecureCertificates = value.boolValue;
+ }
+
if (NSNumber *value = forwardedCapabilities[WIRAllowInsecureMediaCaptureCapabilityKey]) {
if ([value isKindOfClass:[NSNumber class]])
sessionCapabilities.allowInsecureMediaCapture = value.boolValue;
Modified: trunk/Source/WebKit/ChangeLog (285163 => 285164)
--- trunk/Source/WebKit/ChangeLog 2021-11-02 16:37:09 UTC (rev 285163)
+++ trunk/Source/WebKit/ChangeLog 2021-11-02 17:01:52 UTC (rev 285164)
@@ -1,3 +1,19 @@
+2021-11-02 Patrick Angle <pan...@apple.com>
+
+ WebDriver: [Cocoa] support `acceptInsecureCerts` capability
+ https://bugs.webkit.org/show_bug.cgi?id=231789
+
+ Reviewed by BJ Burg.
+
+ Add necessary plumbing to support the `acceptInsecureCerts` WebDriver capability.
+
+ * UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h:
+ * UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.mm:
+ (-[_WKAutomationSessionConfiguration init]):
+ (-[_WKAutomationSessionConfiguration copyWithZone:]):
+ * UIProcess/Cocoa/AutomationClient.mm:
+ (WebKit::AutomationClient::requestAutomationSession):
+
2021-11-02 Kate Cheney <katherine_che...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=232593
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h (285163 => 285164)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h 2021-11-02 16:37:09 UTC (rev 285163)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h 2021-11-02 17:01:52 UTC (rev 285164)
@@ -32,6 +32,7 @@
WK_CLASS_AVAILABLE(macos(10.13.4), ios(12.2))
@interface _WKAutomationSessionConfiguration : NSObject <NSCopying>
+@property (nonatomic) BOOL acceptInsecureCertificates;
@property (nonatomic) BOOL allowsInsecureMediaCapture;
@property (nonatomic) BOOL suppressesICECandidateFiltering;
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.mm (285163 => 285164)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.mm 2021-11-02 16:37:09 UTC (rev 285163)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.mm 2021-11-02 17:01:52 UTC (rev 285164)
@@ -33,6 +33,7 @@
if (!(self = [super init]))
return nil;
+ _acceptInsecureCertificates = NO;
_allowsInsecureMediaCapture = YES;
_suppressesICECandidateFiltering = NO;
@@ -43,6 +44,7 @@
{
_WKAutomationSessionConfiguration *configuration = [(_WKAutomationSessionConfiguration *)[[self class] allocWithZone:zone] init];
+ configuration.acceptInsecureCertificates = self.acceptInsecureCertificates;
configuration.allowsInsecureMediaCapture = self.allowsInsecureMediaCapture;
configuration.suppressesICECandidateFiltering = self.suppressesICECandidateFiltering;
Modified: trunk/Source/WebKit/UIProcess/Cocoa/AutomationClient.mm (285163 => 285164)
--- trunk/Source/WebKit/UIProcess/Cocoa/AutomationClient.mm 2021-11-02 16:37:09 UTC (rev 285163)
+++ trunk/Source/WebKit/UIProcess/Cocoa/AutomationClient.mm 2021-11-02 17:01:52 UTC (rev 285164)
@@ -78,6 +78,8 @@
void AutomationClient::requestAutomationSession(const String& sessionIdentifier, const RemoteInspector::Client::SessionCapabilities& sessionCapabilities)
{
auto configuration = adoptNS([[_WKAutomationSessionConfiguration alloc] init]);
+ [configuration setAcceptInsecureCertificates:sessionCapabilities.acceptInsecureCertificates];
+
if (sessionCapabilities.allowInsecureMediaCapture)
[configuration setAllowsInsecureMediaCapture:sessionCapabilities.allowInsecureMediaCapture.value()];
if (sessionCapabilities.suppressICECandidateFiltering)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
