Title: [286432] trunk/Source/WebKit
- Revision
- 286432
- Author
- you...@apple.com
- Date
- 2021-12-02 08:44:31 -0800 (Thu, 02 Dec 2021)
Log Message
Add some logging to NetworkRTCProvider
https://bugs.webkit.org/show_bug.cgi?id=233759
Reviewed by Eric Carlson.
No change of behavior.
* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::addSocket):
* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
(WebKit::NetworkRTCUDPSocketCocoaConnections::NetworkRTCUDPSocketCocoaConnections):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (286431 => 286432)
--- trunk/Source/WebKit/ChangeLog 2021-12-02 16:33:01 UTC (rev 286431)
+++ trunk/Source/WebKit/ChangeLog 2021-12-02 16:44:31 UTC (rev 286432)
@@ -1,3 +1,17 @@
+2021-12-02 Youenn Fablet <you...@apple.com>
+
+ Add some logging to NetworkRTCProvider
+ https://bugs.webkit.org/show_bug.cgi?id=233759
+
+ Reviewed by Eric Carlson.
+
+ No change of behavior.
+
+ * NetworkProcess/webrtc/NetworkRTCProvider.cpp:
+ (WebKit::NetworkRTCProvider::addSocket):
+ * NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
+ (WebKit::NetworkRTCUDPSocketCocoaConnections::NetworkRTCUDPSocketCocoaConnections):
+
2021-12-02 Per Arne Vollan <pvol...@apple.com>
REGRESSION(r285722): Introduced performance regression
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp (286431 => 286432)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2021-12-02 16:33:01 UTC (rev 286431)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2021-12-02 16:44:31 UTC (rev 286432)
@@ -288,8 +288,11 @@
ASSERT(m_rtcNetworkThread.IsCurrent());
ASSERT(socket);
m_sockets.emplace(identifier, WTFMove(socket));
+
+ RTC_RELEASE_LOG("new socket %" PRIu64 ", total socket number is %lu", identifier.toUInt64(), m_sockets.size());
if (m_sockets.size() > maxSockets) {
auto socketIdentifierToClose = m_sockets.begin()->first;
+ RTC_RELEASE_LOG_ERROR("too many sockets, closing %" PRIu64, socketIdentifierToClose.toUInt64());
closeSocket(socketIdentifierToClose);
ASSERT(m_sockets.find(socketIdentifierToClose) == m_sockets.end());
}
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm (286431 => 286432)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm 2021-12-02 16:33:01 UTC (rev 286431)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm 2021-12-02 16:44:31 UTC (rev 286432)
@@ -219,6 +219,7 @@
connection->send(Messages::LibWebRTCNetwork::SignalClose(identifier, -1), 0);
break;
case nw_listener_state_cancelled:
+ RELEASE_LOG(WebRTC, "NetworkRTCUDPSocketCocoaConnections cancelled listener %" PRIu64, identifier.toUInt64());
nwListener.clear();
break;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
