Title: [286965] trunk/Source/WebCore
- Revision
- 286965
- Author
- you...@apple.com
- Date
- 2021-12-13 12:12:23 -0800 (Mon, 13 Dec 2021)
Log Message
Fix buggy assert in CoreAudioSharedUnit::setupAudioUnit
https://bugs.webkit.org/show_bug.cgi?id=234151
Reviewed by Eric Carlson.
Add the source as a client to the unit before reconfiguring the unit,
this makes the ASSERT(hasClients()) actually valid.
Manually tested.
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (286964 => 286965)
--- trunk/Source/WebCore/ChangeLog 2021-12-13 19:59:50 UTC (rev 286964)
+++ trunk/Source/WebCore/ChangeLog 2021-12-13 20:12:23 UTC (rev 286965)
@@ -1,3 +1,16 @@
+2021-12-13 Youenn Fablet <you...@apple.com>
+
+ Fix buggy assert in CoreAudioSharedUnit::setupAudioUnit
+ https://bugs.webkit.org/show_bug.cgi?id=234151
+
+ Reviewed by Eric Carlson.
+
+ Add the source as a client to the unit before reconfiguring the unit,
+ this makes the ASSERT(hasClients()) actually valid.
+ Manually tested.
+
+ * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+
2021-12-13 Nikolas Zimmermann <nzimmerm...@igalia.com>
[LBSE] Rename RenderSVGModelObject -> LegacyRenderSVGModelObject
Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (286964 => 286965)
--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2021-12-13 19:59:50 UTC (rev 286964)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2021-12-13 20:12:23 UTC (rev 286965)
@@ -762,10 +762,10 @@
unit.setSampleRate(sampleRate());
unit.setVolume(volume());
+ unit.addClient(*this);
+
if (shouldReconfigure)
unit.reconfigure();
-
- unit.addClient(*this);
}
CoreAudioCaptureSource::~CoreAudioCaptureSource()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
