Title: [287985] trunk/Tools
- Revision
- 287985
- Author
- ross.kirsl...@sony.com
- Date
- 2022-01-13 12:10:09 -0800 (Thu, 13 Jan 2022)
Log Message
PlayStation MiniBrowser should accept a command-line URL argument
https://bugs.webkit.org/show_bug.cgi?id=235193
Reviewed by Don Olmstead.
Windows MiniBrowser can be launched from the command line with a URL argument for the initial page to load;
this patch allows PlayStation MiniBrowser to do similarly.
* MiniBrowser/playstation/MainWindow.cpp:
(MainWindow::MainWindow):
* MiniBrowser/playstation/MainWindow.h:
* MiniBrowser/playstation/main.cpp:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (287984 => 287985)
--- trunk/Tools/ChangeLog 2022-01-13 19:11:51 UTC (rev 287984)
+++ trunk/Tools/ChangeLog 2022-01-13 20:10:09 UTC (rev 287985)
@@ -1,3 +1,19 @@
+2022-01-13 Ross Kirsling <ross.kirsl...@sony.com>
+
+ PlayStation MiniBrowser should accept a command-line URL argument
+ https://bugs.webkit.org/show_bug.cgi?id=235193
+
+ Reviewed by Don Olmstead.
+
+ Windows MiniBrowser can be launched from the command line with a URL argument for the initial page to load;
+ this patch allows PlayStation MiniBrowser to do similarly.
+
+ * MiniBrowser/playstation/MainWindow.cpp:
+ (MainWindow::MainWindow):
+ * MiniBrowser/playstation/MainWindow.h:
+ * MiniBrowser/playstation/main.cpp:
+ (main):
+
2022-01-13 Patrick Angle <pan...@apple.com>
Web Inspector: Implement `frameURL` option for `devtools.inspectedWindow.eval` command
Modified: trunk/Tools/MiniBrowser/playstation/MainWindow.cpp (287984 => 287985)
--- trunk/Tools/MiniBrowser/playstation/MainWindow.cpp 2022-01-13 19:11:51 UTC (rev 287984)
+++ trunk/Tools/MiniBrowser/playstation/MainWindow.cpp 2022-01-13 20:10:09 UTC (rev 287985)
@@ -41,7 +41,7 @@
using namespace toolkitten;
-MainWindow::MainWindow()
+MainWindow::MainWindow(const char* requestedURL)
{
IntSize size = Application::singleton().windowSize();
auto windowWidth = size.w;
@@ -106,7 +106,7 @@
}});
createNewWebView(nullptr);
- activeWebView()->loadURL("https://webkit.org");
+ activeWebView()->loadURL(requestedURL ? requestedURL : "https://webkit.org");
}
void MainWindow::paintSelf(toolkitten::IntPoint)
Modified: trunk/Tools/MiniBrowser/playstation/MainWindow.h (287984 => 287985)
--- trunk/Tools/MiniBrowser/playstation/MainWindow.h 2022-01-13 19:11:51 UTC (rev 287984)
+++ trunk/Tools/MiniBrowser/playstation/MainWindow.h 2022-01-13 20:10:09 UTC (rev 287985)
@@ -35,7 +35,7 @@
class MainWindow final : public toolkitten::Widget {
public:
- MainWindow();
+ MainWindow(const char*);
WebViewWindow* activeWebView();
Modified: trunk/Tools/MiniBrowser/playstation/main.cpp (287984 => 287985)
--- trunk/Tools/MiniBrowser/playstation/main.cpp 2022-01-13 19:11:51 UTC (rev 287984)
+++ trunk/Tools/MiniBrowser/playstation/main.cpp 2022-01-13 20:10:09 UTC (rev 287985)
@@ -76,7 +76,7 @@
}
};
-int main(int, char *[])
+int main(int argc, char *argv[])
{
WKRunLoopInitializeMain();
@@ -84,7 +84,7 @@
auto& app = Application::singleton();
app.init(&applicationClient);
- auto mainWindow = std::make_unique<MainWindow>();
+ auto mainWindow = std::make_unique<MainWindow>(argc > 1 ? argv[1] : nullptr);
mainWindow->setFocused();
app.setRootWidget(move(mainWindow));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
