Title: [288335] trunk/Source/WebKit
- Revision
- 288335
- Author
- timothy_hor...@apple.com
- Date
- 2022-01-20 17:13:00 -0800 (Thu, 20 Jan 2022)
Log Message
ReplayCGDisplayListsIntoBackingStore often results in compositing layers with black backgrounds
https://bugs.webkit.org/show_bug.cgi?id=235424
Reviewed by Simon Fraser.
No new tests, covered by many existing tests when run in this mode.
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
Since we use CA-driven painting when ReplayCGDisplayListsIntoBackingStore
is enabled, we need to tell CA whether or not our backing store needs
an alpha channel before invalidating and painting into the layer.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (288334 => 288335)
--- trunk/Source/WebKit/ChangeLog 2022-01-21 01:01:42 UTC (rev 288334)
+++ trunk/Source/WebKit/ChangeLog 2022-01-21 01:13:00 UTC (rev 288335)
@@ -1,3 +1,18 @@
+2022-01-20 Tim Horton <timothy_hor...@apple.com>
+
+ ReplayCGDisplayListsIntoBackingStore often results in compositing layers with black backgrounds
+ https://bugs.webkit.org/show_bug.cgi?id=235424
+
+ Reviewed by Simon Fraser.
+
+ No new tests, covered by many existing tests when run in this mode.
+
+ * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+ (WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
+ Since we use CA-driven painting when ReplayCGDisplayListsIntoBackingStore
+ is enabled, we need to tell CA whether or not our backing store needs
+ an alpha channel before invalidating and painting into the layer.
+
2022-01-20 J Pascoe <j_pas...@apple.com>
[WebAuthn] Support all valid FIDO NFC tag types
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (288334 => 288335)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-01-21 01:01:42 UTC (rev 288334)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-01-21 01:13:00 UTC (rev 288335)
@@ -488,7 +488,8 @@
if (!replayCGDisplayListsIntoBackingStore) {
[layer setValue:@1 forKeyPath:WKCGDisplayListEnabledKey];
[layer setValue:@1 forKeyPath:WKCGDisplayListBifurcationEnabledKey];
- }
+ } else
+ layer.opaque = m_isOpaque;
auto data = ""
[(WKCompositingLayer *)layer _setWKContents:contents.get() withDisplayList:data.get() replayForTesting:replayCGDisplayListsIntoBackingStore];
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
