Diff
Modified: trunk/LayoutTests/ChangeLog (288589 => 288590)
--- trunk/LayoutTests/ChangeLog 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/LayoutTests/ChangeLog 2022-01-26 00:55:51 UTC (rev 288590)
@@ -1,3 +1,13 @@
+2022-01-25 Aditya Keerthi <akeer...@apple.com>
+
+ Disable input-security CSS property
+ https://bugs.webkit.org/show_bug.cgi?id=235557
+ rdar://87984277
+
+ Reviewed by Dean Jackson.
+
+ * fast/css/computed-text-security-for-input-security.html:
+
2022-01-25 Myles C. Maxfield <mmaxfi...@apple.com>
Add another test for locale-specific shaping
Modified: trunk/LayoutTests/fast/css/computed-text-security-for-input-security.html (288589 => 288590)
--- trunk/LayoutTests/fast/css/computed-text-security-for-input-security.html 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/LayoutTests/fast/css/computed-text-security-for-input-security.html 2022-01-26 00:55:51 UTC (rev 288590)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ CSSInputSecurityEnabled=true ] -->
<html>
<head>
<script src=""
Modified: trunk/Source/WTF/ChangeLog (288589 => 288590)
--- trunk/Source/WTF/ChangeLog 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WTF/ChangeLog 2022-01-26 00:55:51 UTC (rev 288590)
@@ -1,3 +1,15 @@
+2022-01-25 Aditya Keerthi <akeer...@apple.com>
+
+ Disable input-security CSS property
+ https://bugs.webkit.org/show_bug.cgi?id=235557
+ rdar://87984277
+
+ Reviewed by Dean Jackson.
+
+ * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
+ Make input-security a disabled-by-default experimental feature.
+
2022-01-25 Adrian Perez de Castro <ape...@igalia.com>
[WTF] Make CRASH_WITH_INFO more useful when using GCC
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (288589 => 288590)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-01-26 00:55:51 UTC (rev 288590)
@@ -321,6 +321,18 @@
WebCore:
default: true
+CSSInputSecurityEnabled:
+ type: bool
+ humanReadableName: "CSS Input Security"
+ humanReadableDescription: "Enable input-security CSS property"
+ defaultValue:
+ WebKitLegacy:
+ default: false
+ WebKit:
+ default: false
+ WebCore:
+ default: false
+
CSSMotionPathEnabled:
type: bool
humanReadableName: "CSS Motion Path"
Modified: trunk/Source/WebCore/ChangeLog (288589 => 288590)
--- trunk/Source/WebCore/ChangeLog 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebCore/ChangeLog 2022-01-26 00:55:51 UTC (rev 288590)
@@ -1,3 +1,34 @@
+2022-01-25 Aditya Keerthi <akeer...@apple.com>
+
+ Disable input-security CSS property
+ https://bugs.webkit.org/show_bug.cgi?id=235557
+ rdar://87984277
+
+ Reviewed by Dean Jackson.
+
+ CSSWG is planning to remove input-security from CSS UI 4
+ (https://github.com/w3c/csswg-drafts/issues/6788).
+
+ Keep the property around as an experimental feature, so that
+ it can be used in the UA stylesheet, and easily turned on if the
+ resolution is not finalized.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
+ * css/CSSProperties.json:
+ * css/parser/CSSParserContext.cpp:
+ (WebCore::CSSParserContext::CSSParserContext):
+
+ Enable input-security when parsing the UA stylesheet, as it is used to
+ obscure text in password inputs.
+
+ (WebCore::operator==):
+ (WebCore::add):
+ (WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
+ * css/parser/CSSParserContext.h:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+
2022-01-25 Alexey Shvayka <ashva...@apple.com>
XPath::Step::nodesInAxis(): add null checks after Attr::ownerElement() calls
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (288589 => 288590)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2022-01-26 00:55:51 UTC (rev 288590)
@@ -3231,6 +3231,8 @@
return cssValuePool.createValue(style.imageResolution(), CSSUnitType::CSS_DPPX);
#endif
case CSSPropertyInputSecurity:
+ if (!m_element->document().settings().cssInputSecurityEnabled())
+ return nullptr;
return cssValuePool.createValue(style.inputSecurity());
case CSSPropertyLeft:
return positionOffsetValue(style, CSSPropertyLeft, renderer);
Modified: trunk/Source/WebCore/css/CSSProperties.json (288589 => 288590)
--- trunk/Source/WebCore/css/CSSProperties.json 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebCore/css/CSSProperties.json 2022-01-26 00:55:51 UTC (rev 288590)
@@ -2843,6 +2843,9 @@
}
},
"input-security": {
+ "codegen-properties": {
+ "settings-flag": "cssInputSecurityEnabled"
+ },
"values": [
"auto",
"none"
Modified: trunk/Source/WebCore/css/parser/CSSParserContext.cpp (288589 => 288590)
--- trunk/Source/WebCore/css/parser/CSSParserContext.cpp 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebCore/css/parser/CSSParserContext.cpp 2022-01-26 00:55:51 UTC (rev 288590)
@@ -50,6 +50,7 @@
if (mode == UASheetMode) {
individualTransformPropertiesEnabled = true;
focusVisibleEnabled = true;
+ inputSecurityEnabled = true;
#if ENABLE(CSS_TRANSFORM_STYLE_OPTIMIZED_3D)
transformStyleOptimized3DEnabled = true;
#endif
@@ -109,6 +110,7 @@
, overflowClipEnabled { document.settings().overflowClipEnabled() }
, gradientPremultipliedAlphaInterpolationEnabled { document.settings().cssGradientPremultipliedAlphaInterpolationEnabled() }
, gradientInterpolationColorSpacesEnabled { document.settings().cssGradientInterpolationColorSpacesEnabled() }
+ , inputSecurityEnabled { document.settings().cssInputSecurityEnabled() }
#if ENABLE(ATTACHMENT_ELEMENT)
, attachmentEnabled { RuntimeEnabledFeatures::sharedFeatures().attachmentElementEnabled() }
#endif
@@ -158,6 +160,7 @@
&& a.overflowClipEnabled == b.overflowClipEnabled
&& a.gradientPremultipliedAlphaInterpolationEnabled == b.gradientPremultipliedAlphaInterpolationEnabled
&& a.gradientInterpolationColorSpacesEnabled == b.gradientInterpolationColorSpacesEnabled
+ && a.inputSecurityEnabled == b.inputSecurityEnabled
#if ENABLE(ATTACHMENT_ELEMENT)
&& a.attachmentEnabled == b.attachmentEnabled
#endif
@@ -204,7 +207,8 @@
| context.attachmentEnabled << 28
#endif
| context.accentColorEnabled << 29
- | context.mode << 30; // This is multiple bits, so keep it last.
+ | context.inputSecurityEnabled << 30
+ | context.mode << 31; // This is multiple bits, so keep it last.
add(hasher, context.baseURL, context.charset, bits);
}
@@ -229,6 +233,8 @@
return !containmentEnabled;
case CSSPropertyAppleColorFilter:
return !colorFilterEnabled;
+ case CSSPropertyInputSecurity:
+ return !inputSecurityEnabled;
case CSSPropertyTranslate:
case CSSPropertyRotate:
case CSSPropertyScale:
Modified: trunk/Source/WebCore/css/parser/CSSParserContext.h (288589 => 288590)
--- trunk/Source/WebCore/css/parser/CSSParserContext.h 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebCore/css/parser/CSSParserContext.h 2022-01-26 00:55:51 UTC (rev 288590)
@@ -88,6 +88,7 @@
bool overflowClipEnabled { false };
bool gradientPremultipliedAlphaInterpolationEnabled { false };
bool gradientInterpolationColorSpacesEnabled { false };
+ bool inputSecurityEnabled { false };
// RuntimeEnabledFeatures.
#if ENABLE(ATTACHMENT_ELEMENT)
Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (288589 => 288590)
--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-01-26 00:55:51 UTC (rev 288590)
@@ -648,6 +648,8 @@
case CSSPropertyImageRendering: // auto | optimizeContrast | pixelated | optimizeSpeed | crispEdges | optimizeQuality | webkit-crispEdges
return valueID == CSSValueAuto || valueID == CSSValueOptimizeSpeed || valueID == CSSValueOptimizeQuality || valueID == CSSValueWebkitCrispEdges || valueID == CSSValueWebkitOptimizeContrast || valueID == CSSValueCrispEdges || valueID == CSSValuePixelated;
case CSSPropertyInputSecurity:
+ if (!context.inputSecurityEnabled)
+ return false;
return valueID == CSSValueAuto || valueID == CSSValueNone;
#if ENABLE(CSS_COMPOSITING)
case CSSPropertyIsolation: // auto | isolate
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (288589 => 288590)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2022-01-26 00:55:51 UTC (rev 288590)
@@ -1,3 +1,19 @@
+2022-01-25 Aditya Keerthi <akeer...@apple.com>
+
+ Disable input-security CSS property
+ https://bugs.webkit.org/show_bug.cgi?id=235557
+ rdar://87984277
+
+ Reviewed by Dean Jackson.
+
+ Add support for tests enabling the CSSInputSecurityEnabled preference.
+
+ * WebPreferences.cpp:
+ (WebPreferences::cssInputSecurityEnabled):
+ * WebPreferences.h:
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
2022-01-21 Fujii Hironori <hironori.fu...@sony.com>
Fix AppleWin build with newer MSVC
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (288589 => 288590)
--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2022-01-26 00:55:51 UTC (rev 288590)
@@ -2652,3 +2652,7 @@
return boolValueForKey("WebKitMockScrollbarsControllerEnabled");
}
+bool WebPreferences::cssInputSecurityEnabled()
+{
+ return boolValueForKey("WebKitCSSInputSecurityEnabled");
+}
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.h (288589 => 288590)
--- trunk/Source/WebKitLegacy/win/WebPreferences.h 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.h 2022-01-26 00:55:51 UTC (rev 288590)
@@ -349,6 +349,7 @@
bool cssGradientInterpolationColorSpacesEnabled();
bool cssGradientPremultipliedAlphaInterpolationEnabled();
bool mockScrollbarsControllerEnabled();
+ bool cssInputSecurityEnabled();
private:
WebPreferences();
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (288589 => 288590)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2022-01-26 00:55:51 UTC (rev 288590)
@@ -5445,6 +5445,7 @@
settings.setCSSGradientInterpolationColorSpacesEnabled(m_preferences->cssGradientInterpolationColorSpacesEnabled());
settings.setCSSGradientPremultipliedAlphaInterpolationEnabled(m_preferences->cssGradientPremultipliedAlphaInterpolationEnabled());
settings.setMockScrollbarsControllerEnabled(m_preferences->mockScrollbarsControllerEnabled());
+ settings.setCSSInputSecurityEnabled(m_preferences->cssInputSecurityEnabled());
return S_OK;
}
Modified: trunk/Tools/ChangeLog (288589 => 288590)
--- trunk/Tools/ChangeLog 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Tools/ChangeLog 2022-01-26 00:55:51 UTC (rev 288590)
@@ -1,3 +1,16 @@
+2022-01-25 Aditya Keerthi <akeer...@apple.com>
+
+ Disable input-security CSS property
+ https://bugs.webkit.org/show_bug.cgi?id=235557
+ rdar://87984277
+
+ Reviewed by Dean Jackson.
+
+ * DumpRenderTree/TestOptions.cpp:
+ (WTR::TestOptions::defaults):
+
+ Add default for WebKitLegacy on Windows.
+
2022-01-25 Simon Fraser <simon.fra...@apple.com>
Fix the lldb Color formatter
Modified: trunk/Tools/DumpRenderTree/TestOptions.cpp (288589 => 288590)
--- trunk/Tools/DumpRenderTree/TestOptions.cpp 2022-01-26 00:31:38 UTC (rev 288589)
+++ trunk/Tools/DumpRenderTree/TestOptions.cpp 2022-01-26 00:55:51 UTC (rev 288590)
@@ -137,6 +137,7 @@
{ "CSSCounterStyleAtRulesEnabled", false },
{ "CSSGradientInterpolationColorSpacesEnabled", true },
{ "CSSGradientPremultipliedAlphaInterpolationEnabled", true },
+ { "CSSInputSecurityEnabled", true },
{ "CSSLogicalEnabled", false },
{ "CSSOMViewSmoothScrollingEnabled", false },
{ "CanvasColorSpaceEnabled", true },