Title: [288634] trunk/Tools/CISupport/ews-build/loadConfig.py
Revision
288634
Author
aakash_j...@apple.com
Date
2022-01-26 11:31:02 -0800 (Wed, 26 Jan 2022)

Log Message

[ews] Allow triggering individual EWS queues
https://bugs.webkit.org/show_bug.cgi?id=235620

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/loadConfig.py:
(loadBuilderConfig): Allow ForceScheduler in production, configure it appropriately.

Canonical link: https://commits.webkit.org/246448@main

Modified Paths

Diff

Modified: trunk/Tools/CISupport/ews-build/loadConfig.py (288633 => 288634)


--- trunk/Tools/CISupport/ews-build/loadConfig.py	2022-01-26 19:24:02 UTC (rev 288633)
+++ trunk/Tools/CISupport/ews-build/loadConfig.py	2022-01-26 19:31:02 UTC (rev 288634)
@@ -27,7 +27,7 @@
 
 from buildbot.scheduler import AnyBranchScheduler, Periodic, Dependent, Triggerable, Nightly
 from buildbot.schedulers.trysched import Try_Userpass
-from buildbot.schedulers.forcesched import ForceScheduler, StringParameter, FixedParameter, CodebaseParameter
+from buildbot.schedulers.forcesched import ForceScheduler, IntParameter, StringParameter, FixedParameter, CodebaseParameter
 from buildbot.worker import Worker
 from buildbot.util import identifiers as buildbot_identifiers
 
@@ -86,22 +86,22 @@
             scheduler['userpass'] = [(os.getenv('BUILDBOT_TRY_USERNAME', 'sampleuser'), os.getenv('BUILDBOT_TRY_PASSWORD', 'samplepass'))]
         c['schedulers'].append(schedulerClass(**scheduler))
 
-    if is_test_mode_enabled:
-        forceScheduler = ForceScheduler(
-            name="force_build",
-            buttonName="Force Build",
-            builderNames=[str(builder['name']) for builder in config['builders']],
-            # Disable default enabled input fields: branch, repository, project, additional properties
-            codebases=[CodebaseParameter("",
-                       revision=FixedParameter(name="revision", default=""),
-                       repository=FixedParameter(name="repository", default=""),
-                       project=FixedParameter(name="project", default=""),
-                       branch=FixedParameter(name="branch", default=""))],
-            # Add custom properties needed
-            properties=[StringParameter(name="patch_id", label="Patch attachment id number (not bug number)", required=True, maxsize=7),
-                        StringParameter(name="ews_revision", label="WebKit git sha1 hash to checkout before trying patch (optional)", required=False, maxsize=40)],
-        )
-        c['schedulers'].append(forceScheduler)
+    forceScheduler = ForceScheduler(
+        name='try_build',
+        buttonName='Try Build',
+        reason=StringParameter(name='reason', default='Trying patch', size=20),
+        builderNames=[str(builder['name']) for builder in config['builders']],
+        # Disable default enabled input fields: branch, repository, project, additional properties
+        codebases=[CodebaseParameter('',
+                   revision=FixedParameter(name='revision', default=''),
+                   repository=FixedParameter(name='repository', default=''),
+                   project=FixedParameter(name='project', default=''),
+                   branch=FixedParameter(name='branch', default=''))],
+        # Add custom properties needed
+        properties=[IntParameter(name='patch_id', label='Patch id (not bug number)', required=True, maxsize=6),
+                    StringParameter(name='ews_revision', label='WebKit git hash to checkout before trying patch (optional)', required=False, maxsize=40)],
+    )
+    c['schedulers'].append(forceScheduler)
 
 
 def prioritizeBuilders(buildmaster, builders):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to