- Revision
- 288696
- Author
- commit-qu...@webkit.org
- Date
- 2022-01-27 12:49:57 -0800 (Thu, 27 Jan 2022)
Log Message
[XCBuild] Add missing task dependencies on generate-unified-source-bundles.rb
https://bugs.webkit.org/show_bug.cgi?id=235724
Patch by Elliott Williams <e...@apple.com> on 2022-01-27
Reviewed by Alexey Proskuryakov.
Source/WebCore:
The targets which generate unified sources all use
/usr/local/include/wtf/Scripts/generate-unified-source-bundles.rb, but do not declare it.
In workspace builds, WTF may not have been built and this header may not exist yet.
* WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
* WebKit.xcodeproj/project.pbxproj:
Source/WebKitLegacy:
* WebKitLegacy.xcodeproj/project.pbxproj:
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (288695 => 288696)
--- trunk/Source/WebCore/ChangeLog 2022-01-27 20:27:00 UTC (rev 288695)
+++ trunk/Source/WebCore/ChangeLog 2022-01-27 20:49:57 UTC (rev 288696)
@@ -1,3 +1,16 @@
+2022-01-27 Elliott Williams <e...@apple.com>
+
+ [XCBuild] Add missing task dependencies on generate-unified-source-bundles.rb
+ https://bugs.webkit.org/show_bug.cgi?id=235724
+
+ Reviewed by Alexey Proskuryakov.
+
+ The targets which generate unified sources all use
+ /usr/local/include/wtf/Scripts/generate-unified-source-bundles.rb, but do not declare it.
+ In workspace builds, WTF may not have been built and this header may not exist yet.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
2022-01-27 Commit Queue <commit-qu...@webkit.org>
Unreviewed, reverting r288670.
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (288695 => 288696)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2022-01-27 20:27:00 UTC (rev 288695)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2022-01-27 20:49:57 UTC (rev 288696)
@@ -38355,6 +38355,7 @@
"$(SRCROOT)/Scripts/generate-unified-sources.sh",
"$(SRCROOT)/Sources.txt",
"$(SRCROOT)/SourcesCocoa.txt",
+ "$(BUILT_PRODUCTS_DIR)/usr/local/include/wtf/Scripts/generate-unified-source-bundles.rb",
);
name = "Generate Unified Sources";
outputFileListPaths = (
Modified: trunk/Source/WebKit/ChangeLog (288695 => 288696)
--- trunk/Source/WebKit/ChangeLog 2022-01-27 20:27:00 UTC (rev 288695)
+++ trunk/Source/WebKit/ChangeLog 2022-01-27 20:49:57 UTC (rev 288696)
@@ -1,3 +1,12 @@
+2022-01-27 Elliott Williams <e...@apple.com>
+
+ [XCBuild] Add missing task dependencies on generate-unified-source-bundles.rb
+ https://bugs.webkit.org/show_bug.cgi?id=235724
+
+ Reviewed by Alexey Proskuryakov.
+
+ * WebKit.xcodeproj/project.pbxproj:
+
2022-01-27 Commit Queue <commit-qu...@webkit.org>
Unreviewed, reverting r288670.
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (288695 => 288696)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-01-27 20:27:00 UTC (rev 288695)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-01-27 20:49:57 UTC (rev 288696)
@@ -14609,6 +14609,7 @@
"$(SRCROOT)/Scripts/generate-unified-sources.sh",
"$(SRCROOT)/Sources.txt",
"$(SRCROOT)/SourcesCocoa.txt",
+ "$(BUILT_PRODUCTS_DIR)/usr/local/include/wtf/Scripts/generate-unified-source-bundles.rb",
);
name = "Generate Unified Sources";
outputFileListPaths = (
Modified: trunk/Source/WebKitLegacy/ChangeLog (288695 => 288696)
--- trunk/Source/WebKitLegacy/ChangeLog 2022-01-27 20:27:00 UTC (rev 288695)
+++ trunk/Source/WebKitLegacy/ChangeLog 2022-01-27 20:49:57 UTC (rev 288696)
@@ -1,5 +1,14 @@
2022-01-27 Elliott Williams <e...@apple.com>
+ [XCBuild] Add missing task dependencies on generate-unified-source-bundles.rb
+ https://bugs.webkit.org/show_bug.cgi?id=235724
+
+ Reviewed by Alexey Proskuryakov.
+
+ * WebKitLegacy.xcodeproj/project.pbxproj:
+
+2022-01-27 Elliott Williams <e...@apple.com>
+
Generated xcfilelists contain symlinks when building for macOS
https://bugs.webkit.org/show_bug.cgi?id=235663
rdar://88054903
Modified: trunk/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj (288695 => 288696)
--- trunk/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj 2022-01-27 20:27:00 UTC (rev 288695)
+++ trunk/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj 2022-01-27 20:49:57 UTC (rev 288696)
@@ -3284,6 +3284,7 @@
"$(SRCROOT)/scripts/generate-unified-sources.sh",
"$(SRCROOT)/Sources.txt",
"$(SRCROOT)/SourcesCocoa.txt",
+ "$(BUILT_PRODUCTS_DIR)/usr/local/include/wtf/Scripts/generate-unified-source-bundles.rb",
);
outputFileListPaths = (
"$(SRCROOT)/UnifiedSources-output.xcfilelist",
Modified: trunk/Tools/ChangeLog (288695 => 288696)
--- trunk/Tools/ChangeLog 2022-01-27 20:27:00 UTC (rev 288695)
+++ trunk/Tools/ChangeLog 2022-01-27 20:49:57 UTC (rev 288696)
@@ -1,5 +1,14 @@
2022-01-27 Elliott Williams <e...@apple.com>
+ [XCBuild] Add missing task dependencies on generate-unified-source-bundles.rb
+ https://bugs.webkit.org/show_bug.cgi?id=235724
+
+ Reviewed by Alexey Proskuryakov.
+
+ * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+
+2022-01-27 Elliott Williams <e...@apple.com>
+
Generated xcfilelists contain symlinks when building for macOS
https://bugs.webkit.org/show_bug.cgi?id=235663
rdar://88054903
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (288695 => 288696)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2022-01-27 20:27:00 UTC (rev 288695)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2022-01-27 20:49:57 UTC (rev 288696)
@@ -5295,6 +5295,7 @@
"$(SRCROOT)/Scripts/generate-unified-sources.sh",
"$(SRCROOT)/Sources.txt",
"$(SRCROOT)/SourcesCocoa.txt",
+ "$(BUILT_PRODUCTS_DIR)/usr/local/include/wtf/Scripts/generate-unified-source-bundles.rb",
);
outputFileListPaths = (
"$(SRCROOT)/UnifiedSources-output.xcfilelist",
