Title: [289497] trunk
- Revision
- 289497
- Author
- hironori.fu...@sony.com
- Date
- 2022-02-09 12:36:06 -0800 (Wed, 09 Feb 2022)
Log Message
compositing/masks/compositing-clip-path-mask-change.html is failing for ports using TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=236323
Reviewed by Don Olmstead.
Source/WebCore:
Apple ports don't have this issue because GraphicsLayerCA support
Shape layer for clip-path.
The painting phase of the existing mask layer should be updated if
clip-path or mask are changed.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateMaskingLayer):
LayoutTests:
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (289496 => 289497)
--- trunk/LayoutTests/ChangeLog 2022-02-09 20:25:11 UTC (rev 289496)
+++ trunk/LayoutTests/ChangeLog 2022-02-09 20:36:06 UTC (rev 289497)
@@ -1,3 +1,12 @@
+2022-02-09 Fujii Hironori <hironori.fu...@sony.com>
+
+ compositing/masks/compositing-clip-path-mask-change.html is failing for ports using TextureMapper
+ https://bugs.webkit.org/show_bug.cgi?id=236323
+
+ Reviewed by Don Olmstead.
+
+ * platform/gtk/TestExpectations:
+
2022-02-09 Jon Lee <jon...@apple.com>
Unreviewed gardening.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (289496 => 289497)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2022-02-09 20:25:11 UTC (rev 289496)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2022-02-09 20:36:06 UTC (rev 289497)
@@ -430,7 +430,6 @@
webkit.org/b/169918 compositing/hidpi-subpixel-transform-origin.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/hidpi-transform-with-render-layer-on-fractional-pixel-value.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/layer-creation/deep-tree.html [ ImageOnlyFailure ]
-webkit.org/b/169918 compositing/masks/compositing-clip-path-mask-change.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/overlap-blending/nested-overlap-overflow.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/overlap-blending/nested-overlap.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/patterns/direct-pattern-compositing-contain.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (289496 => 289497)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 20:25:11 UTC (rev 289496)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 20:36:06 UTC (rev 289497)
@@ -1,3 +1,19 @@
+2022-02-09 Fujii Hironori <hironori.fu...@sony.com>
+
+ compositing/masks/compositing-clip-path-mask-change.html is failing for ports using TextureMapper
+ https://bugs.webkit.org/show_bug.cgi?id=236323
+
+ Reviewed by Don Olmstead.
+
+ Apple ports don't have this issue because GraphicsLayerCA support
+ Shape layer for clip-path.
+
+ The painting phase of the existing mask layer should be updated if
+ clip-path or mask are changed.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateMaskingLayer):
+
2022-02-09 Antoine Quint <grao...@webkit.org>
[model] improve sizing on macOS
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (289496 => 289497)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2022-02-09 20:25:11 UTC (rev 289496)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2022-02-09 20:36:06 UTC (rev 289497)
@@ -2300,13 +2300,13 @@
if (!m_maskLayer) {
m_maskLayer = createGraphicsLayer("mask", requiredLayerType);
- m_maskLayer->setDrawsContent(paintsContent);
- m_maskLayer->setPaintingPhase(maskPhases);
layerChanged = true;
m_graphicsLayer->setMaskLayer(m_maskLayer.copyRef());
// We need a geometry update to size the new mask layer.
m_owningLayer.setNeedsCompositingGeometryUpdate();
}
+ m_maskLayer->setDrawsContent(paintsContent);
+ m_maskLayer->setPaintingPhase(maskPhases);
} else if (m_maskLayer) {
m_graphicsLayer->setMaskLayer(nullptr);
willDestroyLayer(m_maskLayer.get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
