Title: [289711] trunk/Source/WebCore
- Revision
- 289711
- Author
- za...@apple.com
- Date
- 2022-02-13 06:55:10 -0800 (Sun, 13 Feb 2022)
Log Message
[LFC][IFC] Pass in the correct LineDirectionMode value to RenderBoxModelObject::baselinePosition
https://bugs.webkit.org/show_bug.cgi?id=236552
Reviewed by Antti Koivisto.
This is when setting up the BoxGeometry for the atomic inline level boxes.
* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (289710 => 289711)
--- trunk/Source/WebCore/ChangeLog 2022-02-13 14:53:28 UTC (rev 289710)
+++ trunk/Source/WebCore/ChangeLog 2022-02-13 14:55:10 UTC (rev 289711)
@@ -1,5 +1,17 @@
2022-02-13 Alan Bujtas <za...@apple.com>
+ [LFC][IFC] Pass in the correct LineDirectionMode value to RenderBoxModelObject::baselinePosition
+ https://bugs.webkit.org/show_bug.cgi?id=236552
+
+ Reviewed by Antti Koivisto.
+
+ This is when setting up the BoxGeometry for the atomic inline level boxes.
+
+ * layout/integration/LayoutIntegrationLineLayout.cpp:
+ (WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
+
+2022-02-13 Alan Bujtas <za...@apple.com>
+
[LFC][IFC] Add missing bidi vertical adjustment when writing mode is not horizontal
https://bugs.webkit.org/show_bug.cgi?id=236551
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (289710 => 289711)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2022-02-13 14:53:28 UTC (rev 289710)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2022-02-13 14:55:10 UTC (rev 289711)
@@ -245,7 +245,7 @@
replacedBoxGeometry.setBorder(logicalBorder(replacedOrInlineBlock, isLeftToRightDirection, isHorizontalWritingMode));
replacedBoxGeometry.setPadding(logicalPadding(replacedOrInlineBlock, isLeftToRightDirection, isHorizontalWritingMode));
- auto baseline = replacedOrInlineBlock.baselinePosition(AlphabeticBaseline, false /* firstLine */, HorizontalLine, PositionOnContainingLine);
+ auto baseline = replacedOrInlineBlock.baselinePosition(AlphabeticBaseline, false /* firstLine */, isHorizontalWritingMode ? HorizontalLine : VerticalLine, PositionOnContainingLine);
replacedBox.setBaseline(roundToInt(baseline));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
