Title: [289886] trunk
Revision
289886
Author
an...@apple.com
Date
2022-02-16 04:38:35 -0800 (Wed, 16 Feb 2022)

Log Message

[CSS Container Queries] Serialize container shorthand in StyleProperties
https://bugs.webkit.org/show_bug.cgi?id=236691

Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt:

Source/WebCore:

Serialize element.style.container.

* css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const):

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289885 => 289886)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-02-16 10:55:58 UTC (rev 289885)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-02-16 12:38:35 UTC (rev 289886)
@@ -1,3 +1,12 @@
+2022-02-16  Antti Koivisto  <an...@apple.com>
+
+        [CSS Container Queries] Serialize container shorthand in StyleProperties
+        https://bugs.webkit.org/show_bug.cgi?id=236691
+
+        Reviewed by Antoine Quint.
+
+        * web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt:
+
 2022-02-15  Nikolaos Mouchtaris  <nmouchta...@apple.com>
 
         Implement parsing and animation support for offset shorthand

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt (289885 => 289886)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt	2022-02-16 10:55:58 UTC (rev 289885)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt	2022-02-16 12:38:35 UTC (rev 289886)
@@ -1,16 +1,16 @@
 
-FAIL e.style['container'] = "initial" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "inherit" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "unset" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "revert" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "none" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "none / none" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "inline-size" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "inline-size / none" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "size" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "size / block-size" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "inline-size / inline-size" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "size / size" should set the property value assert_not_equals: property should be set got disallowed value ""
+PASS e.style['container'] = "initial" should set the property value
+PASS e.style['container'] = "inherit" should set the property value
+PASS e.style['container'] = "unset" should set the property value
+PASS e.style['container'] = "revert" should set the property value
+PASS e.style['container'] = "none" should set the property value
+FAIL e.style['container'] = "none / none" should set the property value assert_equals: serialization should be canonical expected "none" but got "none / none"
+PASS e.style['container'] = "inline-size" should set the property value
+FAIL e.style['container'] = "inline-size / none" should set the property value assert_equals: serialization should be canonical expected "inline-size" but got "inline-size / none"
+PASS e.style['container'] = "size" should set the property value
+PASS e.style['container'] = "size / block-size" should set the property value
+PASS e.style['container'] = "inline-size / inline-size" should set the property value
+PASS e.style['container'] = "size / size" should set the property value
 FAIL e.style['container'] = "size state / none" should set the property value assert_not_equals: property should be set got disallowed value ""
 PASS e.style['container'] = "none none" should not set the property value
 PASS e.style['container'] = "none inline-size" should not set the property value

Modified: trunk/Source/WebCore/ChangeLog (289885 => 289886)


--- trunk/Source/WebCore/ChangeLog	2022-02-16 10:55:58 UTC (rev 289885)
+++ trunk/Source/WebCore/ChangeLog	2022-02-16 12:38:35 UTC (rev 289886)
@@ -1,3 +1,15 @@
+2022-02-16  Antti Koivisto  <an...@apple.com>
+
+        [CSS Container Queries] Serialize container shorthand in StyleProperties
+        https://bugs.webkit.org/show_bug.cgi?id=236691
+
+        Reviewed by Antoine Quint.
+
+        Serialize element.style.container.
+
+        * css/StyleProperties.cpp:
+        (WebCore::StyleProperties::getPropertyValue const):
+
 2022-02-16  Alejandro G. Castro  <a...@igalia.com>
 
         [GTK][WPE] Use drm render nodes in GbmDevice and make the fd global to the process

Modified: trunk/Source/WebCore/css/StyleProperties.cpp (289885 => 289886)


--- trunk/Source/WebCore/css/StyleProperties.cpp	2022-02-16 10:55:58 UTC (rev 289885)
+++ trunk/Source/WebCore/css/StyleProperties.cpp	2022-02-16 12:38:35 UTC (rev 289886)
@@ -243,6 +243,8 @@
         return getShorthandValue(columnRuleShorthand());
     case CSSPropertyColumns:
         return getShorthandValue(columnsShorthand());
+    case CSSPropertyContainer:
+        return getShorthandValue(containerShorthand(), " / ");
     case CSSPropertyFlex:
         return getShorthandValue(flexShorthand());
     case CSSPropertyFlexFlow:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to