Title: [290065] trunk/Source/WebInspectorUI
- Revision
- 290065
- Author
- nvasil...@apple.com
- Date
- 2022-02-17 13:19:01 -0800 (Thu, 17 Feb 2022)
Log Message
Web Inspector: [Flexbox] Enable Flexbox Inspector feature
https://bugs.webkit.org/show_bug.cgi?id=235820
<rdar://87886409>
Reviewed by Patrick Angle.
Remove the engineering setting and enable the feature by default.
* UserInterface/Base/Setting.js:
* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype._updateLayoutBadge):
* UserInterface/Views/LayoutDetailsSidebarPanel.js:
(WI.LayoutDetailsSidebarPanel.prototype.initialLayout):
(WI.LayoutDetailsSidebarPanel.prototype.layout):
(WI.LayoutDetailsSidebarPanel.prototype._refreshNodeSets):
(WI.LayoutDetailsSidebarPanel):
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createEngineeringSettingsView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (290064 => 290065)
--- trunk/Source/WebInspectorUI/ChangeLog 2022-02-17 21:13:57 UTC (rev 290064)
+++ trunk/Source/WebInspectorUI/ChangeLog 2022-02-17 21:19:01 UTC (rev 290065)
@@ -1,3 +1,24 @@
+2022-02-17 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: [Flexbox] Enable Flexbox Inspector feature
+ https://bugs.webkit.org/show_bug.cgi?id=235820
+ <rdar://87886409>
+
+ Reviewed by Patrick Angle.
+
+ Remove the engineering setting and enable the feature by default.
+
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/DOMTreeElement.js:
+ (WI.DOMTreeElement.prototype._updateLayoutBadge):
+ * UserInterface/Views/LayoutDetailsSidebarPanel.js:
+ (WI.LayoutDetailsSidebarPanel.prototype.initialLayout):
+ (WI.LayoutDetailsSidebarPanel.prototype.layout):
+ (WI.LayoutDetailsSidebarPanel.prototype._refreshNodeSets):
+ (WI.LayoutDetailsSidebarPanel):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createEngineeringSettingsView):
+
2022-02-14 Razvan Caliman <rcali...@apple.com>
Web Inspector: [Flexbox] List flex containers in Layout sidebar
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (290064 => 290065)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2022-02-17 21:13:57 UTC (rev 290064)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2022-02-17 21:19:01 UTC (rev 290065)
@@ -239,7 +239,6 @@
protocolFilterMultiplexingBackendMessages: new WI.Setting("protocol-filter-multiplexing-backend-messages", true),
// Engineering
- engineeringEnableFlexboxInspector: new WI.EngineeringSetting("engineering-enable-flexbox-inspector", false),
engineeringShowInternalExecutionContexts: new WI.EngineeringSetting("engineering-show-internal-execution-contexts", false),
engineeringShowInternalScripts: new WI.EngineeringSetting("engineering-show-internal-scripts", false),
engineeringPauseForInternalScripts: new WI.EngineeringSetting("engineering-pause-for-internal-scripts", false),
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (290064 => 290065)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2022-02-17 21:13:57 UTC (rev 290064)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2022-02-17 21:19:01 UTC (rev 290065)
@@ -2023,9 +2023,6 @@
if (!this.representedObject.layoutContextType)
return;
- if (this.representedObject.layoutContextType === WI.DOMNode.LayoutContextType.Flex && !WI.settings.engineeringEnableFlexboxInspector.value)
- return;
-
this._layoutBadgeElement = this.title.appendChild(document.createElement("span"));
this._layoutBadgeElement.className = "layout-badge";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js (290064 => 290065)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js 2022-02-17 21:13:57 UTC (rev 290064)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js 2022-02-17 21:19:01 UTC (rev 290065)
@@ -105,10 +105,6 @@
this._gridSection = new WI.CSSGridNodeOverlayListSection;
- // FIXME: <https://webkit.org/b/235820> Enable Flexbox Inspector feature
- if (!WI.settings.engineeringEnableFlexboxInspector.value)
- return;
-
this._flexDetailsSectionRow = new WI.DetailsSectionRow(WI.UIString("No CSS Flex Containers", "No CSS Flex Containers @ Layout Details Sidebar Panel", "Message shown when there are no CSS Flex containers on the inspected page."));
let flexDetailsSection = new WI.DetailsSection("layout-css-flexbox", WI.UIString("Flexbox", "Flexbox @ Elements details sidebar", "Flexbox layout section name"), [new WI.DetailsSectionGroup([this._flexDetailsSectionRow])]);
this.contentView.element.appendChild(flexDetailsSection.element);
@@ -135,10 +131,6 @@
this.removeSubview(this._gridSection);
}
- // FIXME: <https://webkit.org/b/235820> Enable Flexbox Inspector feature
- if (!WI.settings.engineeringEnableFlexboxInspector.value)
- return;
-
if (this._flexNodeSet.size) {
this._flexDetailsSectionRow.hideEmptyMessage();
this._flexDetailsSectionRow.element.appendChild(this._flexSection.element);
@@ -203,9 +195,6 @@
_refreshNodeSets()
{
this._gridNodeSet = new Set(WI.domManager.nodesWithLayoutContextType(WI.DOMNode.LayoutContextType.Grid));
-
- // FIXME: <https://webkit.org/b/235820> Enable Flexbox Inspector feature
- if (WI.settings.engineeringEnableFlexboxInspector.value)
- this._flexNodeSet = new Set(WI.domManager.nodesWithLayoutContextType(WI.DOMNode.LayoutContextType.Flex));
+ this._flexNodeSet = new Set(WI.domManager.nodesWithLayoutContextType(WI.DOMNode.LayoutContextType.Flex));
}
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (290064 => 290065)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2022-02-17 21:13:57 UTC (rev 290064)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2022-02-17 21:19:01 UTC (rev 290065)
@@ -443,7 +443,6 @@
let elementsGroup = engineeringSettingsView.addGroup(WI.unlocalizedString("Elements:"));
elementsGroup.addSetting(WI.settings.engineeringAllowEditingUserAgentShadowTrees, WI.unlocalizedString("Allow editing UserAgent shadow trees"));
- elementsGroup.addSetting(WI.settings.engineeringEnableFlexboxInspector, WI.unlocalizedString("Enable Flexbox Inspector"));
engineeringSettingsView.addSeparator();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
