Title: [290662] trunk
- Revision
- 290662
- Author
- grao...@webkit.org
- Date
- 2022-03-01 11:29:54 -0800 (Tue, 01 Mar 2022)
Log Message
[web-animations] ::placeholder should not be a valid pseudo-element for a KeyframeEffect target
https://bugs.webkit.org/show_bug.cgi?id=237334
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
* web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt:
Source/WebCore:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setPseudoElement):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (290661 => 290662)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-01 19:07:21 UTC (rev 290661)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-01 19:29:54 UTC (rev 290662)
@@ -1,5 +1,15 @@
2022-03-01 Antoine Quint <grao...@webkit.org>
+ [web-animations] ::placeholder should not be a valid pseudo-element for a KeyframeEffect target
+ https://bugs.webkit.org/show_bug.cgi?id=237334
+
+ Reviewed by Dean Jackson.
+
+ * web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt:
+ * web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt:
+
+2022-03-01 Antoine Quint <grao...@webkit.org>
+
[web-animations] add support for passing an optional timeline to Element.animate()
https://bugs.webkit.org/show_bug.cgi?id=237312
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt (290661 => 290662)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt 2022-03-01 19:07:21 UTC (rev 290661)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt 2022-03-01 19:29:54 UTC (rev 290662)
@@ -149,7 +149,5 @@
PASS animate() with a non-null invalid pseudoElement 'before' throws a SyntaxError
PASS animate() with a non-null invalid pseudoElement ':abc' throws a SyntaxError
PASS animate() with a non-null invalid pseudoElement '::abc' throws a SyntaxError
-FAIL animate() with a non-null invalid pseudoElement '::placeholder' throws a SyntaxError assert_throws_dom: function "() => {
- div.animate(null, {pseudoElement: pseudo});
- }" did not throw
+PASS animate() with a non-null invalid pseudoElement '::placeholder' throws a SyntaxError
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt (290661 => 290662)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt 2022-03-01 19:07:21 UTC (rev 290661)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt 2022-03-01 19:29:54 UTC (rev 290662)
@@ -22,5 +22,5 @@
PASS Changing pseudoElement to a non-null invalid pseudo-selector 'before' throws a SyntaxError
PASS Changing pseudoElement to a non-null invalid pseudo-selector ':abc' throws a SyntaxError
PASS Changing pseudoElement to a non-null invalid pseudo-selector '::abc' throws a SyntaxError
-FAIL Changing pseudoElement to a non-null invalid pseudo-selector '::placeholder' throws a SyntaxError assert_throws_dom: function "() => effect.pseudoElement = pseudo" did not throw
+PASS Changing pseudoElement to a non-null invalid pseudo-selector '::placeholder' throws a SyntaxError
Modified: trunk/Source/WebCore/ChangeLog (290661 => 290662)
--- trunk/Source/WebCore/ChangeLog 2022-03-01 19:07:21 UTC (rev 290661)
+++ trunk/Source/WebCore/ChangeLog 2022-03-01 19:29:54 UTC (rev 290662)
@@ -1,3 +1,13 @@
+2022-03-01 Antoine Quint <grao...@webkit.org>
+
+ [web-animations] ::placeholder should not be a valid pseudo-element for a KeyframeEffect target
+ https://bugs.webkit.org/show_bug.cgi?id=237334
+
+ Reviewed by Dean Jackson.
+
+ * animation/KeyframeEffect.cpp:
+ (WebCore::KeyframeEffect::setPseudoElement):
+
2022-03-01 Alex Christensen <achristen...@webkit.org>
[AppleWin] Start using Visual Studio 2022
Modified: trunk/Source/WebCore/animation/KeyframeEffect.cpp (290661 => 290662)
--- trunk/Source/WebCore/animation/KeyframeEffect.cpp 2022-03-01 19:07:21 UTC (rev 290661)
+++ trunk/Source/WebCore/animation/KeyframeEffect.cpp 2022-03-01 19:29:54 UTC (rev 290662)
@@ -1183,7 +1183,7 @@
if (!isLegacy && !pseudoElement.startsWith("::"))
return Exception { SyntaxError };
auto pseudoType = CSSSelector::parsePseudoElementType(pseudoElement.substring(isLegacy ? 1 : 2));
- if (pseudoType == CSSSelector::PseudoElementUnknown)
+ if (pseudoType == CSSSelector::PseudoElementUnknown || pseudoType == CSSSelector::PseudoElementWebKitCustom)
return Exception { SyntaxError };
pseudoId = CSSSelector::pseudoId(pseudoType);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
