Title: [291129] trunk
Revision
291129
Author
grao...@webkit.org
Date
2022-03-10 13:47:34 -0800 (Thu, 10 Mar 2022)

Log Message

[web-animations] scroll-behavior should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237723

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291128 => 291129)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-10 21:41:57 UTC (rev 291128)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-10 21:47:34 UTC (rev 291129)
@@ -1,5 +1,16 @@
 2022-03-10  Antoine Quint  <grao...@webkit.org>
 
+        [web-animations] scroll-behavior should support discrete animation
+        https://bugs.webkit.org/show_bug.cgi?id=237723
+
+        Reviewed by Antti Koivisto.
+
+        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
+        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
+        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
+
+2022-03-10  Antoine Quint  <grao...@webkit.org>
+
         [web-animations] quotes should support discrete animation
         https://bugs.webkit.org/show_bug.cgi?id=237721
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt (291128 => 291129)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt	2022-03-10 21:41:57 UTC (rev 291128)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt	2022-03-10 21:47:34 UTC (rev 291129)
@@ -113,6 +113,9 @@
 PASS resize (type: discrete) has testAccumulation function
 PASS resize: "horizontal" onto "both"
 PASS resize: "both" onto "horizontal"
+PASS scroll-behavior (type: discrete) has testAccumulation function
+PASS scroll-behavior: "smooth" onto "auto"
+PASS scroll-behavior: "auto" onto "smooth"
 PASS shape-outside (type: discrete) has testAccumulation function
 PASS shape-outside: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
 PASS shape-outside: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt (291128 => 291129)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt	2022-03-10 21:41:57 UTC (rev 291128)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt	2022-03-10 21:47:34 UTC (rev 291129)
@@ -113,6 +113,9 @@
 PASS resize (type: discrete) has testAddition function
 PASS resize: "horizontal" onto "both"
 PASS resize: "both" onto "horizontal"
+PASS scroll-behavior (type: discrete) has testAddition function
+PASS scroll-behavior: "smooth" onto "auto"
+PASS scroll-behavior: "auto" onto "smooth"
 PASS shape-outside (type: discrete) has testAddition function
 PASS shape-outside: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
 PASS shape-outside: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt (291128 => 291129)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt	2022-03-10 21:41:57 UTC (rev 291128)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt	2022-03-10 21:47:34 UTC (rev 291129)
@@ -133,6 +133,10 @@
 PASS resize uses discrete animation when animating between "both" and "horizontal" with linear easing
 PASS resize uses discrete animation when animating between "both" and "horizontal" with effect easing
 PASS resize uses discrete animation when animating between "both" and "horizontal" with keyframe easing
+PASS scroll-behavior (type: discrete) has testInterpolation function
+PASS scroll-behavior uses discrete animation when animating between "auto" and "smooth" with linear easing
+PASS scroll-behavior uses discrete animation when animating between "auto" and "smooth" with effect easing
+PASS scroll-behavior uses discrete animation when animating between "auto" and "smooth" with keyframe easing
 PASS shape-outside (type: discrete) has testInterpolation function
 PASS shape-outside uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with linear easing
 PASS shape-outside uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with effect easing

Modified: trunk/Source/WebCore/ChangeLog (291128 => 291129)


--- trunk/Source/WebCore/ChangeLog	2022-03-10 21:41:57 UTC (rev 291128)
+++ trunk/Source/WebCore/ChangeLog	2022-03-10 21:47:34 UTC (rev 291129)
@@ -1,5 +1,15 @@
 2022-03-10  Antoine Quint  <grao...@webkit.org>
 
+        [web-animations] scroll-behavior should support discrete animation
+        https://bugs.webkit.org/show_bug.cgi?id=237723
+
+        Reviewed by Antti Koivisto.
+
+        * animation/CSSPropertyAnimation.cpp:
+        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+
+2022-03-10  Antoine Quint  <grao...@webkit.org>
+
         [web-animations] quotes should support discrete animation
         https://bugs.webkit.org/show_bug.cgi?id=237721
 

Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (291128 => 291129)


--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2022-03-10 21:41:57 UTC (rev 291128)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2022-03-10 21:47:34 UTC (rev 291129)
@@ -3088,7 +3088,8 @@
         new DiscretePropertyWrapper<FontVariantPosition>(CSSPropertyFontVariantPosition, &RenderStyle::fontVariantPosition, &RenderStyle::setFontVariantPosition),
         new DiscretePropertyWrapper<FontVariantCaps>(CSSPropertyFontVariantCaps, &RenderStyle::fontVariantCaps, &RenderStyle::setFontVariantCaps),
         new GridTemplateAreasWrapper,
-        new QuotesWrapper
+        new QuotesWrapper,
+        new DiscretePropertyWrapper<bool>(CSSPropertyScrollBehavior, &RenderStyle::useSmoothScrolling, &RenderStyle::setUseSmoothScrolling)
     };
     const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to